Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4732917pxb; Tue, 5 Oct 2021 09:11:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwVLraZqXQXxKNa0hDOtMF2SWak92wP/LsBw7FnxiRmq4z/sNURkreNs8X/SKLZ095Rjfq X-Received: by 2002:a17:906:4447:: with SMTP id i7mr26581280ejp.153.1633450301655; Tue, 05 Oct 2021 09:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633450301; cv=none; d=google.com; s=arc-20160816; b=ep4af6vEx3iK49oZgJH7m0t/QJ2g+skCa29tx87KKg72YgUunhmMz9c/WheTHFykyX AHxIpJxhefv8S3jId4i0h6TvDoyixCidMFgoRaA2WuoX+QcemXwiwqYm9CGHXd0rZzNG YqZP3OJgokr6BcLMHW3kHmrITbhpsyir3n17vtmLKRx3MpMs71AGBYC0WfU569jCCAfo HOBes1GDHoddIz6iDmEbePFSvImcE+QJ9SlfJK5W3zG6eKN9aIJ/ILb8MHV8vpVa4wDT Hx3n6Ri0+f3C8ET/O6HhFjMfxhfqBApPZjrPC0TCzdSHfR+XGzKzu/sC2Fo9DezbdkZO GJ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=DceQoeiEGKU+395NO5qpAXcwd6zYtA9Kz1VG3En8jJg=; b=IXwv/b+uoNLaju2ovbu4q+Wtlz+JmIRAwh85F4zocsMD43h41YjUw7kmjDYZ8WgIaB YfzPR7GtGFSCRdQVi5jbFaFtLu2eLo7CZh+NKDOfC3OKZJDgKLj7RkGXE/OIaka0MZwd NUGXKLHCMzCUnMwbzvSkYRogmosbOHitV3pEbC0eNbxAr2SUH1gdM3BZyE7YFL1XDztD 6Dx/4N2jmpuh7sD71xnv/3UC6uV5z4rMuHmESej1aAFz7DIE6anBbUwPObib76cw1GYC qdB6jPa8mminq+NmnM87IeX6GrF2rpQHFcieGu81KLQBWPmEZSwSN4K6pHBQ5C+S72Th Rinw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=StUyflCR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si296070ejx.695.2021.10.05.09.11.14; Tue, 05 Oct 2021 09:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=StUyflCR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236433AbhJEQLS (ORCPT + 99 others); Tue, 5 Oct 2021 12:11:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236410AbhJEQLR (ORCPT ); Tue, 5 Oct 2021 12:11:17 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74C21C061753 for ; Tue, 5 Oct 2021 09:09:26 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id x4so2637901pln.5 for ; Tue, 05 Oct 2021 09:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DceQoeiEGKU+395NO5qpAXcwd6zYtA9Kz1VG3En8jJg=; b=StUyflCRX8LPeI0GR8M3xpBNvsuxh5KsirChuZRntlv9tLVLvCEPIlCt5UtDcHqgSi RfAkaEwbFsbaEw9ZXmG3MhNMppip3BA/NCHVuytu/6wY9gsoILHUI9aC9fYkzcvYuTyW WmKi96CjJOcmtN579Q5CqsmKdNAvlWgLrOeVJL0JdFznGKwXnfqN5GdSWUUUDAgIpoWi p4K2tgcwA27PZc7Wf/wlj3RUnsc++l7x4SdsN2yZ+zo/uDnbnPVjmucQeAk1M/zEq74f 5pqPyvg/P122jz81fX8DPThEKMxO/8oU+LYb2lZ+ck8iX1bK3muO1DG8yn1o0W+AH7Xh sy0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=DceQoeiEGKU+395NO5qpAXcwd6zYtA9Kz1VG3En8jJg=; b=4JycQN6MTPAyL9x0qODmENamVkznBMtcnlYub+f1duP7Kx/2ilbqVbDzLwMUMC/jHr JQQVep7nckzNT1dr2ZJZcp9IOOolOWIH7S3aVrDxPhz46c43QzF4tu8XIpSTbpNiwMNr cQq0uVj4JnCU283gw51IdSISNnfwIpYGno6k3+Rzya8UycPcTAy7xHjOrc79FZfGYkbV h2uX8ADNTMi507M53AT5/gjq38+8yBZ05XKAOn6hbZnjeJbP4HHLhlOiOuvVDE1yHmoM 91rGVqlgmNBwWpPCjTlXXXTtfl38a0WarQPEv2BBhGZ9vpJLfR7oAzNYem3JmxZEuj9j wm1g== X-Gm-Message-State: AOAM533qVL+AsofsngVu+r/sBKHJ+QcYuoHgan9ESjFUYzsJfiMHTtZG diwLVCN3DinPYSYPK02gMvY= X-Received: by 2002:a17:90a:2:: with SMTP id 2mr4771385pja.77.1633450165819; Tue, 05 Oct 2021 09:09:25 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id y3sm2918220pfo.188.2021.10.05.09.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 09:09:25 -0700 (PDT) Sender: Tejun Heo Date: Tue, 5 Oct 2021 06:09:23 -1000 From: Tejun Heo To: imran.f.khan@oracle.com Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] workqueue: Introduce __show_worker_pool_state and __show_workqueue_state. Message-ID: References: <20210928103106.391694-1-imran.f.khan@oracle.com> <447be1eb-87df-6941-1e5c-db79918dc77b@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447be1eb-87df-6941-1e5c-db79918dc77b@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, Oct 05, 2021 at 08:55:47PM +1100, imran.f.khan@oracle.com wrote: > Please let me know if I am missing some information that may be helpful here > and can be obtained only by dumping the states of other workqueues. > > Then while going through the code, it seemed better to break > show_workqueue_state into more granular entities which can be used later for > cases such as one mentioned above. Both sound reasonable to me. Do you mind updating the description? Thanks. -- tejun