Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [RFC net-next PATCH 16/16] net: sfp: Add quirk to ignore PHYs
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>
References: <20211004191527.1610759-1-sean.anderson@seco.com>
 <20211004191527.1610759-17-sean.anderson@seco.com>
 <YVwp9R40r0ZWJzTa@shell.armlinux.org.uk>
Message-ID: <66fd0680-a56b-a211-5f3e-ac7498f1ff9b@seco.com>
Date:   Tue, 5 Oct 2021 12:45:28 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <YVwp9R40r0ZWJzTa@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWJrYjhjNWNDY3kzNmNHRVZ3WFBMRmlleVpzdUlZa204WWppczR3SElpSVJP?=
 =?utf-8?B?ek1pWU9Ka1UvdWE4MGZJa1VERzBHQUt0eWR5RG9JcWsydnhteit4NFY1dnJT?=
 =?utf-8?B?VkM2L1dKRnArSlprVFY4R3dmZW5sK0RVWEZlVnAxdHBmbkw5ZTdPWW9yNGxn?=
 =?utf-8?B?bHdOa0w2Yi9kc01McnFHT0ZJYWpmNTZlL05SS2VuVk1vQ1JGNml5ZFRjenBL?=
 =?utf-8?B?akUxVzJkdWk1ZDFHbTdTQkJkWDk1VjY0TDAwdEdnbVdkQjdldzdhckVzWGpt?=
 =?utf-8?B?THNsYVpvV1dnQjRTVjdBdHk3cXBwVjhlcWp4dVpiU3dsYk1kcUhCNlpXY1hp?=
 =?utf-8?B?VXcyN2JPR2dLVmFsM2syb0F1Wk1qS1lRSE1OU1RENEtzNkR1N01uNkUreHp3?=
 =?utf-8?B?Y2FYZTIwWENBWGhxcWdEVFU1cWNQZ09TQzhnN0dESTZSUjF4TG9tNXdnYnRq?=
 =?utf-8?B?V3dWVXcwaUxMdU9xNzZhenYzMmErbGhFaVRxUWFUMmRVY1Nkbm4xYUVtR08w?=
 =?utf-8?B?TER6cituSkYySkdhTzNuSlR3Z2ZpZ0tOaFFtdmg2Rm4yUVNBNU4vRUF3UFpj?=
 =?utf-8?B?WXZQTzRJZ3QzUFVOanVnNEtyU2ljVkF1b1p1N0hKTHdaZmJrMkg2TmUvNEF6?=
 =?utf-8?B?bW96N3A4S3IrL1RTRDB1NGRYRFozcVdvL3VaS25UZkdzY3hsT3BabmlpNC9H?=
 =?utf-8?B?UEJOM3EvUllGaHQ1allrdUR4ZXpGMFI1WnBKVTlLeGREMXhnek9YclIydSt0?=
 =?utf-8?B?Tmd5SFh4MWZHUVlYejZXMWlhZG1IL0E1eFNuL3lmeUpqT2xYZWp0MlpSUk5n?=
 =?utf-8?B?Vk1hTjU5QUVSMkFWTE9tdmdVYjluZDhkeFJZWHczN2pra1FveWFQTitDbXlu?=
 =?utf-8?B?Z2pXSDNOQ3lLNTlIRU1IRVN3V1FCSW1JWW5DUnhQWXltWVBTZ2V4YWNSYkZT?=
 =?utf-8?B?MlpxSi9QemRSS3U0K0k2UitnQnNLeHVRcENrbVNnOXZHSW52ekxJV3RCQitK?=
 =?utf-8?B?em5mZ1NiQjA2a1hvQ2Q4QU1UMG8rei9STGdVTGxlZWd2cUFSNHg4M29uTTRG?=
 =?utf-8?B?MmsxMS9rYUVvc2pJN2RjQ0VucitOMXJUaW02TzVscndYNUJnMXBtRDd3eDBN?=
 =?utf-8?B?RnlPVGhtRDhQZGFZS2NnS2lMYy9yK2VzNWkzVzNoaHJiTkNiS0lvZ1U5aDRx?=
 =?utf-8?B?NDRzWWZ3SE9YYWZjQTBta0x1Ti8vT1QxcEZ0UTBIS0lETUM4c2dTZEc2V1dX?=
 =?utf-8?B?c3dHVktBYkp3K2VoSU5JeTF2eUxXZUZuUjgxbHoweDBFMWtjaW9ZSjZhcUpX?=
 =?utf-8?B?UnF6UUhnT3ZNc0ZCaHBMb0UvSENoN29sRkt6TXhtcmphSGQ2QWhoZksrUW1a?=
 =?utf-8?B?OGZ0NFppdWllNDhhMjBKTmphbWIxNTkreVJRVDVyYjFCU2VXTlBNbU5KeG10?=
 =?utf-8?B?MVFiQTBxZ0dCeXhLU1pYNTNXQnBxd2pEQkVjc0wvVGdnVW9OdFVyZmpIRzVH?=
 =?utf-8?B?YnNHN0hkTDlNWkZCSXV2Z1JGNytXWENRSjF0Nk9tNlF1OWM5aG9UYmdOM3F6?=
 =?utf-8?B?RThLb3BIbkZ4OWozV2dMYXB5bFFpeTN2VVg3TEdsTXk5NEp3a05WWEtGTjhR?=
 =?utf-8?B?c0VaZWJPV3RjZEdNdTl2akV2V1M2a1I5b0JJNlNYT3lPaUh3LzNFNXZWblly?=
 =?utf-8?B?ZUkwd0ZvUkJiM1ZIR2VYK0pqTmFvQmllbzc5RU1oWjkzOG9KbjBTZWhCcEdH?=
 =?utf-8?Q?7K0PtxSz4U9pt4evE9wsUBNucIztxWOhOkZsApk?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8fe197-1bf3-4081-8a0a-08d9881f8c77
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 16:45:33.2497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vAabfvKrJI5RFZI9aRgb/XdvWrZmoxPLAX8FKornkRBX46r/OsAHFokNEGnjVvm9uUQPv+74KJlrKVrFzqoDGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB5674
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/5/21 6:33 AM, Russell King (Oracle) wrote:
> On Mon, Oct 04, 2021 at 03:15:27PM -0400, Sean Anderson wrote:
>> Some modules have something at SFP_PHY_ADDR which isn't a PHY. If we try to
>> probe it, we might attach genphy anyway if addresses 2 and 3 return
>> something other than all 1s. To avoid this, add a quirk for these modules
>> so that we do not probe their PHY.
>>
>> The particular module in this case is a Finisar SFP-GB-GE-T. This module is
>> also worked around in xgbe_phy_finisar_phy_quirks() by setting the support
>> manually. However, I do not believe that it has a PHY in the first place:
>>
>> $ i2cdump -y -r 0-31 $BUS 0x56 w
>>      0,8  1,9  2,a  3,b  4,c  5,d  6,e  7,f
>> 00: ff01 ff01 ff01 c20c 010c 01c0 0f00 0120
>> 08: fc48 000e ff78 0000 0000 0000 0000 00f0
>> 10: 7800 00bc 0000 401c 680c 0300 0000 0000
>> 18: ff41 0000 0a00 8890 0000 0000 0000 0000
>
> Actually, I think that is a PHY. It's byteswapped (which is normal using
> i2cdump in this way).The real contents of the registers are:
>
> 00: 01ff 01ff 01ff 0cc2 0c01 c001 000f 2001
> 08: 48fc 0e00 78ff 0000 0000 0000 0000 f000
> 10: 0078 bc00 0000 1c40 0c68 0003 0000 0000
> 18: 41ff 0000 000a 9088 0000 0000 0000 0000

Ah, thanks for catching this.

> It's advertising pause + asym pause, 1000BASE-T FD, link partner is also
> advertising 1000BASE-T FD but no pause abilities.
>
> When comparing this with a Marvell 88e1111:
>
> 00: 1140 7949 0141 0cc2 05e1 0000 0004 2001
> 08: 0000 0e00 4000 0000 0000 0000 0000 f000
> 10: 0078 8100 0000 0040 0568 0000 0000 0000
> 18: 4100 0000 0002 8084 0000 0000 0000 0000
>
> It looks remarkably similar. However, The first few reads seem to be
> corrupted with 0x01ff. It may be that the module is slow to allow the
> PHY to start responding - we've had similar with Champion One SFPs.

Do you have an an example of how to work around this? Even reading one
register at a time I still get the bogus 0x01ff. Reading bytewise, a
reasonable-looking upper byte is returned every other read, but the
lower byte is 0xff every time.

> It looks like it's a Marvell 88e1111. The register at 0x11 is the
> Marvell status register, and 0xbc00 indicates 1000Mbit, FD, AN
> resolved, link up which agrees with what's in the various other
> registers.

That matches some supplemental info on the manufacturer's website (which
was frustratingly not associated with the model number of this
particular module).

--Sean