Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   <Tim.Bird@sony.com>
To:     <gregkh@linuxfoundation.org>, <mcgrof@kernel.org>
CC:     <tj@kernel.org>, <akpm@linux-foundation.org>, <minchan@kernel.org>,
        <jeyu@kernel.org>, <shuah@kernel.org>, <bvanassche@acm.org>,
        <dan.j.williams@intel.com>, <joe@perches.com>,
        <tglx@linutronix.de>, <keescook@chromium.org>,
        <rostedt@goodmis.org>, <linux-spdx@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-block@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v8 03/12] selftests: add tests_sysfs module
Thread-Topic: [PATCH v8 03/12] selftests: add tests_sysfs module
Thread-Index: AQHXs74tItgg1rfm00mmBKYUROs6y6vEf8UAgAArAZA=
Date:   Tue, 5 Oct 2021 16:57:55 +0000
Message-ID: <BYAPR13MB2503180449E0863CFD4672F5FDAF9@BYAPR13MB2503.namprd13.prod.outlook.com>
References: <20210927163805.808907-1-mcgrof@kernel.org>
 <20210927163805.808907-4-mcgrof@kernel.org> <YVxeTvKkYs938g94@kroah.com>
In-Reply-To: <YVxeTvKkYs938g94@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9YZlHFC5BrHJ7pC2ntWfXdxuexsli+3htodJcsUnhisAIcScgzuj4zLqW0cn?=
 =?us-ascii?Q?z4kPIW7QoQ7Fk7Qf6+v9lAeQgVzvNc0uTz7OswKdyOgHKEDUKpFKtxF3Q/LJ?=
 =?us-ascii?Q?EERbDYEkhvLzuuC623pfjR5P1AmTtIdGiQP1KRI7ZGSDuG4G3gaoWI1Nz3oP?=
 =?us-ascii?Q?chKusI1+UeKcrhnwzwyBJH3rRwCsEB/pJAHf+mr8wvnHYP8SnafDJ5gmpIlS?=
 =?us-ascii?Q?esBUHIuxwUj+vwAvQMKAGtVgEEXCsGENQmeoIVLNLlZP7YXx8qhr/T71bens?=
 =?us-ascii?Q?ABCezZg0NIwAiQEGlN35LIXp+Bfo3PVW5Smz137Hj9SUjtSw3fhbnYDJm2Wt?=
 =?us-ascii?Q?PsIdFYcEjhFFayjGxU506zJWPgaZjsH5VMb01n7n8tN/OaAHLtfo3ziS2KpF?=
 =?us-ascii?Q?6PFtPxlhATfx1xnTjL4n+4U3Kr3OsjfHYh34c22FZjO7rfhBpLLRZB+gcSSf?=
 =?us-ascii?Q?66smtVVyb+CQnXOiDjkrhnVkxBcVvoEsaefI5nJkL9bAkX4axjdl77GRT1zM?=
 =?us-ascii?Q?pxxxU013p8gE+UcByTBTcZiTDm707orWKYLUmv4lX4AN89xqsu0Voc2CCBSt?=
 =?us-ascii?Q?21qfbtqAhaFuiZxUQT8tfFHeCCwux+QoCqSuMS39W+GxKKhSperhBbB05eaG?=
 =?us-ascii?Q?CJjGE8x5Yi+l+RCemYfJgA2x28OJoeEWCpQS9Cj0iyhnCf6AkMGBovwMIQWb?=
 =?us-ascii?Q?LPT4WLMz+O6Szx4wpYrmMOIWbgXYTerCDcx31ZFYrBiVDKE3uYNNtznxZCGo?=
 =?us-ascii?Q?ypxjzdih/jpgOmvm5+yqzR/LTst2yJsivldghaNLiV8YctwAMoiYSGoLG5WF?=
 =?us-ascii?Q?rCfkdrTf4AJg9xrBxpp3+8VOKQdoIEZO2mVD2+T+X2YlIRVkb4lg8JQZVLP+?=
 =?us-ascii?Q?xolspMSYWB3VpMk/WJd7kscfuwd1PtD5VafWpPzr8aM08y6f80ZRSl4Bhmhh?=
 =?us-ascii?Q?yldMcaL2HtEkrHhRXVBlvHrJ2OOK/sTbpovWFrY3Wuxb0QxJHQejX+GYtNKV?=
 =?us-ascii?Q?GKwLq4Dhx9IyCwg8beBVE91FXd4Rh+sX50KYb4KnowR271KfDXJJlEMBpsU/?=
 =?us-ascii?Q?rX8d5Sj/SVoUbAp8OZh23jEmt+OfPfxCXIshfoiz7gUdUnYp88pUP9ZKt6HO?=
 =?us-ascii?Q?SI9TQhU09FKxczDaeo9O47wRxeivaZR+ET4ialyHWa82F/vhc5yo3TgWpHND?=
 =?us-ascii?Q?2zyCUBAPhl55U7cUgzMvLicNRCM4EwPvmZonPGB2JzT4jEbuGh6+UNP6wrsA?=
 =?us-ascii?Q?VTmZcL8WlUbxPwcRg9Rf61FtBYE6CJ/9NyIe/ek5A6xUEQiOHJ2akDf6o3LT?=
 =?us-ascii?Q?fDXubILr6aGTANWKDSYw2DrP?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR13MB2503.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcaf89cc-738e-498a-a50f-08d98821473f
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 16:57:55.9298
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LJMrV12k30eNAm1sFG++4jZuHUspmtP82pTHORpKt+u+WkhL+fw5zHRff7fAeDV10MkAggewImJioSOhxkcrwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB4455
X-Proofpoint-ORIG-GUID: EeylVr4NBOriIM-rODFr0fTwLx2nZqSX
X-Proofpoint-GUID: EeylVr4NBOriIM-rODFr0fTwLx2nZqSX
X-Sony-Outbound-GUID: EeylVr4NBOriIM-rODFr0fTwLx2nZqSX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-05_03,2021-10-04_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0
 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0
 mlxlogscore=999 mlxscore=0 phishscore=0 priorityscore=1501 suspectscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110050102
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, October 5, 2021 8:17 AM
> To: Luis Chamberlain <mcgrof@kernel.org>
> Cc: tj@kernel.org; akpm@linux-foundation.org; minchan@kernel.org; jeyu@ke=
rnel.org; shuah@kernel.org; bvanassche@acm.org;
> dan.j.williams@intel.com; joe@perches.com; tglx@linutronix.de; keescook@c=
hromium.org; rostedt@goodmis.org; linux-
> spdx@vger.kernel.org; linux-doc@vger.kernel.org; linux-block@vger.kernel.=
org; linux-fsdevel@vger.kernel.org; linux-
> kselftest@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 03/12] selftests: add tests_sysfs module
>=20
> On Mon, Sep 27, 2021 at 09:37:56AM -0700, Luis Chamberlain wrote:
> > --- /dev/null
> > +++ b/lib/test_sysfs.c
> > @@ -0,0 +1,921 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR copyleft-next-0.3.1
> > +/*
> > + * sysfs test driver
> > + *
> > + * Copyright (C) 2021 Luis Chamberlain <mcgrof@kernel.org>
> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y it
> > + * under the terms of the GNU General Public License as published by t=
he Free
> > + * Software Foundation; either version 2 of the License, or at your op=
tion any
> > + * later version; or, when distributed separately from the Linux kerne=
l or
> > + * when incorporated into other software packages, subject to the foll=
owing
> > + * license:

This is a very strange license grant, which I'm not sure is covered by any
current SPDX syntax.
" when distributed separately from the Linux kernel or when incorporated in=
to
other software packages, subject to the following license:"

Why would we care about the license used when the code is used in a non-ker=
nel
project?  If it is desired for the code to be available outside the kernel =
under a
different license, then surely the easiest thing is to make it available se=
parately
under that license.  I'm not sure why the kernel needs to carry this licens=
e for
non-kernel use of the code.

I would recommend giving this a GPLv2 SPDX header, and maybe in the comment
at the top of the file put a reference to a git repository where the code c=
an be
obtained under a different license.

Just my 2 cents.
 -- Tim

> > + *
> > + * This program is free software; you can redistribute it and/or modif=
y it
> > + * under the terms of copyleft-next (version 0.3.1 or later) as publis=
hed
> > + * at http://copyleft-next.org/.
>=20
> Independant of the fact that I don't like sysfs code attempting to be
> accessed in the kernel with licenses other than GPLv2, you do not need
> the license "boilerplate" text at all in files.  That's what the SPDX
> line is for.
>=20
> thanks,
>=20
> greg k-h