Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211001145036.18129-1-amadeus@jmu.edu.cn>
In-Reply-To: <20211001145036.18129-1-amadeus@jmu.edu.cn>
Reply-To: wens@csie.org
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Wed, 6 Oct 2021 01:48:37 +0800
Message-ID: <CAGb2v64r-OvoUQOHyTbJ9e==ZFASO54MW56Lw654nhwWM-bj7A@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: allwinner: NanoPi R1S H5: use the correct
 compatible for the eeprom
To:     Chukun Pan <amadeus@jmu.edu.cn>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-sunxi@lists.linux.dev,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Fri, Oct 1, 2021 at 10:51 PM Chukun Pan <amadeus@jmu.edu.cn> wrote:
>
> The 'microchip,24c02' compatible does not match the at24 driver, so
> replace it with 'atmel,24c02'. In addition, because the mac address
> is stored on this eeprom, set it to read-only mode.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> index 55bcdf8d1a07..4f01c17c49e0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> @@ -142,9 +142,10 @@
>         status = "okay";
>
>         eeprom@51 {
> -               compatible = "microchip,24c02";
> -               reg = <0x51>;
> +               compatible = "atmel,24c02";

You should add the atmel compatible as a fallback one, not replace the
microchip one.

Also FTR 24c02 is not the correct part number. It is 24aa025e48.


>                 pagesize = <16>;
> +               reg = <0x51>;

Please don't move the reg property. It should follow the compatible.

> +               read-only; /* This holds our MAC */

Please also add a cell representing the MAC address, and hook it up
to the GMAC. You can find an example here [1].

Regards
ChenYu

[1] https://lore.kernel.org/linux-rockchip/20210622034505.18824-1-cnsztl@gmail.com/

>         };
>  };
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel