Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 3/5] hugetlb: be sure to free demoted CMA pages to CMA
To:     Oscar Salvador <osalvador@suse.de>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        David Rientjes <rientjes@google.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>
References: <20211001175210.45968-1-mike.kravetz@oracle.com>
 <20211001175210.45968-4-mike.kravetz@oracle.com>
 <20211005093320.GC20412@linux>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <f1f011cc-5c5a-7c4f-5701-929918fa2dbb@oracle.com>
Date:   Tue, 5 Oct 2021 11:57:54 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <20211005093320.GC20412@linux>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDlkUkVYczR4M016ZVExRUJ0VHVBbW9GQTdCendKL1lNNkdaazB4Y1RRL3Zj?=
 =?utf-8?B?ZnFBZ29YVG1lbFRFVnQzQ1J0WHk0b0dhenRFNjNlSG9xWGlDemJNR1YrTHVR?=
 =?utf-8?B?NG9xamNlQkppWGRiaVZiRkpCbUIvMzFYRW9HbFV5U3NqY0JVbS9ROXptSWxv?=
 =?utf-8?B?MkRoSG1QQzgyaFkyb1cvR2lWc3pvdFJYWmh3S0JsM0I0dDB2NElvSmZkdzRK?=
 =?utf-8?B?Y0ZTSG9XTlFsRlJ5WkY0d0ltYStNRU5KakU1TDBXY2dxV21FeXlUK2tPTDZ3?=
 =?utf-8?B?aW9taFI4TnRHSDVFWWNhbHNrZGdBcnRzSUYvQm5naEhtRjYwaDRUcUJVaktH?=
 =?utf-8?B?VHkwcE5KNUM4Njg1ZlhiYnZrUGlqb2dPY3BFTTBON3dUTTA4RnBDN3R4M0ZR?=
 =?utf-8?B?bjB6TjBELzBqQTk5ekhIekpGY01GbERGcFdkVUswcmRTMm4vTnJSQk96Vk9T?=
 =?utf-8?B?bzBoTXRpZzNNTUpsVUJlT3k1TGxMeFJtWlRFaXY2ME9waUZTRnpNWlkzZHdr?=
 =?utf-8?B?SHVjaDYxOGxZVGkreVl4U2RCbURhaUtpZzUyY1ZIRnRKU1ZNY1dYQnpENE5D?=
 =?utf-8?B?eGo4aVhobFRWQi9DR3Q2RVI5K0x2Y0tZemc4dGQ5QkI0T3haU0NFVGVCdEhI?=
 =?utf-8?B?azRtTTh0REhJNnN4dW5yWHcxNnN6KzI5MVhiaVFLSE5XTzBaWndmQ1J5d3Rw?=
 =?utf-8?B?L0Zlcm4yV0U1SkU2c1JXUmVjcEkvN2RwdUZIRU1vcUMyVDJBNFUzc01zY21C?=
 =?utf-8?B?WlNkcE9PTDZNcXdBbGM2MDc5TjRQZzVKZ2NDVzJaUnI0NXpONlhiWHVHM3Nj?=
 =?utf-8?B?d0MrRndzbWx2cEY4RXp4WGZYM0lVNmpCZ09HeDMzSkV1MUJIWHNRZ0ZvV3hK?=
 =?utf-8?B?QWR0aWlDL2U1N0dxbkFlekErdFA0UGFvcUlUVjRidEFMQzluM1pKbTZOUGhP?=
 =?utf-8?B?OFdkblpMZ0FyNEh6UTN6anpkZ2tJM0FDVHoxNHpOQjljNEg0TGc0WXRoYzAy?=
 =?utf-8?B?aG9HVUg5QjRDNElBV2dZUXBkbnRrYjE3SXhJeUFva2k1NHNZc045ZmNZYkFl?=
 =?utf-8?B?ZnlBWkxxZmR2d3hwUmZvaUNXNHJZZSt3Uk54S0xyWVBqSnFpSkd6NlBNT1hI?=
 =?utf-8?B?cThVK1Y5UW9ycGljL2xsK3ZBdERQOXEvSHM1WkV2cXBnLzZJQTdVMTh2TFl5?=
 =?utf-8?B?Y3FaZ01TL2ZwY045UUJEUkwxc1FHOUU2OG1hMTZsN25KTnlvS25SbkxJOVdD?=
 =?utf-8?B?RmhxdUxXQmZmdlUvZG9Qb0ZuUlVLM1A5TkF0YU1JaXFZN3I3ZUlKSksyS0d0?=
 =?utf-8?B?VUlUNDFuaVlFNTQvSlZPdE5kQTZuckNZSnFYTEk2eFY0UzZORHBEcVZYZXdy?=
 =?utf-8?B?M2ROUS93NVFsMEM1T0NTWlBWWGNaNGxrN2tHWTB6bmpPY1VZRmZpUkxyRFg0?=
 =?utf-8?B?dzg1eTYvbnlXZkZUbXpsczA1dkRZQXo3THY3ejU0UmhXQzFvV0R3QnY5QVBT?=
 =?utf-8?B?c0gzU2ROaEVmaDNtWmpWMkhGUnd2S1AyYnZnOGl5NlNFY2hNRUdaejZkaGtC?=
 =?utf-8?B?YUtQNHNPWlhBeVNZSFA0U2V5S2lGNDFDZThOem5ib2R6emVNOW5jKzU1Q09r?=
 =?utf-8?B?TExHTytCbW1lUFViYlpJUHRSTk1McTFlWHF1S2tOY1hrdUV5WHUyWFZ1anF0?=
 =?utf-8?B?TTFQZGpJSTFlZ1dzeTRxTi90V2o0d1gwb0lmUnZzTEJMa25sZWdNdXdWTVk0?=
 =?utf-8?Q?2XAJ6HgLex3oYdw1umNmKv249cUKBOBoW7WY+2T?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce93b822-c3e7-456b-4c00-08d988320b8c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 18:57:58.0101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JPxrxMh1nOUgW+hcD7mf5k/MZUgxCJg+3BzCfGQ57aLE+e3J6Fh82m5Ga0llaYKNJZBJhzTexvS2MG2kds+hmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3544
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0
 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110050112
X-Proofpoint-GUID: SxLGx8M5ImoWa-OrOwsCdKzEDUZmD4vp
X-Proofpoint-ORIG-GUID: SxLGx8M5ImoWa-OrOwsCdKzEDUZmD4vp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/5/21 2:33 AM, Oscar Salvador wrote:
> On Fri, Oct 01, 2021 at 10:52:08AM -0700, Mike Kravetz wrote:
>> When huge page demotion is fully implemented, gigantic pages can be
>> demoted to a smaller huge page size.  For example, on x86 a 1G page
>> can be demoted to 512 2M pages.  However, gigantic pages can potentially
>> be allocated from CMA.  If a gigantic page which was allocated from CMA
>> is demoted, the corresponding demoted pages needs to be returned to CMA.
>>
>> Use the new interface cma_pages_valid() to determine if a non-gigantic
>> hugetlb page should be freed to CMA.  Also, clear mapping field of these
>> pages as expected by cma_release.
>>
>> This also requires a change to CMA reservations for gigantic pages.
>> Currently, the 'order_per_bit' is set to the gigantic page size.
>> However, if gigantic pages can be demoted this needs to be set to the
>> order of the smallest huge page.  At CMA reservation time we do not know
> 
> to the smallest, or to the next smaller? Would you mind elaborating why?
> 

It is the smallest.

CMA uses a per-region bit map to track allocations.  When setting up the
region, you specify how many pages each bit represents.  Currently,
only gigantic pages are allocated/freed from CMA so the region is set up
such that one bit represents a gigantic page size allocation.

With demote, a gigantic page (allocation) could be split into smaller
size pages.  And, these smaller size pages will be freed to CMA.  So,
since the per-region bit map needs to be set up to represent the smallest
allocation/free size, it now needs to be set to the smallest huge page
size which can be freed to CMA.

Unfortunately, we set up the CMA region for huge pages before we set up
huge pages sizes (hstates).  So, technically we do not know the smallest
huge page size as this can change via command line options and
architecture specific code.  Therefore, at region setup time we need some
constant value for smallest possible huge page size.  That is why
HUGETLB_PAGE_ORDER is used.

I should probably add all that to the changelog for clarity?

>> @@ -3003,7 +3020,8 @@ static void __init hugetlb_init_hstates(void)
>>  		 *   is not supported.
>>  		 */
>>  		if (!hstate_is_gigantic(h) ||
>> -		    gigantic_page_runtime_supported()) {
>> +		    gigantic_page_runtime_supported() ||
>> +		    !hugetlb_cma_size || !(h->order <= HUGETLB_PAGE_ORDER)) {
> 
> I am bit lost in the CMA area, so bear with me.
> We do not allow to demote if we specify we want hugetlb pages from the CMA?

We limit the size of the order which can be demoted if hugetlb pages can
be allocated from CMA.

> Also, can h->order be smaller than HUGETLB_PAGE_ORDER? I though
> HUGETLB_PAGE_ORDER was the smallest one.

Nope,
arm64 with 64K PAGE_SIZE is one example.  huge page sizes/orders are:
CONT_PMD_SHIFT	34	16.0 GiB
PMD_SHIFT	29	512 MiB
CONT_PTE_SHIFT	21	2.00 MiB

#define HPAGE_SHIFT	PMD_SHIFT
#define	HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT)

So, HUGETLB_PAGE_ORDER is associated with the 512 MiB huge page size,
but there is also a (smaller) 2.00 MiB huge page size.

After your comment yesterday about rewriting this code for clarity,  this
now becomes:

		/*
		 * Set demote order for each hstate.  Note that
		 * h->demote_order is initially 0.
		 * - We can not demote gigantic pages if runtime freeing
		 *   is not supported, so skip this.
		 * - If CMA allocation is possible, we can not demote
		 *   HUGETLB_PAGE_ORDER or smaller size pages.
		 */
		if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported())
			continue;
		if (hugetlb_cma_size && h->order <= HUGETLB_PAGE_ORDER)
			continue;
		for_each_hstate(h2) {
			if (h2 == h)
				continue;
			if (h2->order < h->order &&
			    h2->order > h->demote_order)
				h->demote_order = h2->order;
		}

Hopefully, that is more clear.

> 
> The check for HUGETLB_PAGE_ORDER can probably be squashed into patch#1.
> 
> 
>>  			for_each_hstate(h2) {
>>  				if (h2 == h)
>>  					continue;
>> @@ -3555,6 +3573,8 @@ static ssize_t demote_size_store(struct kobject *kobj,
>>  	if (!t_hstate)
>>  		return -EINVAL;
>>  	demote_order = t_hstate->order;
>> +	if (demote_order < HUGETLB_PAGE_ORDER)
>> +		return -EINVAL;
> 
> This could probably go in the first patch.
> 
> 

Both of the above HUGETLB_PAGE_ORDER checks 'could' go into the first
patch.  However, the code which actually makes them necessary is in this
patch.  I would prefer to leave them together here.
-- 
Mike Kravetz