Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 3/9] x86/xen: print a warning when HVMOP_get_mem_type
 fails
To:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
        Vivek Goyal <vgoyal@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        Mike Rapoport <rppt@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, x86@kernel.org,
        xen-devel@lists.xenproject.org,
        virtualization@lists.linux-foundation.org,
        kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org
References: <20211005121430.30136-1-david@redhat.com>
 <20211005121430.30136-4-david@redhat.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <4814ff2e-dc1f-71d5-9082-19f8ede9aeaa@oracle.com>
Date:   Tue, 5 Oct 2021 15:30:25 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20211005121430.30136-4-david@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d05rRVlmVmtTakJsQ0g4aUg2RTFJMk9KRi9nTTBWWjVoVDZHeWdtV2RwMEZz?=
 =?utf-8?B?T21ZNk01WS9hMHgrUmlMWnFUV3ZyYTNFZitqTDN3QXpzbGt4aUJqSG1FdlE4?=
 =?utf-8?B?RS9WaGlmWjBpYlNKcDFmVW5xVUhTWjRGZjZ6cEdMVm45Q0dYNDAxSTBMd0Ry?=
 =?utf-8?B?WndrWmJWdGw1SklxWHhiQUhTb3U3V0lNdmRzd2J2aUg2cTdGdGFhMkdleW4r?=
 =?utf-8?B?TnlIbkhDYkFnQkJVK09LRktLQ1dQV2YzTlRFNWhPbDBUblRoamhrWEdUdlYv?=
 =?utf-8?B?MFBEK2JJTk1PcmVjbEtHdTFjTEs4UHVCbjRadVpYdm02Y0FKK3JUcDg0M1Bo?=
 =?utf-8?B?Y0MwYVQ4bVcya3BKWkNodnE5QzRORE9yVnB1VTJ1ME1YQnFyREUyVWo1TC90?=
 =?utf-8?B?ZmhsbUJnSlFmN1VJRmJ6SS9KOEVrWndUVHp2MDdUblZ1b0l0UnYzQXlLMUxl?=
 =?utf-8?B?RkRBbG5Va0I3ZHpzRmZlNjcyZCtiQ1lKK0cwVytrY0dFamo4YWZnVnlrZ2tO?=
 =?utf-8?B?cWZUV0N2aE8wM2ZZZWl3NDM0c3hnb2RmRHAzSjhQSDM4MUNTbkpZbkg3dy93?=
 =?utf-8?B?WVQ5NjZ5Tys0MWEzYTFQK0F2SXNCRmtMc2JVRUlnYmpnTDBEWUg2alg3OEhB?=
 =?utf-8?B?NmhhRTg2YTV3QXJRaDhIblJ4Ni9CZ3VZYmxEVm1LcHB4ME52NUdOeWkwa0pV?=
 =?utf-8?B?RDVkdXZ0SjMzaE1vTEhIUVNVcHZnVWpVejhZbVoralkwbVhNMlpUOUU4TU43?=
 =?utf-8?B?OUhkOWpxVTdGVGNSaHpEME53Y1pjbDRNRGhqS0VydkMwN3hSNWtrNGduUVE0?=
 =?utf-8?B?aXN3L0U0SCtwYWI5eGJ4SURuZ01VOHBSaklib2daN2k3dW5zamtmd0Y2VUM1?=
 =?utf-8?B?UEdnK01ydVdEdDYzQ29sR210WEVnUHFtTFlrQkV6VmZKeW9BS0wvbnZqUDE2?=
 =?utf-8?B?dWl0Q0xQYVFyd3RPNHV2eERwLzJtc1BkU0dYcVpQTFFUMkxjeUlDV3ZjYjNw?=
 =?utf-8?B?MFYzOHJzV0xnTGQxb1JnbGpseFI1MlEvajhaTkxkRStaaUhCTzBTbkFQZjVE?=
 =?utf-8?B?ZjJnSGJpU0xUc1F1akJhWVAwL0lsVEp0SUozc3dONEtSSmtwSHRyN0pSbERi?=
 =?utf-8?B?TG90WmsrQVFhQ0VmNWZnK3ZFbEVXcStUd09UejQxOTlJU1JrcmFGWDdOMndq?=
 =?utf-8?B?RmNnK1MzTTZTd2NxUnUxWVh0WXNlMEppT0JHeG40ZXovbG51Lytsc1VlZlNs?=
 =?utf-8?B?UzYvWmt3cnZiSCtwZXkwSVZqWkhRSzE5Tlp1eXJOWlNsUWpJRDRQTWc4RHlO?=
 =?utf-8?B?UjhLc3d4VGF5Z3ZPRCtVc3I0d2Z3Y0hNQ2IxZ3NCc1lpTGpvS3VZcWx1anNs?=
 =?utf-8?B?bGpwRVpXMnk3Ui9NSDV1NVNGbmJobEtQWWtGWk5sN2tmd0ZQL2toTGQ5dlRI?=
 =?utf-8?B?SHJ2dE5HU2IvUHZrM21mSjB3anN4L2c2WCt2OE5JRVVEcEUveVc0eFR0aUMw?=
 =?utf-8?B?Zy9LVVFkSEQ1R0RieDZOWVRDZVR2QlovZll2TlgzUTREd2VLVlp5MTVITHVC?=
 =?utf-8?B?Nk9vdElWV2dxK3ZIZGdRRFFDL3YwYUxIbHdieU9remJ3cVhBU2lsTDBPQjc0?=
 =?utf-8?B?ZW9jL05HU3htMlRuM2VvTnpXckl3dHRFZVFPanEwUXprQkFaRXRKRm0xR1kr?=
 =?utf-8?B?RElFUC9PMUpFWkQxWUM1TURDcWlrY0I0R3BaVWhPeFJkL3k0bEpLZTNMTWxt?=
 =?utf-8?Q?tKw1pXOhijcX1e8+WQiuS1pBXLiB6c1LQA+P2lz?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 312199c2-60a4-41e4-a46e-08d988369a15
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 19:30:34.6417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: POou7n8kWBmLvWbSJ2PUsI2Mnu8eSjvULsPjJ2t3gVwTyhXivB3KASVF3npFAUQkDmispqca+JwJQklfVkHN886Vdy805nsmpi0NNXiUacw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4288
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110050113
X-Proofpoint-GUID: cswN1txcG0lsYY_KX0sYrFnNGrS2DbC2
X-Proofpoint-ORIG-GUID: cswN1txcG0lsYY_KX0sYrFnNGrS2DbC2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/5/21 8:14 AM, David Hildenbrand wrote:
> HVMOP_get_mem_type is not expected to fail, "This call failing is
> indication of something going quite wrong and it would be good to know
> about this." [1]
>
> Let's add a pr_warn_once().
>
> [1] https://lkml.kernel.org/r/3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com
>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>