Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jeff Moyer <jmoyer@redhat.com>
To:     Ramji Jiyani <ramjiyani@google.com>
Cc:     Benjamin LaHaise <bcrl@kvack.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Arnd Bergmann <arnd@arndb.de>, kernel-team@android.com,
        linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [RESEND PATCH] aio: Add support for the POLLFREE
References: <20210928194509.4133465-1-ramjiyani@google.com>
Date:   Tue, 05 Oct 2021 15:35:10 -0400
In-Reply-To: <20210928194509.4133465-1-ramjiyani@google.com> (Ramji Jiyani's
        message of "Tue, 28 Sep 2021 19:45:08 +0000")
Message-ID: <x49ilybjmdt.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi, Ramji,

Thanks for the explanation of the use after free.  I went ahead and
ran the patch through the libaio test suite and it passed.

> -#define POLLFREE	(__force __poll_t)0x4000	/* currently only for epoll */
> +#define POLLFREE	((__force __poll_t)0x4000)

You added parenthesis, here, and I'm not sure if that's a necessary part
of this patch.

Other than that:

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>