Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4913702pxb; Tue, 5 Oct 2021 13:11:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqBUTQCJKkV+tHjY/duoUCNVfaY64EEIBqsiOc0nI0vYD/dVmzKdcfpepXGnMdJizy90oM X-Received: by 2002:a17:906:5282:: with SMTP id c2mr27988830ejm.162.1633464683556; Tue, 05 Oct 2021 13:11:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633464683; cv=none; d=google.com; s=arc-20160816; b=m+OjrM9Uc4lc8yFbSStYDJqQ4OUWo/kaxqocNklXeQ3rmImz+882mKQRwRTnk1hGt+ EhM9aeXoBYBE0RdR3H8GHShhSHIS3o1DXpL5aof+GmCVVeWzCfhaOzRsiqM/UAGHjSsv /X7EVLoypyaThGgS+lbxa5h/ny+osX4ZDFi1wAqI/tY4pn/Ul7mstENn4DoTw0Bs1XN+ O6YOaZtFFhJwoqYdK4A1ChiNNPkiq5gThg5MugmFlpyOds/JJ0qLaDjKoMQUtcVXRkmc k25UUumKC5dh2AZuK/PTrraHnID7AqIkO16LM3/Y48G31xx0nknSYldkhQ6cIMHiZkW+ 2zEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sKBelqfDZhBi+zRfGGVenSqltLyPpX1IXwBP9eck9pA=; b=QgEsFfww7H0B0DVnadTaB6maidRiGGcd8Pjw3ydhnCs6RxlJJ55zaTYKQMJACx9AD7 ZGm7oFPMHbdFik/E61IXG8PvR85ZLc5P7xvA1JFhvGG+a5jrvk80y8O3Ja0F15/XrgF5 bopwEbETMuVTJ0lVu0lMUHS2aCwpzHYMPT5Zq7gP/fAGAYcjWkUFWVqjhNS1ohZkidcf hTa7KHIeYGR8kn1aft3Bdffs6sE1i92JEBsqEU7TOidr6pszMgSvUGMsfofkE+8hRkQk x1pVVWGNhQSt2MPXBYxsBZG2/qWqpsX5OfMev971aSEw8CjaucLKQ3cmu44DUeeZCB5A 51ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g10si7519850eds.200.2021.10.05.13.10.57; Tue, 05 Oct 2021 13:11:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234130AbhJEUKl (ORCPT + 99 others); Tue, 5 Oct 2021 16:10:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbhJEUKk (ORCPT ); Tue, 5 Oct 2021 16:10:40 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF100C061749 for ; Tue, 5 Oct 2021 13:08:49 -0700 (PDT) Received: from ipservice-092-217-085-112.092.217.pools.vodafone-ip.de ([92.217.85.112] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mXqk2-000847-5R; Tue, 05 Oct 2021 22:08:46 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 3/9] staging: r8188eu: remove write-only HwRxPageSize Date: Tue, 5 Oct 2021 22:08:15 +0200 Message-Id: <20211005200821.19783-3-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211005200821.19783-1-martin@kaiser.cx> References: <20211005200821.19783-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HwRxPageSize from struct hal_data_8188e is set but never read. Remove the component and the code to initialise it. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_halinit.c | 20 ------------------- .../staging/r8188eu/include/rtl8188e_hal.h | 1 - .../staging/r8188eu/include/rtl8188e_spec.h | 4 ---- 3 files changed, 25 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c index ab7b80144403..f71f25e234ab 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -524,26 +524,6 @@ usb_AggSettingRxUpdate( /* TODO: */ break; } - - switch (PBP_128) { - case PBP_128: - haldata->HwRxPageSize = 128; - break; - case PBP_64: - haldata->HwRxPageSize = 64; - break; - case PBP_256: - haldata->HwRxPageSize = 256; - break; - case PBP_512: - haldata->HwRxPageSize = 512; - break; - case PBP_1024: - haldata->HwRxPageSize = 1024; - break; - default: - break; - } } /* usb_AggSettingRxUpdate */ static void InitUsbAggregationSetting(struct adapter *Adapter) diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h index 08dedf4c91b8..fc6acbba17e7 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h @@ -360,7 +360,6 @@ struct hal_data_8188e { u8 C2hArray[16]; u8 UsbTxAggMode; u8 UsbTxAggDescNum; - u16 HwRxPageSize; /* Hardware setting */ u32 MaxUsbRxAggBlock; enum usb_rx_agg_mode UsbRxAggMode; diff --git a/drivers/staging/r8188eu/include/rtl8188e_spec.h b/drivers/staging/r8188eu/include/rtl8188e_spec.h index 1c96f7b81245..01aeaa4ac605 100644 --- a/drivers/staging/r8188eu/include/rtl8188e_spec.h +++ b/drivers/staging/r8188eu/include/rtl8188e_spec.h @@ -893,11 +893,7 @@ Current IOREG MAP #define _PSRX(x) (x) #define _PSTX(x) ((x) << 4) -#define PBP_64 0x0 #define PBP_128 0x1 -#define PBP_256 0x2 -#define PBP_512 0x3 -#define PBP_1024 0x4 /* 2 TX/RXDMA */ #define RXDMA_ARBBW_EN BIT(0) -- 2.20.1