Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4915780pxb; Tue, 5 Oct 2021 13:13:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKtQqsfO+Iy+T0ChpFkgxKk34RDfS3Bej/EF2Gb8vzY7KzgZU5euxYq3tpTiLPJYuTKjF0 X-Received: by 2002:a17:906:660b:: with SMTP id b11mr27006897ejp.427.1633464839122; Tue, 05 Oct 2021 13:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633464839; cv=none; d=google.com; s=arc-20160816; b=oJqVWn+etaotu2EltyYyngafZvF6DPE26Y94vigiCYI7NDRsBqps0SoRwug4hyXj/2 DhWw3q0wX8a+cAzjDp1hZShTy3Fxv2gZ/c9DAQMSqFaUqPXndcg9Ool7vQnp6XaA1oEm 9wl2Wsz6CtIeNvQQmRzaCSAx3Ss3rvYb4jlx4Yc3o1TjRcStQAPRwQOUcshy33UfwoUP bgBgZ7yBhUz2FZWz2Nof6dhgyICDqDY9U6RsT2hRU0//o+XtICM2MgbP4r3rHH4theJl 3AnTxlEU0JkwLBJ894JsEX5iMx2gCAY0FSruOajHgspGsiCYoTvp5zK/lPHu29+tjKpR vqZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=MyVMPJI4pTMSIdOCC6s1Usv6WtGWh8CpjWk33/8LWnE=; b=q+3BFOcGQHWfzA5ZEp9+unWadC6csNEFzLKahOUZmxhdWLBa2Bho2udw9REpw4JFBT XXy1UrlJs2FUQ/gFH95G9MuHe815vwvc0wNiKIM7cDT/boOMZd8XPiTCHdfjCIFBo2/z SRrLQiTn1eVTeAmuRh3Us07rWFrSOuvmEiHncrTN1Y0orandga0wY+JNPrZQzYo6BMfl pNedpvqNyjSmat0wIx1f7cz1Q1PPWIbnS87xxccwBGNCeRlNLJfRBrQzydzKhp4Cmwpt XY+b0NcuLJH1efG2YLiPHU04xJ0DqiUTrIGU5jlqv0vZHzmw6rOO+WCl6+t3KWJ6GbRA UUaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd34si6154400ejc.332.2021.10.05.13.13.35; Tue, 05 Oct 2021 13:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235874AbhJEUKr (ORCPT + 99 others); Tue, 5 Oct 2021 16:10:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235735AbhJEUKo (ORCPT ); Tue, 5 Oct 2021 16:10:44 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA660C061749 for ; Tue, 5 Oct 2021 13:08:53 -0700 (PDT) Received: from ipservice-092-217-085-112.092.217.pools.vodafone-ip.de ([92.217.85.112] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1mXqk5-000847-Mf; Tue, 05 Oct 2021 22:08:49 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 6/9] staging: r8188eu: HardwareType is write-only Date: Tue, 5 Oct 2021 22:08:18 +0200 Message-Id: <20211005200821.19783-6-martin@kaiser.cx> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20211005200821.19783-1-martin@kaiser.cx> References: <20211005200821.19783-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HardwareType in struct adapter is never read, it can be removed. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 1 - drivers/staging/r8188eu/include/drv_types.h | 1 - drivers/staging/r8188eu/include/hal_intf.h | 2 -- 3 files changed, 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index c15a75513c8c..9544300fab65 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -562,6 +562,5 @@ void rtl8188eu_xmit_tasklet(unsigned long priv) void rtl8188eu_set_hw_type(struct adapter *adapt) { adapt->chip_type = RTL8188E; - adapt->HardwareType = HARDWARE_TYPE_RTL8188EU; DBG_88E("CHIP TYPE: RTL8188E\n"); } diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/r8188eu/include/drv_types.h index 6d63429d06c6..9fa561ad340b 100644 --- a/drivers/staging/r8188eu/include/drv_types.h +++ b/drivers/staging/r8188eu/include/drv_types.h @@ -206,7 +206,6 @@ struct adapter { int pid[3];/* process id from UI, 0:wps, 1:hostapd, 2:dhcpcd */ int bDongle;/* build-in module or external dongle */ u16 chip_type; - u16 HardwareType; u16 interface_type;/* USB,SDIO,SPI,PCI */ struct dvobj_priv *dvobj; diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h index 29ca90a86844..ee8e67dafe7c 100644 --- a/drivers/staging/r8188eu/include/hal_intf.h +++ b/drivers/staging/r8188eu/include/hal_intf.h @@ -137,8 +137,6 @@ struct hal_ops { #define RF_CHANGE_BY_HW BIT(30) #define RF_CHANGE_BY_SW BIT(31) -#define HARDWARE_TYPE_RTL8188EU 17 - #define is_boot_from_eeprom(adapter) (adapter->eeprompriv.EepromOrEfuse) void rtl8188eu_set_hal_ops(struct adapter *padapter); -- 2.20.1