Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     brijesh.singh@amd.com, Tom Lendacky <thomas.lendacky@amd.com>,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH -v2] x86/sev: Make the #VC exception stacks part of the
 default stacks storage
To:     Borislav Petkov <bp@alien8.de>, Joerg Roedel <jroedel@suse.de>
References: <113eca80a14cd280540c38488fd31ac0fa7bf36c.1633063250.git.thomas.lendacky@amd.com>
 <YVbNlXwiASQEsG+x@zn.tnic> <YVb2AGXAwYx/OI6J@suse.de>
 <YVcF9ENTfLAGaLec@zn.tnic> <YVcGdpVuSsieFL8W@suse.de>
 <YVcSuVqmTPiw4YLk@zn.tnic> <YVdx/SRNkeRFnIuX@zn.tnic>
 <YVsY95SXNN4uTCCl@zn.tnic> <YVt1IMjIs7pIZTRR@zn.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
Message-ID: <ee362ce2-b2cc-026e-3137-c4860becd269@amd.com>
Date:   Tue, 5 Oct 2021 15:32:24 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <YVt1IMjIs7pIZTRR@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2RWbDUzb1Z3REhYdnNWTjRvTHp0RUVBeHlSelBlT2pLWXlzalFRV1VSV1Bs?=
 =?utf-8?B?ZmZ6OWFpS050MHVWVWtHb2ZNQW9aaDhoK3kyZHhDT0dSRUdxNXdNKzVkTmNx?=
 =?utf-8?B?eXFUa1IyM2U2RVRNTHp6RXdMRERTZk8wdDMvRithRTMxaGowUG9wdm1Udno1?=
 =?utf-8?B?Q2tSY0g2TDlWZTQvaTRKWWFYckUvY0tLYWlwMEVNcGE3Y2ErNWZwS1VkYkdR?=
 =?utf-8?B?djExeGI1S0NrRzc0eHYzWmhVNWpNemdEd2liQVY3L1ZGNk1Db3MvR1NYaGpq?=
 =?utf-8?B?M0NCYVh3Rkp3WWlrdWtBUW96MFJza25FaytwaFZhYlRQa250MHVWNHBzWStH?=
 =?utf-8?B?ZUhQR01WcWZSNTc5VFVmcWtqVnl5MXlwcXd1anVDZUhYekxUVDE0ZUNVY2dJ?=
 =?utf-8?B?NS9zR2VSakpxZ1RVUkR3MmFrREIwSjJNWUtJa3YwaEFPcGtpVUhrQzdvbFJa?=
 =?utf-8?B?cjMzNXFDTlFDdWUvQmpMZDZRWUlRbFk4aVlwVUhVVzY0RGdPOENTeE1VUDJQ?=
 =?utf-8?B?ZXkzN1ZReC83ZnBzZWdIcHE5Y2pQQVM0LzgrM21LVm13TmIwWm13SW9FY2JT?=
 =?utf-8?B?amJjdXc3QXNqbzRZVHVYOWxwUFZNQXRRTnhWN1lPd2JvYUU2c3BoM1UwcXlP?=
 =?utf-8?B?cnVaUDJsSzY5Z09LUS9MK3FkNnFCbUw3NFNraWovaGw5Q3h4TEd1L0RDRnpn?=
 =?utf-8?B?Z05yMW1vRlByZVl2WUhSTU5vK2w1bEZvblNMWk1PZ2FxTXI1YlNqcGxuTWJ2?=
 =?utf-8?B?UklGU1IrcUpkN0JDeHpDVHJGdmt1c2hOcWtwdVhFczlUa05mY25VaFBXb2V4?=
 =?utf-8?B?bm5NTVQrTmZld0FCai8rMzR1L2tqdnJaKzJFTnYyNVZlSkdTVTJsSmRVYytq?=
 =?utf-8?B?R3ZaL3pjL25iWkJpdm1wZnVDTU5nM0RDcHF1TXVUNitTOHRhTmFaT08yWTB1?=
 =?utf-8?B?QTc1eEc4YmVlWmxvQUVtOVo5anQ4c04ybGFCTEtReWVab3JHSUt1Yy9lMW9z?=
 =?utf-8?B?NDgzV0xjWjBhK2RYU0RnK0JoRVJiSmp4R1VUczNTN3BqNFJMUklkTUd5TmZt?=
 =?utf-8?B?d0tVY0pCb1JUY21ZeVJScWJuM3kyT0NYTWpnY0syV0ZzQlhjU2ZLSHFOK21n?=
 =?utf-8?B?V0c5QzkwQXVoWVdUdXB4LzZ0cm82UVdpc1BWUXlMWGtSaXJTMnljT3ZSRnE4?=
 =?utf-8?B?NHJEZkJmTEZTVjdka3pCWkRZcjBSK3JXNG5FYzlnQ3pKVWVKQ3hwMG9qalov?=
 =?utf-8?B?Zm9NVWYxd1NFMDlXMjNscURDTTF1MDBaSEIxRk56b25pWWQ0YXEzbzVaRTZU?=
 =?utf-8?B?eXRUTG0rMmpVUlZiOGExOXhheWppbEY3cHRuNVB4RVdqTy9kUmtjb29RSUNp?=
 =?utf-8?B?dTBvUGFheG5ONElMUjJldk5GSW9zMHA0a013dUxUUlFSRytnM2UxWHFzRktE?=
 =?utf-8?B?a014aGVBTldYTndoeHVhcjQwczBwVk1DRm1CdzR6MStBYjdUZlJya09ZR3V1?=
 =?utf-8?B?OGJ2RHg3aXE3UjhzN3ovcG5QQzBkQ3FLbXp1RkRwaGU5TnZXY2NmaXFaNXZz?=
 =?utf-8?B?aGlBNVdTeFh4UnR4ZFBVT3lRQ1lvVzFSVTNlWWF0V3JjampMNytvaGZYenpR?=
 =?utf-8?B?NVphM3hTbCtSVlBBSVFyRlNwQ1NHMkc0TDZiNisyZ09KUjEzK3VlV2lHT2VO?=
 =?utf-8?B?QkRaU203T0NRcUJHZEpMV254a3pPSkMzTVZaUEFpcXRnYlg5eG5YUk9WNUZq?=
 =?utf-8?Q?GJjwdutAneIz8fV2+sk+6E6h4mQ/wF0xmogGu4a?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b51d85e7-db10-4507-e48b-08d9883f3e21
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 20:32:25.8472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qFbN7U0PRXCPi6AQfgcrEbjsBdn1Ih3k4M+8ZRtG8Fye8lZFc6h8KrghZoPNE/XbXq7oYOngUmYSudv4XpqFkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2718
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/4/21 4:41 PM, Borislav Petkov wrote:
> Yap,
> 
> here's v2, now tested. It seems we do need that optional_stack_size
> second arg to ESTACKS_MEMBERS(), thx Tom.
> 
> ---
> From: Borislav Petkov <bp@suse.de>
> 
> The size of the exception stacks was increased by the commit in Fixes,
> resulting in stack sizes greater than a page in size. The #VC exception
> handling was only mapping the first (bottom) page, resulting in an
> SEV-ES guest failing to boot.
> 
> Make the #VC exception stacks part of the default exception stacks
> storage and allocate them with a CONFIG_AMD_MEM_ENCRYPT=y .config. Map
> them only when a SEV-ES guest has been detected.
> 
> Rip out the custom VC stacks mapping and storage code.
> 
>   [ bp: Steal and adapt Tom's commit message. ]
> 
> Fixes: 7fae4c24a2b8 ("x86: Increase exception stack sizes")
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---

Tested-by: Brijesh Singh <brijesh.singh@amd.com>

thanks