Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4945031pxb; Tue, 5 Oct 2021 13:54:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiE8aih6bJwU6vcsEXtD4rL2pkVpYADJ/X5zNIwqPapq9wTKqOh9sDQ3SnyOrpoSJUSw7K X-Received: by 2002:a17:906:2708:: with SMTP id z8mr26240018ejc.309.1633467298499; Tue, 05 Oct 2021 13:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633467298; cv=none; d=google.com; s=arc-20160816; b=W3o/nZMi5XtAUjBEHyw/iLVWCKz+Gtq+e5fWTfjEEzXdLgHh/vcIq3Sq3tuTJlYUkx ZDzanm+/n+PjLvJU9luuCEbohZ8D2DY67ZnoRSUWvs4PA4jmx/9ag+v6s0GQ9IUe91dd tQ6+OG8/UWeOJfRDb4Z8ZN5Hsv/fkYZpNMMUdlEUGSuQH8zF6GRWvEPJLWtbQaBkHgeF ud9r6aeZseQqA9+6LPwm23g1q3MJNQ1GVIlDUtf/TNRg3jMDAJZfYe3b5mBGUoo7CjlF krTL5vlwXHPd3rUZwWLT4xbIbQf3isQa55fZnAmNEfWH7BaAuImUH/CoEDHR7y9DRR34 6FXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ZXo9Quk6Y4H0fsDPUHzerD1eOvkjUACN8PkdHlibKSQ=; b=xjKxQglg826NfXQa/g9Zdsyv+hHV3kX1p68kprykJTPF/sISjOX84bjZ5+u5MXpRwx tJqJYx649rWw32dlBU6MGAauFWLEz+sqC2YHpcfXwybqCjLgTr5b4EuSKgWgcgy9ruay crVtgf03bT/YfIxpon3bRAJV1XlklEnZZz9CsVVesADZQuYGPo7fjwXzydVrcRi3RgmC IoFYYqNx+Ad3E3U0z2Qxt5PogC//7o4EMGXfYYBBwz5aEMgJxVhWyW6jYfGOBL0Ddn9J 6fMQq/dIchQ6hbKp2rcSN6kFKofgEcmGzvMmbMC3Iu4V5T1UGiCvDQwjGZXvdohi7b2e s0Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZlAxyYhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e3si22816222edc.615.2021.10.05.13.54.35; Tue, 05 Oct 2021 13:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZlAxyYhs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235661AbhJEUys (ORCPT + 99 others); Tue, 5 Oct 2021 16:54:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47056 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232250AbhJEUyq (ORCPT ); Tue, 5 Oct 2021 16:54:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633467175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZXo9Quk6Y4H0fsDPUHzerD1eOvkjUACN8PkdHlibKSQ=; b=ZlAxyYhsQkqUL8IYbuzo7H4So7R+Ky8FCdRqUkvpyCBBNKegxCqo+e5EXaVnUb+eByFPcv p34IMEvDPMutBJL74zkprb9gRo6cIxYz7fhJ18A6Qu4n0IaH4v6TlthAGJtasvIlUAbQYd SoP5DHCbefMnGXZNaJxFQvnJ4sBLLdc= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-sNI9Ef04P2-8SmAy7BumCQ-1; Tue, 05 Oct 2021 16:52:52 -0400 X-MC-Unique: sNI9Ef04P2-8SmAy7BumCQ-1 Received: by mail-ed1-f72.google.com with SMTP id v2-20020a50f082000000b003db24e28d59so489543edl.5 for ; Tue, 05 Oct 2021 13:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZXo9Quk6Y4H0fsDPUHzerD1eOvkjUACN8PkdHlibKSQ=; b=DtDGdlaRNe2kRp1ir3K5WMX6EEaZ088KeHJLi0U+MK5cUxtDhr5iFL94TtAKXx0E1Q GhNmCi/65n83jDl3kwHvutGKX7irzMjkfXBwtKpV9PZGbUvdwHBc93/S/hAhhlxi3461 iHRs2q4V0C+EtgbNJO2jzptacFoUjl4DK3SWyoHmWr1OFHPjAOxxFPWqc2A82wk0apNi Qj6knWyJlcZMh/KsN80opr3kCffckJL9X5MXvr7SdkH4rFxZ41YZIo9ZMP9jvywM8GRa 8DTlptZa3dK+8DYC5YXUD99aDH+E/nfe5DF/wIw9fUOrqeH04wV3xpWFmvDJsPcJA46h DoUQ== X-Gm-Message-State: AOAM533L7pi3QOcH7hpehQdr2aAzcuKVnvRqoxOMP0Rb0ZYBpVGjGVnk UPj7XuzYrKcfyC6RSiqp4s0+5cIMPo9nLebaIkuwN8tXU2v0u0W5JHmhAAIqWJgzBqddkhDuCa5 167xIteONFKUhjPE5LxCmlLkQ X-Received: by 2002:a17:906:d182:: with SMTP id c2mr27048698ejz.47.1633467171005; Tue, 05 Oct 2021 13:52:51 -0700 (PDT) X-Received: by 2002:a17:906:d182:: with SMTP id c2mr27048663ejz.47.1633467170772; Tue, 05 Oct 2021 13:52:50 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id n6sm9243298eds.10.2021.10.05.13.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 13:52:50 -0700 (PDT) Message-ID: <54360564-57e4-60de-60be-13177448ebc5@redhat.com> Date: Tue, 5 Oct 2021 22:52:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH][next] KVM: x86: Fix allocation sizeof argument Content-Language: en-US To: Sean Christopherson Cc: Colin King , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , David Stevens , kvm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211001110106.15056-1-colin.king@canonical.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/21 19:55, Sean Christopherson wrote: > I wasn't suggesting a full revert, > rather a "drop and pretend it never got applied", with a plan to apply a new > version instead of fixing up the current code. Considering that there are issues in the rmaps as well, I'd rather fix both the right way. Paolo