Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <448f1193-c22b-851d-4bf2-5aeec64268d1@gmail.com>
Date:   Wed, 6 Oct 2021 00:06:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH 6/9] staging: r8188eu: HardwareType is write-only
Content-Language: en-US
To:     Martin Kaiser <martin@kaiser.cx>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20211005200821.19783-1-martin@kaiser.cx>
 <20211005200821.19783-6-martin@kaiser.cx>
From:   Michael Straube <straube.linux@gmail.com>
In-Reply-To: <20211005200821.19783-6-martin@kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/5/21 22:08, Martin Kaiser wrote:
> HardwareType in struct adapter is never read, it can be removed.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>   drivers/staging/r8188eu/hal/usb_ops_linux.c | 1 -
>   drivers/staging/r8188eu/include/drv_types.h | 1 -
>   drivers/staging/r8188eu/include/hal_intf.h  | 2 --
>   3 files changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index c15a75513c8c..9544300fab65 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -562,6 +562,5 @@ void rtl8188eu_xmit_tasklet(unsigned long priv)
>   void rtl8188eu_set_hw_type(struct adapter *adapt)
>   {
>   	adapt->chip_type = RTL8188E;
> -	adapt->HardwareType = HARDWARE_TYPE_RTL8188EU;
>   	DBG_88E("CHIP TYPE: RTL8188E\n");
>   }
> diff --git a/drivers/staging/r8188eu/include/drv_types.h b/drivers/staging/r8188eu/include/drv_types.h
> index 6d63429d06c6..9fa561ad340b 100644
> --- a/drivers/staging/r8188eu/include/drv_types.h
> +++ b/drivers/staging/r8188eu/include/drv_types.h
> @@ -206,7 +206,6 @@ struct adapter {
>   	int	pid[3];/* process id from UI, 0:wps, 1:hostapd, 2:dhcpcd */
>   	int	bDongle;/* build-in module or external dongle */
>   	u16	chip_type;
> -	u16	HardwareType;
>   	u16	interface_type;/* USB,SDIO,SPI,PCI */
>   
>   	struct dvobj_priv *dvobj;
> diff --git a/drivers/staging/r8188eu/include/hal_intf.h b/drivers/staging/r8188eu/include/hal_intf.h
> index 29ca90a86844..ee8e67dafe7c 100644
> --- a/drivers/staging/r8188eu/include/hal_intf.h
> +++ b/drivers/staging/r8188eu/include/hal_intf.h
> @@ -137,8 +137,6 @@ struct hal_ops {
>   #define RF_CHANGE_BY_HW		BIT(30)
>   #define RF_CHANGE_BY_SW		BIT(31)
>   
> -#define HARDWARE_TYPE_RTL8188EU 17
> -
>   #define is_boot_from_eeprom(adapter) (adapter->eeprompriv.EepromOrEfuse)
>   
>   void rtl8188eu_set_hal_ops(struct adapter *padapter);
> 

Looks good to me.

Acked-by: Michael Straube <straube.linux@gmail.com>

Thanks,
Michael