Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4997652pxb; Tue, 5 Oct 2021 15:11:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwY+7ktpQtdOv2/XHUuzRO6An775b6PnXNvUxs7ftlH465hSIWHCB+HN1vA/y+YqFA8Smjw X-Received: by 2002:a65:6ab0:: with SMTP id x16mr17841802pgu.181.1633471866334; Tue, 05 Oct 2021 15:11:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633471866; cv=none; d=google.com; s=arc-20160816; b=GqqODdy3iwH9dGzpGAU+pk3J+n/d3mIc8qAIJKHsCwNmvQPRmvclGvsZUk7GI8lW6E U38rIvi9CLcaV8xA7iJTQXpScbc5pODJgp2QlUCaES3Mjo1H7nzgBFb9kSrAOu1asc4W 11T4Jy/A43sg++JgDGFzNU1jenTDhEN0iGfuvtdeZa89LBXb1le6VGnaxTmWvnoKGqC1 NgfID5qz+iYSwsZkBfQZEvyIQlJ1XmvRd7JUITBqNTQhXF3Wj7EEJ0fZL4G9TvexLGao N6php06ESe5QvzAHsK3vNQYV95vfET9O986/iD3n1urYOnRlAdOS8m+ESfCF79OcJR07 8tQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dmarc-filter:sender:dkim-signature; bh=TDiIAapy1mALvPm4QN1EqMx9ZaY3yYYOg48UXWo2LG0=; b=B7yG+6nKN3mgOTs6KPrLeWBjiwHmDNW6Mw3RZG9T/lTkkG7f/12ey9IAcSf+sDtZfU AdIwA2ozWmSSN+AJrGcD9S3Gpw9L2n05/xDxUgztuX87OY89SzTwqXSw1xdiSg0VNMod UUkuD837hn4r2a+llzYaPePeCUujeufoH1PA9QeDw4ndfhZW0gIqFrpG7OHEF7I0sYcK ACT2HfTAHE9HmLz+8EUYf1z7sJ8eesQTd2N09brQtmha/jXZEcs0IEQWyhFpbYJd3m0R lYtKcOYAdeUfY/EPbnoOI9LiriXJIGOvLsAVDZrwiXNTt5KMnQkKjLJzQSTF79gg5pkI i75w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=W3PMYZEw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si7312990plg.270.2021.10.05.15.10.53; Tue, 05 Oct 2021 15:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=W3PMYZEw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236844AbhJEWL5 (ORCPT + 99 others); Tue, 5 Oct 2021 18:11:57 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:60652 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236858AbhJEWL4 (ORCPT ); Tue, 5 Oct 2021 18:11:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633471805; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID: Sender; bh=TDiIAapy1mALvPm4QN1EqMx9ZaY3yYYOg48UXWo2LG0=; b=W3PMYZEwNBgNUmEY4SlHCtnMca9UXXCXF273ZorsvSv6IwDvQYr7O84qGRrfaEwsR+I7IfOr EBk2JHqREEhXTB0JJLJGHBjmE3kB8JBwKiI8/jhe6xOUKWXeL3yZm5XqpCtG7JGn9yWsmXxs 98tDP8fCDnW6Zg1VxrXDb+HUWEY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 615ccd3b003e680efbea3e83 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 05 Oct 2021 22:10:03 GMT Sender: jjohnson=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DB894C43617; Tue, 5 Oct 2021 22:10:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.135] (c-24-4-33-213.hsd1.ca.comcast.net [24.4.33.213]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jjohnson) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6144CC4360C; Tue, 5 Oct 2021 22:10:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 6144CC4360C Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Message-ID: Date: Tue, 5 Oct 2021 15:09:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH] [v18 2/2] wireless: Initial driver submission for pureLiFi STA devices Content-Language: en-US To: Srinivasan Raju Cc: mostafa.afgani@purelifi.com, Kalle Valo , "David S. Miller" , Jakub Kicinski , open list , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:NETWORKING DRIVERS" References: <20200928102008.32568-1-srini.raju@purelifi.com> <20211005123230.13813-1-srini.raju@purelifi.com> From: Jeff Johnson In-Reply-To: <20211005123230.13813-1-srini.raju@purelifi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/2021 5:31 AM, Srinivasan Raju wrote:> + fw_data = kmemdup(&fw->data[fw_data_i], blk_tran_len,> + GFP_KERNEL);> +> + for (tbuf_idx = 0; tbuf_idx < blk_tran_len; tbuf_idx++) {> + /* u8 bit reverse */> + fw_data[tbuf_idx] = bitrev8(fw_data[tbuf_idx]);> + } note kmemdup() can return NULL, hence the reference to fw_data[] can dereference NULL.