Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8] hugetlbfs: Extend the definition of hugepages
 parameter to support node allocation
To:     Zhenguo Yao <yaozhenguo1@gmail.com>, akpm@linux-foundation.org
Cc:     dan.carpenter@oracle.com, nathan@kernel.org, mpe@ellerman.id.au,
        benh@kernel.crashing.org, paulus@samba.org, corbet@lwn.net,
        rppt@kernel.org, yaozhenguo@jd.com, willy@infradead.org,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-mm@kvack.org
References: <20211005054729.86457-1-yaozhenguo1@gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <55d28037-4e0e-70b3-717d-a44b90f6f9ef@oracle.com>
Date:   Tue, 5 Oct 2021 15:59:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <20211005054729.86457-1-yaozhenguo1@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rmw2SVhId3ZwK1B0Vm5Ha3lBa1VtZjM3Rkc0QzIwYlNqQ1JjRWNFZWM3eFN0?=
 =?utf-8?B?U0c5Z0puaExnbXRacE5xeTFsb1REbG93YzVUQ3ZNbVpuTitHYWdqVTZoMFNt?=
 =?utf-8?B?anJYeXlGc2dDUHR2NERPdkUxWjRDYkhkQlh1TTdtMjFYRS9ac0hiQzdVb2NK?=
 =?utf-8?B?RFBXTjVXL0xmYXl5dzFUb3FEN240VEQ1cmZBaGI4ZVJHbmVrbVJ4T0lmZ0tI?=
 =?utf-8?B?d1lZb05XQXVSZmlaeGlOMHdvR2FMb1FzbXpsbGpsSElTb1J1a2RBU2s1M3N0?=
 =?utf-8?B?TWcxN093QmpqZnFoL3E0THNJeDg5THZmN1lNV2ZYbHpudzZyeGYrd2ZOVjdD?=
 =?utf-8?B?cTUvSXAyN0xyQ1dHNE5zb3lFNWNadnFqamRRUVNCdm9lcHRuYUlNaXZkUU9z?=
 =?utf-8?B?SEowRWgzeWpFZ1dvOUNLQVJOTmhuYjBMUUc0UkJCc3YrOG1sNEFDYmxFNmFR?=
 =?utf-8?B?U3NqMHZhWHR4RW1JSmR6YkkwTFdGc3J4cFdpTjZ3S0Z0VmpDb2xEZkVqWGlN?=
 =?utf-8?B?aFNTNWFIUEx1OHdaTzJINkY3Vng0cmlydWlHSFR4dzNEMnB2UG5WNnoyMTdm?=
 =?utf-8?B?ejcrcjBqamh2bThjTWE0ZGpaSlY5eFZyVGppdjBBVE1TemtTWDY3YmptSTBF?=
 =?utf-8?B?U3RjTHhvemN4amFPc3ZmT1J5a3JKVjdxZ2hqdUJzTXdsTVcwaDJYQ21samM4?=
 =?utf-8?B?Rjh5WUpGV2xPcmFLR2dsemU4SkFNUW43K1RtYm5pOVUybW9rZlppUEJrR3o3?=
 =?utf-8?B?L2NIejBxMldDeGJXckt3cm83SkZ2OUdsYmRMQnZhU1VXdC84RzdraFM4a2VX?=
 =?utf-8?B?bGppS2pFL1g5UE9Tc1Vnb2VpQy94Vndnc2Z5b1BFSituNVY3Y0xsSVc3bEJI?=
 =?utf-8?B?L3ZnaERaZG8xK3Y2SGsyYUZoa3VMZ3V1QUQweFY3VUV1dkNpZlFCZVV6ekpt?=
 =?utf-8?B?d0NxNzU3Y29rUVYrRUVVdVFEUFJGNGVFSTNiY2JUS28wVC8rSS8reHl4SjAw?=
 =?utf-8?B?dUQzMGxJN3pGU2FTc0d2Z0NCemdicDJpQkVnNmhiUkpvL2FoYnN1ckdqak9U?=
 =?utf-8?B?NHA5YUNSbmJZRklTcXhraWZTNEpkZU0yY1RWZFJCeGdnYXM1d2JnekwzYTdl?=
 =?utf-8?B?d2RaQ0Q0aWNEMXE3bVpyOUoxSDVjWFZqeVpITjU0WGtXTEpQK0RuNnFhMCtC?=
 =?utf-8?B?QkFVMHpML2ZaNFo1MHYzMUZ4UTdscWJDUHNNRFJxU0JEVFdsV3FIVCtyWjIv?=
 =?utf-8?B?eG8wRE1jcVlXWmtReEZlaXo5SFNDOHpRUkh2Yjk1d1NjS2ZiQTlCc0RUdWpy?=
 =?utf-8?B?RkNubHQrNDRycDRFOFdndlcxTW43ZHRTUFJaRVczQ3ZKaXNFUEtUdlFZUjIw?=
 =?utf-8?B?eTE1QWxDYXpkRExnQmlVZHpsempkdkR1NWtKdlBPa1VmZVN2bWFSTllvaDRF?=
 =?utf-8?B?bUMrdHVyZTFtWHBnWFZETjBtZG5sZEZVZ1hiYjdWR0tjOERhdFlHeXFtQmdC?=
 =?utf-8?B?WStkRzRtWjg5Q09FNU9VWmgvbEMzVUpZdnM0bDZzUVhaZDdmUllzSGR6OFJi?=
 =?utf-8?B?MFZKTWQwNFIvWUtQVUtvblRoVlFocHh0QkdwM1d5ekNLQ2hmTXdpNkliVmdM?=
 =?utf-8?B?SHVLWXFBRWtReDRuSkdneGlkT1hlenFlZlJDSkZRVzlwbERuQUJVOUNtblJY?=
 =?utf-8?B?NHRYaE1QelhWbmkxaGdBRGNNOWh4TENRcU1aVmZqTEpSQXRReEdmQTdsbW5r?=
 =?utf-8?Q?Xm80SVp8bE8NOCS+Hjh+KEEhgwz9POx3MyBpBWn?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 412ac727-d722-4652-2769-08d98853d6eb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 22:59:52.0647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x7QWw6imrhs5SuwFQL5ebqlZXJQDk4k5xqXTyGdOQiWsQrhjW5nNyLNCQW3Jh1ugW52S2luy+JGohSb5xP0Ddw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3970
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10128 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110050135
X-Proofpoint-GUID: O0u_37e_oFKxc7NYOE0uD1tAUU0zhhT2
X-Proofpoint-ORIG-GUID: O0u_37e_oFKxc7NYOE0uD1tAUU0zhhT2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/4/21 10:47 PM, Zhenguo Yao wrote:
> We can specify the number of hugepages to allocate at boot. But the
> hugepages is balanced in all nodes at present. In some scenarios,
> we only need hugepages in one node. For example: DPDK needs hugepages
> which are in the same node as NIC.
> 
> If DPDK needs four hugepages of 1G size in node1 and system has 16 numa
> nodes we must reserve 64 hugepages on the kernel cmdline.  But only four
> hugepages are used.  The others should be free after boot.  If the system
> memory is low(for example: 64G), it will be an impossible task.
> 
> So extend the hugepages parameter to support specifying hugepages on a
> specific node.  For example add following parameter:
> 
> hugepagesz=1G hugepages=0:1,1:3
> 
> It will allocate 1 hugepage in node0 and 3 hugepages in node1.
> 
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

Looks good.  Thank you!
-- 
Mike Kravetz