Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp5049117pxb; Tue, 5 Oct 2021 16:31:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEaaFDPq/kMZqwVESbBkQiNfEd914gHArn8+bLFdw6HS8eswkeQclBEPzST4I2+0d17h+d X-Received: by 2002:a17:906:b00c:: with SMTP id v12mr28606753ejy.222.1633476676849; Tue, 05 Oct 2021 16:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633476676; cv=none; d=google.com; s=arc-20160816; b=ZXngWOenxGdTpdG8ZSWHWMnSgWe1Yg1LlRxlS81OIJBa3DzO/3rvDZV7VknUVcAXGy 3AY7eUHdWN2XLA2DpNuQYXGWhUb236QprzY3kcok04IBMD6dv2QxGhFZ3+TH0YKndcHz ydKSPeCc3hZPaCYp0r26csTgJeWOcOZQYTh0pYPQ14yrHBoKwfCfJxDvSDkjbZ4i/W2W OTmsierJ+VsWNs7dL50icY3Z+DKaL92Drf2RjKdyTptnRipXwsvFqv9QfFcT+wsUclOW kxV5qmrpirc0EXYqtxABAGByGQOevkWvEaF/dl9BC8HibcPPSdtHakuDa1u88hTV9r7k Fcdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9OW4RL81pIUdiw+zgh4jW1IlqFN74R1uy0F7HjdiocU=; b=D7BVv06tTo1/K0u57hKQTlVdLQBl1u59O9+QMBgcYDlWw4kR5EwqR8FEhAk6+toX2E 9lee1/FjS9YP/yVQmd0TL2o7CjyPUM5+GB71mnNQb24+KZiu2LL7qz/SBM/jFG/KyQbV MnQ5XGtMDqE+IYL0boMSv9aqrG+rINt+BgxtN3SysQKscQEH+9z+F84jZjyG/StDi2y/ KyibwUwzscbCzgtJoowAt2+TFM1VxoLKgvMQbfBET4aZd5nF18iCz3z0y8R9xl61GNqx UHTU9FLGKe2luhMdxoOGlwliOBrotfX5QiSl3Ce1hV0FWdAizoI4o4frrfOpyaeco43n BIbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JZe8Zhyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si24003626ejj.365.2021.10.05.16.30.52; Tue, 05 Oct 2021 16:31:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JZe8Zhyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236906AbhJEX25 (ORCPT + 99 others); Tue, 5 Oct 2021 19:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233540AbhJEX24 (ORCPT ); Tue, 5 Oct 2021 19:28:56 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68239C061749 for ; Tue, 5 Oct 2021 16:27:05 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id j15so501412plh.7 for ; Tue, 05 Oct 2021 16:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9OW4RL81pIUdiw+zgh4jW1IlqFN74R1uy0F7HjdiocU=; b=JZe8Zhyu74F7LosaheIebMyt7o4GfPbBCkYP/9wP2Cz5wX4KOE7XbbNeECWc00RqwW wymyCg5V4ISRFq70VFTRDxHHKuIE3mZZh+D57pJGZrVYnSdYfT30twuDKw46x2HF+sfr 7V9upegH4l5xtKqyQvl9xjOqx3XNhO3TBrWHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9OW4RL81pIUdiw+zgh4jW1IlqFN74R1uy0F7HjdiocU=; b=yt3QlEiS6ibrkDHL7BcoPW1hJBWzGTejQoG/64I+FEI08ywrJ/1fjWHlxa71qe8xYK nD30RPliHGFHAmEzVxkBhlRmYOPa/oJ9Yp7kJX6ZqRQDk9iPpa/FDOTPlm8NLK+wfB/k p2yyNvtYbpdVYZE4ZBmsG6MeEK08WMN+hrTVGRNzUm6q/OooT2LqbjscdY+S713rPdHT ivFDAdYKMOK4tNWuP67qo2+kTuW2FuPGH6CON9mRMJEhKQz6wd0QXvZfsD3FqLty7NgP Zti+f2aWbvxu2c1lfVT+DT2EFQpnfqh4S1l9xZg7/cq6y6fUD8WroBnJQtUpIEG4qPXL +tvQ== X-Gm-Message-State: AOAM533by77JlBEgX4syRils4wxc63gzLaIqIsmvbgrIinA5UPu/TNRA EoJCPRHeUa3XqSF+RWmVimt0lw== X-Received: by 2002:a17:902:ab17:b0:13e:b2e0:58b with SMTP id ik23-20020a170902ab1700b0013eb2e0058bmr7910203plb.9.1633476424794; Tue, 05 Oct 2021 16:27:04 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c15sm6524084pfp.39.2021.10.05.16.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 16:27:04 -0700 (PDT) Date: Tue, 5 Oct 2021 16:27:03 -0700 From: Kees Cook To: Andrew Morton Cc: Chen Jingwen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , Michal Hocko , Andrei Vagin , Khalid Aziz , Michael Ellerman , Linus Torvalds Subject: Re: [PATCH] elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings Message-ID: <202110051626.0AB43704@keescook> References: <20210928125657.153293-1-chenjingwen6@huawei.com> <202110041255.83A6616D9@keescook> <20211005161212.2eb4ca912d131e72bf09bdd6@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211005161212.2eb4ca912d131e72bf09bdd6@linux-foundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 05, 2021 at 04:12:12PM -0700, Andrew Morton wrote: > On Mon, 4 Oct 2021 13:00:07 -0700 Kees Cook wrote: > > > Andrew, are you able to pick up [1], BTW? It seems to have fallen > > through the cracks. > > > > [1] https://lore.kernel.org/all/20210916215947.3993776-1-keescook@chromium.org/T/#u > > I added that to -mm on 19 September.: > https://ozlabs.org/~akpm/mmotm/broken-out/binfmt_elf-reintroduce-using-map_fixed_noreplace.patch Ah! Thank you. :) -- Kees Cook