Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210926033935.9258-1-irui.wang@mediatek.com>
In-Reply-To: <20210926033935.9258-1-irui.wang@mediatek.com>
From:   Hirokazu Honda <hiroh@google.com>
Date:   Wed, 6 Oct 2021 09:57:30 +0900
Message-ID: <CAL1V8yzgu6k=RbijbiPGZsbbQMSk0LQRewvgzOgmO0Bbg6wBcA@mail.gmail.com>
Subject: Re: [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max
 bitrate settings
To:     Irui Wang <Irui.Wang@mediatek.com>
Cc:     Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Tzung-Bi Shih <tzungbi@chromium.org>,
        Alexandre Courbot <acourbot@chromium.org>,
        Tiffany Lin <tiffany.lin@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Tomasz Figa <tfiga@google.com>,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Maoguang Meng <Maoguang.Meng@mediatek.com>,
        Longfei Wang <Longfei.Wang@mediatek.com>,
        Yunfei Dong <Yunfei.Dong@mediatek.com>,
        Fritz Koenig <frkoenig@chromium.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com,
        linux-mediatek@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Irui, thank you for the patch.


On Sun, Sep 26, 2021 at 12:39 PM Irui Wang <irui.wang@mediatek.com> wrote:
>
> Set recommend min/max bitrate range for MT8173 h264/vp8 encoder.
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>


I confirmed the patch worked with my own test.

Tested-by: Hirokazu Honda <hiroh@chromium.org>

-Hiro
>
> ---
> This patch dependents on "Clean redundant encoder format definition",
> which already accepted into linux-next.git:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/?id=4093eb21538ae4f2861b26f4615939e1fa50dc67
> ---
>  drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> index 4489a9744cd7..5dce3681ce94 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> @@ -388,8 +388,8 @@ static const struct mtk_vcodec_enc_pdata mt8173_avc_pdata = {
>         .num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264),
>         .output_formats = mtk_video_formats_output,
>         .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> -       .min_bitrate = 1,
> -       .max_bitrate = 4000000,
> +       .min_bitrate = 64,
> +       .max_bitrate = 60000000,
>         .core_id = VENC_SYS,
>  };
>
> @@ -400,7 +400,7 @@ static const struct mtk_vcodec_enc_pdata mt8173_vp8_pdata = {
>         .output_formats = mtk_video_formats_output,
>         .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
>         .min_bitrate = 64,
> -       .max_bitrate = 4000000,
> +       .max_bitrate = 9000000,
>         .core_id = VENC_LT_SYS,
>  };
>
> --
> 2.25.1
>