Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>,
        Linux-sh list <linux-sh@vger.kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Takashi YOSHII <takasi-y@ops.dti.ne.jp>
References: <20211005001914.28574-1-rdunlap@infradead.org>
 <20211005001914.28574-4-rdunlap@infradead.org>
 <CAMuHMdUwkOwLgbxjSwO0QCq+=jBL+e1z8X6NZHrrx0bv_zFq1A@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <d5f5735a-ab8b-0da6-c530-06426dbb2457@infradead.org>
Date:   Tue, 5 Oct 2021 18:06:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdUwkOwLgbxjSwO0QCq+=jBL+e1z8X6NZHrrx0bv_zFq1A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/5/21 12:26 AM, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> Thanks for your patch!
> 
> On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> Delete ieee_fpe_handler() since it is not used. After that is done,
>> delete denormal_to_double() since it is not used:
>>
>> ../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
>>    505 | static int ieee_fpe_handler(struct pt_regs *regs)
>>
>> ../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
>>    477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
>>
>> Fixes: 4b565680d163 ("sh: math-emu support")
> 
> Shouldn't that be
> Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
> ?

oh, ah, um. Yes, it should. Thanks!

> 
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 


-- 
~Randy