Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Oct 2021 14:06:55 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Yafang Shao <laoar.shao@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the tip tree
Message-ID: <20211006140655.6381bc5d@canb.auug.org.au>
In-Reply-To: <YUhuHcHeeNELK8cr@hirez.programming.kicks-ass.net>
References: <20210920113330.29f12b99@canb.auug.org.au>
        <YUhuHcHeeNELK8cr@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/vX4IllVywMMtwm8gQ4235.v";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/vX4IllVywMMtwm8gQ4235.v
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Peter,

On Mon, 20 Sep 2021 13:18:53 +0200 Peter Zijlstra <peterz@infradead.org> wr=
ote:
>
> On Mon, Sep 20, 2021 at 11:33:30AM +1000, Stephen Rothwell wrote:
> >=20
> > After merging the tip tree, today's linux-next build (powerpc_ppc64
> > defconfig) produced this warning:
> >=20
> > kernel/sched/debug.c: In function 'print_cfs_group_stats':
> > kernel/sched/debug.c:460:41: warning: unused variable 'stats' [-Wunused=
-variable]
> >   460 |                struct sched_statistics *stats =3D  __schedstats=
_from_se(se);
> >       |                                         ^~~~~
>=20
> So I've not seen that one *yet*, I've dont a bunch of SCHEDSTAT=3Dn
> builds. I do think GCC is being quite stupid for giving it, seeing how
> the whole thing is within if (0). The GCC people seem to disagree when I
> brought it up.
>=20
> Anyway, what I did in other parts was the below; that seems to 'upgrade'
> the warnings from -Wunused-variable to -Wunused-but-set-variable, and
> that latter *is* in W=3D1, and I'm arguing it should be promoted to W=3D2=
 or
> thereabout.
>=20
> Given that whole if(0) {} thing, I don't feel motivated to change things
> overly much and quite strongly feel this is the compiler being daft.
>=20
> ---
>=20
> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
> index 935dad7dffb7..ef71de01e4d7 100644
> --- a/kernel/sched/debug.c
> +++ b/kernel/sched/debug.c
> @@ -457,7 +457,8 @@ static void print_cfs_group_stats(struct seq_file *m,=
 int cpu, struct task_group
>  	PN(se->sum_exec_runtime);
> =20
>  	if (schedstat_enabled()) {
> -               struct sched_statistics *stats =3D  __schedstats_from_se(=
se);
> +		struct sched_statistics *stats;
> +		stats =3D __schedstats_from_se(se);
> =20
>  		PN_SCHEDSTAT(wait_start);
>  		PN_SCHEDSTAT(sleep_start);

Any progress on this?  I am still getting the warning.

--=20
Cheers,
Stephen Rothwell

--Sig_/vX4IllVywMMtwm8gQ4235.v
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmFdEs8ACgkQAVBC80lX
0GywCwf9FqdLggpxZhSH93X3gPvN72Es9QkzqDcYS6b3me34+2uwiayPgQi65O8c
zSkeTRqBJSy7bcBnX+1zJCdQG5djwRrekXu0UkkZKe/0PrwTLxHmsQUWPWWPfFdJ
DyiUEES9gBiQ449xovjPhvkhRTKG5pL2qdQ4i3vvl7sOIhoZIUIhHfNzQA2mCh1u
sWFp4NgTgvuzhaICSYCTbZJl51FvL/NE0Eljb+vSq4Ov/4OBSfpcgtFQ1amv6Gsx
eFHvH8WEHCCavi9AZmKQKVeDpDM4Aeb5dz59hHPuABQ/NtqfmyZYMKqS99ixARLw
sHGIv4vqr2tvcf8v5ZVe63gxGwfBvg==
=TUTX
-----END PGP SIGNATURE-----

--Sig_/vX4IllVywMMtwm8gQ4235.v--