Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211005212634.3223113-1-lucas.demarchi@intel.com>
 <CAHp75VfT+dSNYSntj9O5a9NVGnbf_raxWLiS7ciDMe-kRL-+=A@mail.gmail.com> <20211006063029.owhu5hjtaivib5d5@ldmartin-desk2>
In-Reply-To: <20211006063029.owhu5hjtaivib5d5@ldmartin-desk2>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 6 Oct 2021 10:14:12 +0300
Message-ID: <CAHp75VeajZkMzS5PA_D+cip_3BatdPS4mH6w_3zCoy_-yY0MdQ@mail.gmail.com>
Subject: Re: [PATCH] lib/string_helpers: add linux/string.h for strlen()
To:     Lucas De Marchi <lucas.demarchi@intel.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 6, 2021 at 9:30 AM Lucas De Marchi <lucas.demarchi@intel.com> w=
rote:
> On Wed, Oct 06, 2021 at 08:57:27AM +0300, Andy Shevchenko wrote:
> >On Wednesday, October 6, 2021, Lucas De Marchi <lucas.demarchi@intel.com=
>
> >wrote:
> >
> >> linux/string_helpers.h uses strlen(), so include the correspondent

correspondent

> >> header. Otherwise we get a compilation error if it's not also included
> >> by whoever included the helper.

...

> >I=E2=80=99m afraid this potentially can add into header dependencies hel=
l. What
> >about moving the user to the C file?
>
> I can do that, but I don't see the problem here... afaics it has been lik=
e this
> for 7 years, since commit c8250381c827 ("lib / string_helpers: introduce =
string_escape_mem()"),
> and the only way it was never borken is because
> linux/string.h is already being indirectly included from other headers.

> So just adding it here is harmless.

Quite possible.

...

> Anyway, if it's preferable to move these functions out of line, I can do
> so.

I have no strong opinion, whatever maintainers will decide then!

--=20
With Best Regards,
Andy Shevchenko