Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 Oct 2021 17:29:02 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     kuba@kernel.org, neilb@suse.com, mojha@codeaurora.org,
        jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hashtable: remove a redundant check in
 hash_for_each_xxx()
Message-ID: <YV3AvszXKVBA5BNz@kroah.com>
References: <20211006152100.17795-1-richard.weiyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211006152100.17795-1-richard.weiyang@gmail.com>
Precedence: bulk

On Wed, Oct 06, 2021 at 03:21:00PM +0000, Wei Yang wrote:
> The three hash_for_each_xxx() helper iterate the hash table with help
> of hlist_for_each_entry_xxx(), which breaks the loop only when obj is
> NULL.
> 
> This means the check during each iteration is redundant. This patch
> removes it.

Are you sure that the compiler didn't already remove it?  Is the code
output the same or different with this change?

How did you test this?

thanks,

greg k-h