Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-2-shy828301@gmail.com>
 <CAHbLzkpyxnvm3w0M_CEU7cYRCYr0coNCoiY1DvtnBzqb1R1nsw@mail.gmail.com> <20211006040015.GA1626563@u2004>
In-Reply-To: <20211006040015.GA1626563@u2004>
From:   Yang Shi <shy828301@gmail.com>
Date:   Wed, 6 Oct 2021 10:56:20 -0700
Message-ID: <CAHbLzkrEt3Ukr8YsJzx7AUdx7od2mqTKcG-D2sJAjo1RVs5e=w@mail.gmail.com>
Subject: Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check
To:     Naoya Horiguchi <naoya.horiguchi@linux.dev>
Cc:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>, Hugh Dickins <hughd@google.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Peter Xu <peterx@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 5, 2021 at 9:00 PM Naoya Horiguchi
<naoya.horiguchi@linux.dev> wrote:
>
> > Any comment on this patch and patch #3? I'd prefer to fix more
> > comments for a new version.
>
> No. Both 1/5 and 3/5 look fine to me. So ...
>
> > On Thu, Sep 30, 2021 at 2:53 PM Yang Shi <shy828301@gmail.com> wrote:
> > >
> > > When handling THP hwpoison checked if the THP is in allocation or free
> > > stage since hwpoison may mistreat it as hugetlb page.  After
> > > commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> > > handling") the problem has been fixed, so this check is no longer
> > > needed.  Remove it.  The side effect of the removal is hwpoison may
> > > report unsplit THP instead of unknown error for shmem THP.  It seems not
> > > like a big deal.
> > >
> > > The following patch depends on this, which fixes shmem THP with
> > > hwpoisoned subpage(s) are mapped PMD wrongly.  So this patch needs to be
> > > backported to -stable as well.
> > >
> > > Cc: <stable@vger.kernel.org>
> > > Suggested-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> > > Signed-off-by: Yang Shi <shy828301@gmail.com>
>
> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
>
> Patch 3/5 already has my Signed-off-by, so I think it can be considered
> as acked by me.

Aha, thanks. I will add your ack to patch 3/5 too.

>
> Thanks,
> Naoya Horiguchi