Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] usb: hub: Mark devices downstream a removable hub, as
 removable
To:     Alan Stern <stern@rowland.harvard.edu>,
        Oliver Neukum <oneukum@suse.com>
CC:     Dmitry Torokhov <dtor@google.com>, Rajat Jain <rajatja@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Chris Chiu <chris.chiu@canonical.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        levinale@google.com, bleung@google.com, rajatxjain@gmail.com,
        jsbarnes@google.com, pmalani@google.com
References: <20210929224823.556943-1-rajatja@google.com>
 <20210929224823.556943-2-rajatja@google.com> <YVVLxi/on9x6nfCZ@kroah.com>
 <CACK8Z6EamamgYExt629gyNrYKpvnu2Gh0eGOOvOa5LH-jnOmaQ@mail.gmail.com>
 <20211005145655.GJ621017@rowland.harvard.edu>
 <CAE_wzQ-XG3YBtKTmbn1LSGETCUg5AYjTmcnwOnc1h57OaL9+Cw@mail.gmail.com>
 <20211005195929.GA634685@rowland.harvard.edu>
 <c219168c-2727-0b44-7a05-7c0e31770de4@suse.com>
 <20211006161058.GB659483@rowland.harvard.edu>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <978eb183-e45e-0465-d3f0-3ec363f01211@suse.com>
Date:   Wed, 6 Oct 2021 20:36:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <20211006161058.GB659483@rowland.harvard.edu>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?chGCd5ydHrP7+2dotX+nJfpsCAEYg0PwPERbyVIZa2I73r4me3Q101kgyU+d?=
 =?us-ascii?Q?AiF9u3X6XsN27VkjM3u1rzfWVIhIx908cs/6BRwH/GE8FCONxVKle9U3t+9X?=
 =?us-ascii?Q?AlY5nRi7WeXbJaoxYyoaBj+EGIuF6EfnauKg5MoAfINw9jtGbrUKYoewzNJZ?=
 =?us-ascii?Q?30+U0TzyZkjaI5DPYTioj7SJFgUEBYFO2KQvyJq1jJWg78ksInPlsjVbU/0h?=
 =?us-ascii?Q?FHfBxADmnWhHBGzV7Qc7NdssxlkToiLk0hyWk4c0TJcWtLCxzYo71Vx8AhaF?=
 =?us-ascii?Q?Wd84ASfZGGo1/Wlpk/F6Y4d4183KLrRZxZQLZQGu0sr5x3TOfkKXF3uWN2GZ?=
 =?us-ascii?Q?7nYH8QhgGJXUd7IJz9tEouXGHzfL69H97HQMdhqWFDZtTHR9BcrpzZy0Y+vQ?=
 =?us-ascii?Q?01tUKrydcA/T003x836ld7rC52z+LFFU7dw1dd2RjlxYbLO50nrEzgSonrbN?=
 =?us-ascii?Q?dN4TDjceK2fwr/7fkn0G9UONljPbc9EPBtiP8+GV8UkqjXeA0CsyJh4T+WCh?=
 =?us-ascii?Q?sqmLUmKCcATdRbZLUaZtoCyFQIleeFDpp/3qC6q8kXb6T6wpNShCB2x5Pld9?=
 =?us-ascii?Q?Vp2iTQ+MdqRnCJSEHMvveJ/CVpKBhciSBffVwWHSJby9IsYf1C7hgfIOyqyI?=
 =?us-ascii?Q?XpEYdAb9w+scz9lCP/Yk8xCk4QEtthFKVtxLv/pn68YDXedJnJ4neIjfoUZz?=
 =?us-ascii?Q?wOziumaxRO9XkEeKoZUbhr0faRWooK5RrAZnLYlcX66jeJC2e7eGDSyKLJWr?=
 =?us-ascii?Q?WDTswkTCwYVnz+I6IHLnTVv8a6S3jneYjHJgNjDe2J50kri4spbJc6qFcRYJ?=
 =?us-ascii?Q?dNBbWsP6K3Aqb4XjxG5ddlaUX/wnwe8bFGsTbmTuRVe/YTqb0Zm0wEQ51SbF?=
 =?us-ascii?Q?E2WBlEZ2CzhCNu40y6dqMsFTUvmiiAFweINOuoGfCFmVNoJd+Iap74MAJajU?=
 =?us-ascii?Q?b+d4W0QUPdwIRILpymA7VZgUz6NhFcU9g6MCogWhWOCU2U2qw45Egll1AzDD?=
 =?us-ascii?Q?y5AHUodyn05vIhFetNG0IgoUSEYUpWabXfxs8LZu57WNLmhBOSSXmq/50SOo?=
 =?us-ascii?Q?8FDdLCk+Z6qfwYSPgtuHVDNrdeO5hj+YMrVYPZEyILWcUEIkELyZo48RsVtH?=
 =?us-ascii?Q?qRNlipBYkhN6SNv6sgN2n5GKRdjWG1g/AfVhBgmZA9gRhUaFlaH+OE+yUWhv?=
 =?us-ascii?Q?frfsNSyRz4MP/4hVmcm+Gi2y87L9H0LWUzzuvO2d9AHGEn6+69J4SUCe626u?=
 =?us-ascii?Q?qa9eORCcoMmVZ3eOY+h0EJQBZk8q+RRCN3iUVu0mQ4LGiW4/GndkJUFU5N7D?=
 =?us-ascii?Q?4qEsyS/S5xP2EEa9RixdxWrid/aO9CPqGzOkZBrCaq9I2FNUgZUeW2xWb0Vu?=
 =?us-ascii?Q?d5906windXfxdIKPdqOQVYZRatxs?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3886a0be-b0f4-4ab6-f567-08d988f8279d
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 18:36:05.3072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wt2C/B1+DFFzjmckLU1kpK6+K2/FWgJAwRf0cGStReOGXd7VyKkXCrfVdDs7fKw/xzHrZ4oUZkqFt/I+w6jrog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB3977
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 06.10.21 18:10, Alan Stern wrote:
> On Wed, Oct 06, 2021 at 11:37:58AM +0200, Oliver Neukum wrote:
>>
>> In theory yes. If your HC is removable by that logic every device is.
>> That renders the information content of 'removable' to zero. Everything
>> is removable.
> So we should add a new attribute.  Call it "unpluggable", perhaps.  It=20
> will say whether the device's immediate upstream link is=20
> hot-unpluggable.  Then the device is removable if its parent is=20
> removable or if it is unpluggable.

Hi,

yes that would solve the issue. We are basically trying two press two
attributes
into one and that does not work.

=C2=A0=C2=A0=C2=A0 Regards
'=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver