Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161009AbWLTXIH (ORCPT ); Wed, 20 Dec 2006 18:08:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161008AbWLTXIG (ORCPT ); Wed, 20 Dec 2006 18:08:06 -0500 Received: from smtp.osdl.org ([65.172.181.25]:47280 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161009AbWLTXIF (ORCPT ); Wed, 20 Dec 2006 18:08:05 -0500 Date: Wed, 20 Dec 2006 15:07:54 -0800 (PST) From: Linus Torvalds To: "Randal L. Schwartz" cc: Junio C Hamano , git@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] daemon.c blows up on OSX In-Reply-To: <86ac1iyyla.fsf@blue.stonehenge.com> Message-ID: References: <7vmz5ib8eu.fsf@assigned-by-dhcp.cox.net> <86vek6z0k2.fsf@blue.stonehenge.com> <86irg6yzt1.fsf_-_@blue.stonehenge.com> <7vr6uu6w8e.fsf@assigned-by-dhcp.cox.net> <86ejquyz4v.fsf@blue.stonehenge.com> <86ac1iyyla.fsf@blue.stonehenge.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 41 On Wed, 20 Dec 2006, Randal L. Schwartz wrote: > > According to my headers, "strncasecmp" is defined in , > "NI_MAXSERV" is defined in , and "initgrps" is defined > in "unistd.h". So this patch works (just verified on OSX), but I > don't know what damage it does elsehwere: Look at "cache.h": the first thing it does is to include "git-compat-util.h". And THAT in turn does include ALL the headers you added (string.h, netdb.h and unistd.h). So it would appear that for OS X, the #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */ #define _GNU_SOURCE #define _BSD_SOURCE sequence actually _disables_ those things. Some googling finds a python source diff: # On Mac OS X 10.4, defining _POSIX_C_SOURCE or _XOPEN_SOURCE # disables platform specific features beyond repair. - Darwin/8.*) + Darwin/8.*|Darwin/7.*) define_xopen_source=no ;; (and Ruby shows up as well in the google) Can you try to grovel around in the OS X headers, and see what the magic is to enable all the compatibility crud on OS X? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/