Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: `AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT=y` causes AMDGPU to fail on
 Ryzen: amdgpu: SME is not compatible with RAVEN
To:     Alex Deucher <alexdeucher@gmail.com>,
        Borislav Petkov <bp@alien8.de>
Cc:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>
References: <8bbacd0e-4580-3194-19d2-a0ecad7df09c@molgen.mpg.de>
 <CADnq5_ONNvuvTbiJDFfRwfnPUBeAqPmDJRmESDYG_7CymikJpQ@mail.gmail.com>
 <YV1vcKpRvF9WTwAo@zn.tnic>
 <CADnq5_N5+SEW4JyXLc=FdSHnSbXrGKWjEw4vW1Jxv9-KdWf+Jg@mail.gmail.com>
 <96f6dbed-b027-c65e-6888-c0e8630cc006@amd.com> <YV3hbK/uhChK5Pse@zn.tnic>
 <CADnq5_NgR7tdyeGOdqHCGRMd9DCTJwcRfBXaZcOQDJbEeypf2A@mail.gmail.com>
 <YV3pQCZ4GYbdpEm5@zn.tnic>
 <CADnq5_O8rTnWH5md1qWauW_3sDTO+qf=vNzPZC1E70NT7Wb99A@mail.gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <dfc53444-ff3d-1bb4-2b8a-0041e5d5db8f@amd.com>
Date:   Wed, 6 Oct 2021 16:39:21 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CADnq5_O8rTnWH5md1qWauW_3sDTO+qf=vNzPZC1E70NT7Wb99A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRnMlJvZkdGek52M1dZMGlla0JpYVUxNVR6dzZaQlRueStmUFNwT0hZQ1hp?=
 =?utf-8?B?RTVsdm1JKzRLQ0NIRmdsSWhqY1V4azRNb2RNQmRiM0lqTnBITUx6RktyUTJI?=
 =?utf-8?B?VkJGUW1jMlN6dWhheUpKbnFtcm9PMWNhT2RLcXV6WGw4cDZWODZvdDgxRkVS?=
 =?utf-8?B?dHd5Z25PRDkvcHQ1akVJenZyTmE5dTdRNUppQ0xXUmxmQ2tNeVV0cGxYeWlp?=
 =?utf-8?B?MjNEUE50RTZnM3Qxc2dDZlp6dGtmYkM2elRsVkZkbzNvUEpUTlZHdjNPQmJR?=
 =?utf-8?B?SE05R085UkhWVnJkLzY4a1JkVEJ6RHNsaHFLZzZKNjNnUlNNdGJRWWlRdzN4?=
 =?utf-8?B?WVVBSmZUZGJJT3pSZkVJaHEySlhlU2JFdjVLYy9LbldkV2N3bFlZY1dqVE5Q?=
 =?utf-8?B?YTRiRjBrRmk0N2d2SytidU1ORzJXV3d1MFBlSjBoODh5VlQybzZKcGpIbFZu?=
 =?utf-8?B?Nk9XSFNHQVNuNk11eTlQQ255bTRvdDVmRFI1OEN0Tmt4RnN1SWdYVTRhWks1?=
 =?utf-8?B?aDBYaW5NQUg4UUNqc3N6elFjNW9BMkJXdy9uVS9kajRWeC9vNFBVVGdqQ3Bq?=
 =?utf-8?B?NWxkTHpkSERWYVc2SFl3cXJhcXJ1Qlo3UktVaFZranNXWnZseHMyWkZyOERr?=
 =?utf-8?B?YnBFUDFGb082a3MxMUVpRkc1aDRhcEFXZWRSSy83ZkordTBNb2kwQVRtLzRx?=
 =?utf-8?B?U1ZENFJJc1RoVXg0dVIvVTd3blhzZWhxZ1g2djJnOVEyUk4rU2FOOStpOHNh?=
 =?utf-8?B?S0VrMHRlbmU1VzYxdm9QaDVrT1JKYTdVUGVhYkp2eDNXUEU1MlZPQ1ZETXNB?=
 =?utf-8?B?KzZUc2J6NGJSNUxydkRyOTdkRkx3L0lId05QcVpSNGhkVmdNWVByOFdVMXhl?=
 =?utf-8?B?Z1Q1Zk5mOUw0L3RwNGxaeDJyQVlqekp6YWQ2aWxBUG1uanJKSW1Oa3FWcXlk?=
 =?utf-8?B?MjhtWXpOK2N5NE51SnUvOFJ1V0pTT2Qrc1F5eDJNSmZUSUNKOTBPRjVaYXpD?=
 =?utf-8?B?T2pVZ1ROazlZZFkyT2twcDBUVDhnOHhEaGtCSU5ROXV3elM1OWd0MWtuUTZx?=
 =?utf-8?B?cEpxRWlTTHNLOERXRHlrUldHTjdNRDlyZ0ozTlRYNWNEY3hvTDBQN082aWYx?=
 =?utf-8?B?S0FteVlnVGdySUxxRGpaamFSY2dBMWNNd09zOG9MeGhKZnRKc3RQWFNtWmVW?=
 =?utf-8?B?YXJuRFBSWkUvSTZ0L2RzUHh3R2hOcC9SNTJSWnJ4S0luZWVpQXFjQlBZckU1?=
 =?utf-8?B?ZzViR2x0ZXpiMGYreGkwN3BCSzliN0pTNEFHeE9WWDJ0di9TdC9YUm9yRHJU?=
 =?utf-8?B?R3psMHNDNDN0aVNUOXBJZzdwWGJ6dWJaUjB1MnJ5b3ZKeFdGRTBaN1pRRG8z?=
 =?utf-8?B?eXozc3dDVGdmemNWSCthVVg1ZERnZm52bzJaR2k4Q2ZSSHJIYXJjaU1pWkFQ?=
 =?utf-8?B?QURrTm5meFJRdE5Cdnhjb2tZemxodVFoUGNIUHc0NFk3MHlWU2VXcjU2eVQ1?=
 =?utf-8?B?SmNSaElWK2tob2t6Tk8xQmVFVjVweTZzaUpvWmgxWlFlOXFxblUyYWMvNlF0?=
 =?utf-8?B?R1pWS2haSTI3b3BqK1ZkcWM5VGlPTitpRnVUS012bnBDeEVyR2ZQZGhLUTlT?=
 =?utf-8?B?MlBmRTN0cnVRV3dwdlMxME16eTBmSXh2dE03ZEN1aGZZZklyUkgyUDdKZmlT?=
 =?utf-8?B?dVV5bDlML0tHWk1nRTB5aGR0WDNJR29FZEVoeitFdk1PU0VybVBHdndNZW9r?=
 =?utf-8?Q?o55c0wfXg+WxBYdlshqODsCRpIRYRfnO7as0h+g?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66bc076c-3a3a-4dd0-278b-08d98911c37c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 21:39:23.9168
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IKmVzZf+bYejX5BB+dP1QXe2BAt3eXDqhqAd+K4DioZ3kxg9sD+6foKAjw/w6Eo0WKyTq/k6X2bhy62vCMrCAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5184
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/6/21 1:36 PM, Alex Deucher wrote:
> On Wed, Oct 6, 2021 at 2:21 PM Borislav Petkov <bp@alien8.de> wrote:
>> On Wed, Oct 06, 2021 at 02:10:30PM -0400, Alex Deucher wrote:

> 
>  From the x86 model and family info?  I think Raven has different
> families from other Zen based CPUs.
> 
>> And even if we do, that's still not accurate enough - we wanna know
>> whether the IOMMU works.
> 
> Right.
> 
>>
>> So I guess we're all left to the user to decide. But I'm always open
>> to suggestions for solving things in sw and not requiring any user
>> interaction.
> 
> @Tom Lendacky Any ideas?

I think user decision is probably going to be best. We have to enable and 
encrypt the kernel for SME very early in boot, that, short of 
family/model/stepping checks, there's not a lot that we can do.

Thanks,
Tom

> 
> Alex
> 
>>
>>> Other than these comments, looks fine to me.
>>
>> Thx.
>>
>> --
>> Regards/Gruss,
>>      Boris.
>>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&amp;data=04%7C01%7CThomas.Lendacky%40amd.com%7C88c625e0b5684c2df98708d988f84d26%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637691422304849477%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=47jfRaCMn16Ii7xGLXQ31RRdr7Iz%2BG52zU7u%2B3YEM2g%3D&amp;reserved=0