Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211001112522.2839602-1-ribalda@chromium.org>
 <20211001112522.2839602-2-ribalda@chromium.org> <YV4blXBkmYhCXxKG@paasikivi.fi.intel.com>
In-Reply-To: <YV4blXBkmYhCXxKG@paasikivi.fi.intel.com>
From:   Ricardo Ribalda <ribalda@chromium.org>
Date:   Thu, 7 Oct 2021 00:27:52 +0200
Message-ID: <CANiDSCtHKOAmC3=vmyz0Ky2ZJ5Xg4rfwoetSc+=XXt2msE2KPg@mail.gmail.com>
Subject: Re: [PATCH v3 1/8] media: ipu3-cio2 Check num_planes and sizes in queue_setup
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Yong Zhi <yong.zhi@intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sakari

Thanks for your review :)

On Wed, 6 Oct 2021 at 23:56, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
> Hi Ricardo,
>
> On Fri, Oct 01, 2021 at 11:25:15AM +0000, Ricardo Ribalda wrote:
> > If num_planes is different than zero num_planes and sizes must be
> > checked to support the format.
> >
> > Fix the following v4l2-compliance error:
> >
> > Buffer ioctls (Input 0):
> >     fail: v4l2-test-buffers.cpp(717): q.create_bufs(node, 1, &fmt) != EINVAL
> >   test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
> >
> > Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> I attempted to apply the set to my tree but it doesn't seem to.
>
> Do you happen to have extra patches in your tree?


I think that I was on top of Linus.
I just rebased it on top of yours and resend it as v4

Thanks!


>
> I just pushed mine to the master branch here:
>
>         https://git.linuxtv.org/sailus/media_tree.git/
>
> --
> Sakari Ailus


--
Ricardo Ribalda