Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Prabhakar Kushwaha <pkushwaha@marvell.com>
To:     Tim Gardner <tim.gardner@canonical.com>,
        Ariel Elior <aelior@marvell.com>
CC:     GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Shai Malin <smalin@marvell.com>,
        Omkar Kulkarni <okulkarni@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH][next][RFC] qed: Initialize debug string array
Thread-Topic: [EXT] [PATCH][next][RFC] qed: Initialize debug string array
Thread-Index: AQHXurrxuEQkmaf7f0aob/33cIz/XavG86Qw
Date:   Thu, 7 Oct 2021 05:11:32 +0000
Message-ID: <MWHPR18MB10712FAF925C572621A5B1EDB2B19@MWHPR18MB1071.namprd18.prod.outlook.com>
References: <20211006140259.12689-1-tim.gardner@canonical.com>
In-Reply-To: <20211006140259.12689-1-tim.gardner@canonical.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FvHsh8DY3R27EELQDKFK1V+qoNfCBy/gsjUY2jkw549SZecARrmAeZJFJfYq?=
 =?us-ascii?Q?seGgMQ09TceHWeOA7cbpavnjuKVM0iceOn4oONBaGpOnO/Szh5qgy+mpBCJ3?=
 =?us-ascii?Q?QYlr7C0dfZa9OKAYag6FNwXg8eK80RljVoRwdgeD3cDoh8bXqVYKcYB2rh4H?=
 =?us-ascii?Q?TuyHD7gR73r25ywfyJ1+z0W62BX+9fA21xkd9zqwTsSswoC5NpSriypBjoBw?=
 =?us-ascii?Q?F/oVrdB5Gmw6FpU4gQcNabdafog1BV8tf0i1C+5sJlmar6CvJbCzO7BtFSDt?=
 =?us-ascii?Q?+k3ZkisQQPw3P45aOf3ip5C4T+ES1oKvZwmUxFFEb3Fv/qK0dYTK8oX1Rjcy?=
 =?us-ascii?Q?mP8rNRwWp081W0jBGyLS1ZCa0lAGeCurNCueKIwZhd4FOyDd93fhH646MDeS?=
 =?us-ascii?Q?2IAQlXud6o5n4HE9NEnz0PU36cR7yKU75Xp6luEpTdlJfQHAbUoioQBL0f7+?=
 =?us-ascii?Q?h89AFyxcyueX7YnrTbht7CfJJiOnwP3LrVlQKrzDr9H6y5UzXoyIh0eR/PGu?=
 =?us-ascii?Q?aF8A5ImJnPY8v0cHIqDWcCyJc0ScH3CJngsp4GXs6TE3ecHx+2dar/YERWqp?=
 =?us-ascii?Q?EkFlSVKgXvhxVfl/cS6rlICLRT1Xg6FLLfcMkzGTo4E3ERD1u6Ql87e7RNI1?=
 =?us-ascii?Q?M2TgVbvnO9hESukyyQX4qKAFJYx3KCu0QAyCJ9FgEmpbkZ/yt8vVUZ4Kw+LD?=
 =?us-ascii?Q?KmBtDoWklYresrD4bG0kit67PqF0XIAkXWJOUkbE3YkM+/LQMaMvGF2XxYA+?=
 =?us-ascii?Q?39/Gk8NOgMolYP43E1HRGEE+wNRyOrXPnMcGNrCQYKX8/PoOW/RWmQdqTPFy?=
 =?us-ascii?Q?q7O3PxgCUFvNTsUp3QyJ7l08erqXlUkrz4Dl4o4F8ji8qh0BXwM/+6Z1XGJn?=
 =?us-ascii?Q?MmmrnrlYSI95wvGXs/n3gOu5q+rks363y6DQ0J3g/fHyKwDpZLoKBJTnyLbV?=
 =?us-ascii?Q?gOrZyq1c0a+J6qsLIBlk+LMeNasMwGrJVlFddup99eqniM4DBLXHYBVUt5iL?=
 =?us-ascii?Q?4lId56hlhntY9wvmKr5fKb3aqMwqKrJzOvgbFyqEWDtwTPjU41Gc+RJfpeS1?=
 =?us-ascii?Q?Tahi4FsX+S+bKpyWzeO6ij/QO2SxEzuFvV0NU5U/ASJlPjeiveWNIf6DJjzq?=
 =?us-ascii?Q?TBY1DZFCBRyQ6jYBz2eiphopxWzecjcO5k8sowKiCJs/SXiwkCINopEFCLKd?=
 =?us-ascii?Q?ax13SoFmxIXyyQvA5VopZa9FvE2iORn8t5tEUqxEpf0uq+w1CD6I0BYwqdZw?=
 =?us-ascii?Q?yqWxZGfxWv38+5cZdEWTn3/iHL6CA8Xnyl6egxUkzulsnftzkVxTi4Ub6Wgg?=
 =?us-ascii?Q?MXwQt6n6Y1gVwmbpohD8HCSP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR18MB1071.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 088ecead-4f1b-4679-192f-08d98950ed6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 05:11:32.1680
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yVlRzBQSOKHfN0ichBzAutIhY4FToDARoSYgMINRIFuv8Fuk8MP3qKJEQJGgTur6ethshARtowkBznQ9/Ih4sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2171
X-Proofpoint-ORIG-GUID: JePxWXRPE-678r0S6kyJAF8PXrm9sScL
X-Proofpoint-GUID: JePxWXRPE-678r0S6kyJAF8PXrm9sScL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-10-06_04,2021-10-06_01,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tim,


> -----Original Message-----
> From: Tim Gardner <tim.gardner@canonical.com>
> Sent: Wednesday, October 6, 2021 7:33 PM
> To: Ariel Elior <aelior@marvell.com>
> Cc: tim.gardner@canonical.com; GR-everest-linux-l2 <GR-everest-linux-
> l2@marvell.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>; Shai Malin <smalin@marvell.com>; Omkar Kulkarni
> <okulkarni@marvell.com>; Prabhakar Kushwaha <pkushwaha@marvell.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXT] [PATCH][next][RFC] qed: Initialize debug string array
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Coverity complains of an uninitialized variable.
>=20
> CID 120847 (#1 of 1): Uninitialized scalar variable (UNINIT)
> 3. uninit_use_in_call: Using uninitialized value *sw_platform_str when ca=
lling
> qed_dump_str_param. [show details]
> 1344        offset +=3D qed_dump_str_param(dump_buf + offset,
> 1345                                     dump, "sw-platform", sw_platform=
_str);
>=20
> Fix this by initializing the string array with '\0'.
>=20
> Fixes: 6c95dd8f0aa1d ("qed: Update debug related changes")
>=20
> Cc: Ariel Elior <aelior@marvell.com>
> Cc: GR-everest-linux-l2@marvell.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Shai Malin <smalin@marvell.com>
> Cc: Omkar Kulkarni <okulkarni@marvell.com>
> Cc: Prabhakar Kushwaha <pkushwaha@marvell.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org (open list)
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>=20
> I'm not sure what the value of sw_platform_str should be, but this patch =
is
> clearly a bandaid and not a proper solution.
>=20
> ---
>  drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> index 6d693ee380f1..a393b786c5dc 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> @@ -1319,6 +1319,8 @@ static u32 qed_dump_common_global_params(struct
> qed_hwfn *p_hwfn,
>  	u32 offset =3D 0;
>  	u8 num_params;
>=20
> +	sw_platform_str[0] =3D '\0';
> +

Thanks for pointing out.   It is leftover code which I missed to remove.

Proper solution will be below.   Please let me know if you are planning to =
send this fix else I will post.=20

diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethe=
rnet/qlogic/qed/qed_debug.c
index 6d693ee380f1..f6198b9a1b02 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
@@ -1315,7 +1315,6 @@ static u32 qed_dump_common_global_params(struct qed_h=
wfn *p_hwfn,
                                         u8 num_specific_global_params)
 {
        struct dbg_tools_data *dev_data =3D &p_hwfn->dbg_info;
-       char sw_platform_str[MAX_SW_PLTAFORM_STR_SIZE];
        u32 offset =3D 0;
        u8 num_params;

@@ -1341,8 +1340,6 @@ static u32 qed_dump_common_global_params(struct qed_h=
wfn *p_hwfn,
                                     dump,
                                     "platform",
                                     s_hw_type_defs[dev_data->hw_type].name=
);
-       offset +=3D qed_dump_str_param(dump_buf + offset,
-                                    dump, "sw-platform", sw_platform_str);
        offset +=3D qed_dump_num_param(dump_buf + offset,
                                     dump, "pci-func", p_hwfn->abs_pf_id);
        offset +=3D qed_dump_num_param(dump_buf + offset,

--pk