Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1126916pxb; Thu, 7 Oct 2021 01:03:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGlDY9nPSEpu1wCpE85aU1N04lADkq+T9IQgSppYKIiO1dCQUE8oBmNy4I3j5WtqCeTe9G X-Received: by 2002:a05:6402:27d0:: with SMTP id c16mr824753ede.167.1633593802279; Thu, 07 Oct 2021 01:03:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633593802; cv=none; d=google.com; s=arc-20160816; b=j0RNTe8RsbRkjE+W34B+ES0vrREP/1Gl/oxtyJC7XMEjSULDFgHAZtxIvp0cxYr7VX 5wDA3DAZ854YiLqKqCrkWsh0Qw7xcxWqZ0vuYLRLUOZOuUJ3uxyBYrDqtba9nSUmYDJy z1ecwWeyebVL1IEv3PZ/1kmlMtRLwg8EtD3sziNiBXp2UxClBwatmtNYxXOfEhjAwTPo ImDrR++ICCHc3skKNR2+u0nRrMR0cB966E5WSvl/SNPIhnljwn47tSbHRNcHPNetg47z RyFhNV8AFS/TSaU9nM262adnUm7TgVR8llh8MoqZAvw+TwAhFT9ytJh7+22NgyX3K2ec bdpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lwzPc8fH+7dgXHJ3vsdx2PCBkitrpMX+x9W9SGxRwsY=; b=jbT2Ssio3+P1+T0g/mQYYCkCDnVwZ71QiKX/1VSgKJtepknpzZVr33AFwvF/U6JVO+ k8qIUnDOjvC31Kx5xG9QsPqc9IIxFu2sFBpHspyMLN7qSmUSZTeFaQH57zcRxvjaejx6 xU8h+uZKWTFr61JviceOk/dUWoDi/uUdop2ShMUgjQWozOLJVCaHwFIDlfDV7oFHu7R+ ms6LMfekqZTuT47ByFiqbjQFRNlDeRV0k8hlmwmmvG7pDbjEypLHBgpHVF+fDCC4RKy8 V3ndcvAHqaYkRpMgMvFWTF7B9U8Bgsfb6CGel0H5T4/ZGkdfhLA7XIO8n/IRTRms6coD p4yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EAJNopuY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 28si24431833ejb.46.2021.10.07.01.02.58; Thu, 07 Oct 2021 01:03:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EAJNopuY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240334AbhJGH64 (ORCPT + 99 others); Thu, 7 Oct 2021 03:58:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:55146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240316AbhJGH64 (ORCPT ); Thu, 7 Oct 2021 03:58:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C04B861029; Thu, 7 Oct 2021 07:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633593422; bh=EUlwA4dsoXeeKLviFdk42tbmlamxNeb1B3c2EGU0Mhs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EAJNopuYrLItO+XEKtnfkTRAloz9GOXNkovZYuxxQabEa8YAYliAqHwCee8rFCsjr a9jjfvvhR9Cr8xKNHpl5jgN4fboQQVr6vixK8vDYFuiSUtjADqhLELfCKuGFhoXnXF ZCeOOM4bbbT1AS6CKoikB/VauRkmgvfBoZX6tYiYfOX7Ss9pm4M6HGFu6vcNnwAsO5 jOjDd6f6EnRn9fCLfzu19zKAkcDmxC7eimmIhOgOT8QnBMTL2OIdq2qVPl4s869GWa ngLfz/hS75alb8EE4YrzHeEWzcUby44PvfORD62JajwVv19gWeaZRMsJ/AJPRVH4uZ 3Y8vjGKgBsK/Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1mYOGz-0006jn-Gv; Thu, 07 Oct 2021 09:57:01 +0200 Date: Thu, 7 Oct 2021 09:57:01 +0200 From: Johan Hovold To: Yu-Tung Chang Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] USB: serial: option: add Quectel EC200S-CN module support Message-ID: References: <20210930021112.330396-1-mtwget@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 09:47:28AM +0200, Johan Hovold wrote: > On Thu, Sep 30, 2021 at 10:11:12AM +0800, Yu-Tung Chang wrote: > > Add usb product id of the Quectel EC200S-CN module. > > > > usb-devices output for 0x6002: > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 3 Spd=480 MxCh= 0 > > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > > P: Vendor=2c7c ProdID=6002 Rev=03.18 > > S: Manufacturer=Android > > S: Product=Android > > S: SerialNumber=0000 > > C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > > I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether > > I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether > > I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > Looks good now, but for completeness, could you also mention here what > the three ports are used for (and which is which)? I've applied the patch now, so no need to resend, but please list the three ports in a reply if you have that information. Johan