Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anup Patel <anup.patel@wdc.com>
To:     Palmer Dabbelt <palmer@dabbelt.com>,
        Palmer Dabbelt <palmerdabbelt@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Atish Patra <atish.patra@wdc.com>,
        Alistair Francis <Alistair.Francis@wdc.com>,
        Anup Patel <anup@brainfault.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, Anup Patel <anup.patel@wdc.com>,
        Bin Meng <bmeng.cn@gmail.com>
Subject: [RFC PATCH v4 01/10] RISC-V: Clear SIP bit only when using SBI IPI operations
Date:   Thu,  7 Oct 2021 18:06:23 +0530
Message-Id: <20211007123632.697666-2-anup.patel@wdc.com>
In-Reply-To: <20211007123632.697666-1-anup.patel@wdc.com>
References: <20211007123632.697666-1-anup.patel@wdc.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
WDCIPOUTBOUND: EOP-TRUE
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H4vEs1vHAdsqbDbNmIE10FfodvmN6wnQfUY/5vWH6/gvZE6XeKq/xhrtWUhd?=
 =?us-ascii?Q?tNy8xDAPCHHhu0Uw2eDU4j2dKisB9E0aFUET8TdSPw/qnpql/fBH0yjoZFGr?=
 =?us-ascii?Q?+aBdDpUgS8LsLzp5v+7V7bXjqqXkHOiH6IFODG8l7DKLdOZiNwZqD2NoG8h2?=
 =?us-ascii?Q?F2/q4UchvYbNKkUMokkVJqHqXap+FyA6lJX+vhqlWhc73+7FeDToJlOZegyA?=
 =?us-ascii?Q?qofT3ilc3oPupoRRDhxBb5Vpyp0ItBkwqgblW88zRtvScyFmUGEuTQjsWiqK?=
 =?us-ascii?Q?UId3QH5C2zHlkvBJPYmoPa+jnhuPpkbXNpTTmdsZEsPHq99U7GL7bRtXyVFy?=
 =?us-ascii?Q?bRRZd0UjuyK+nLde9Ymh0LL2KODPmK7QZvXYqo8FcdIossISDQxgacxWMBJD?=
 =?us-ascii?Q?bLyIhqTS8eNCVVd7hO9rDJA+QMQF1Q4QSOpXHPHgYk3SWLx2rLuQ84ZvPBEs?=
 =?us-ascii?Q?0HGMd8s8bHI4Chxqokg0IlQWVV8P/X6cLHwv2huPkEwJxjXXAgvjrWTOI5pB?=
 =?us-ascii?Q?KS7ZITfSqfbwOKU+J7Sp2VSVOTpcOY+/O6QmNiQub55d80oGbrSh/pCKh9wB?=
 =?us-ascii?Q?IdwCeYmXPHKD0gW+i+zJVlrYetvlhRnkkREAJygEC5ue0Hi88uZVG7Ls6i/g?=
 =?us-ascii?Q?DAaGr5lTDzlXUIAz21O/5l84aUN+3Y/LiIsDzyUYemvrEQ3qG1BUqpr9K8rF?=
 =?us-ascii?Q?TCpvRPPen88LYJC1JDTvnBnHsXEhP03HVPHn1PAh3M9Zn8EP7byTOvUU8Mix?=
 =?us-ascii?Q?RJGX6MgSXoXnWGg7dov39k7/yDIQN0NJBl0F0RlBnf5Bhzz/w2W6s5jwj9R8?=
 =?us-ascii?Q?iYyT6seawpbunwjMybaT9f7stix+58ax8qn4uVcXd0iM4tZ0rV0brL5+4hbZ?=
 =?us-ascii?Q?AK6ptAtzOVyEBghPucAimrTtIXJh27PUskvkSlMtUF/FEAerBzdEe+zLYdES?=
 =?us-ascii?Q?yE3EBFD9Grxzmqi8XczaQLHOOP5MWfqILt7ALYImXbgOw1ZqHmtFd05rP7LU?=
 =?us-ascii?Q?GIJmD4eEFyI7m/rXih6nkEkWzuR/YamhZ61QEn+1HWnO0NBim8nogg/iznIR?=
 =?us-ascii?Q?9vKvewmUpM2Y3/HdMb4fXQNuxeQYTc6GsOXLf8XYlVQqWYfMcMi6P8lYbXj3?=
 =?us-ascii?Q?twsq3osz/O2PpjMbrD8j78c68sv5nhUoUehIVW+s5z9JeKAH48gFZP3W6MsA?=
 =?us-ascii?Q?lL8MeLb+o8Pp8iU5aLw5nnh1w7W0HKTuLVPBKXcrD69FKVjVF3wZjhj9Hl5k?=
 =?us-ascii?Q?RydWQZg93X/k6YEoIHq9iEzgalZcwRAdAJwoC3BYifF5MDrCmTCA3uPhKEV2?=
 =?us-ascii?Q?Xfrg4hKz89jtmUNkLQayB/rY?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c8631b-0f8b-4d89-dbeb-08d9898f29b8
X-MS-Exchange-CrossTenant-AuthSource: CO6PR04MB7812.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 12:37:02.6151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jo2ww4Jii8fnv9opaSckht2FYeApsTJYQK+fxyk21Ig8XABGgVZiLpEWWjwMmO6STcxyIoA3TUzuU/UbJW+trg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7777
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The software interrupt pending (i.e. [M|S]SIP) bit is writeable for
S-mode but read-only for M-mode so we clear this bit only when using
SBI IPI operations.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
 arch/riscv/kernel/sbi.c | 8 +++++++-
 arch/riscv/kernel/smp.c | 2 --
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c
index 9a84f0cb5175..8aeca26198f2 100644
--- a/arch/riscv/kernel/sbi.c
+++ b/arch/riscv/kernel/sbi.c
@@ -598,8 +598,14 @@ static void sbi_send_cpumask_ipi(const struct cpumask *target)
 	sbi_send_ipi(cpumask_bits(&hartid_mask));
 }
 
+static void sbi_ipi_clear(void)
+{
+	csr_clear(CSR_IP, IE_SIE);
+}
+
 static const struct riscv_ipi_ops sbi_ipi_ops = {
-	.ipi_inject = sbi_send_cpumask_ipi
+	.ipi_inject = sbi_send_cpumask_ipi,
+	.ipi_clear = sbi_ipi_clear
 };
 
 void __init sbi_init(void)
diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
index 921d9d7df400..547dc508f7d1 100644
--- a/arch/riscv/kernel/smp.c
+++ b/arch/riscv/kernel/smp.c
@@ -99,8 +99,6 @@ void riscv_clear_ipi(void)
 {
 	if (ipi_ops && ipi_ops->ipi_clear)
 		ipi_ops->ipi_clear();
-
-	csr_clear(CSR_IP, IE_SIE);
 }
 EXPORT_SYMBOL_GPL(riscv_clear_ipi);
 
-- 
2.25.1