Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1386425pxb; Thu, 7 Oct 2021 06:50:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxj4UJmh/aXvgx4Rj5yx1t5g00FO2lYJb9IQcdvSb+GQMS1uPaFVbmq3gZ8QzRbdnGI4lvd X-Received: by 2002:a05:6402:222b:: with SMTP id cr11mr6705678edb.392.1633614659228; Thu, 07 Oct 2021 06:50:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633614659; cv=none; d=google.com; s=arc-20160816; b=DHV3ecOq1u6q4nJYyOgD3DfBTi9g9kG+R9Xv20xYQtm6CMezdA0zePeHcKtVV5Q9Tt yLcRoox971RgFlT3lQ7vLB9wjCchseYMhdYoHHcXrJE54ithCha7hmnBJm/mLg/Yuktl PipvLTe27dividJ/yx3j6Zxh65kSjTTKWTagCKV33ef2VoOgHtaKIu3i7DxVxWZbpcyx tMwVrPVALgKDlmEURz+ZSexloRWWMfmevNoICHDdvuMK4lGlAmGfo4BHronIR1Qbe3kj mPIGHM9pBYk1wRiVOOoQnOjGXCKyk+FCi3W4llVbSi++15LsxBwmRCk75+eWGhdqftm6 /RLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=EAk5Jso51OddNDeEl5EcrBJh2SiEeX6lkk/PTXOrl9c=; b=qJxeTbtMOFop3JJQRf2ZCZbxUTnY4xIGdruRf97XubiTMlwvLxcWKSvr/UWKijzm0E GSWRKS7an06d5c17l5DjJ7Q4grc0oCS/PLefbxWBCzxEyA2+8mqaDYuhCD6mQEI+CaE3 wt6xkLJsRJbkRzL3VPXDGjvGudAPG/zOTDu2HwhlKvQT4TlgO1aMPqTzrhN5cHRPCRSj prCFzYL+f4Gl5Aww+8XQHPPIoTNSntr47KpluYnF8LKdMOQ9Elc63qUUxGXO3VcSOaB5 ODl9U/MbuWQTn52Ez8yYUyqAPi+FNc2BVbwqseJ2F6HZtMVL188wU0fvnE6d6v7Ml/3b iAUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b18si33244711ejh.638.2021.10.07.06.50.34; Thu, 07 Oct 2021 06:50:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241758AbhJGNuw (ORCPT + 99 others); Thu, 7 Oct 2021 09:50:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:19008 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241536AbhJGNuv (ORCPT ); Thu, 7 Oct 2021 09:50:51 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="249571043" X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="249571043" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 06:48:57 -0700 X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="488997557" Received: from likanto-mobl.amr.corp.intel.com (HELO [10.209.99.172]) ([10.209.99.172]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 06:48:57 -0700 Subject: Re: [PATCH v2 4/4] virt: Add sev_secret module to expose confidential computing secrets To: Dov Murik , linux-efi@vger.kernel.org Cc: Borislav Petkov , Ashish Kalra , Brijesh Singh , Tom Lendacky , Ard Biesheuvel , James Morris , "Serge E. Hallyn" , Andi Kleen , Greg KH , Andrew Scull , "Dr. David Alan Gilbert" , James Bottomley , Tobin Feldman-Fitzthum , Jim Cadden , Daniele Buono , linux-coco@lists.linux.dev, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211007061838.1381129-1-dovmurik@linux.ibm.com> <20211007061838.1381129-5-dovmurik@linux.ibm.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <290c21a8-a68f-0826-2754-1480f79a081d@intel.com> Date: Thu, 7 Oct 2021 06:48:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211007061838.1381129-5-dovmurik@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/21 11:18 PM, Dov Murik wrote: > +static void wipe_memory(void *addr, size_t size) > +{ > + memzero_explicit(addr, size); > + clean_cache_range(addr, size); > +} What's the purpose of the clean_cache_range()? It's backed in a CLWB instruction on x86 which seems like an odd choice. I guess the point is that the memzero_explicit() will overwrite the contents, but might have dirty lines in the cache. The CLWB will ensure that the lines are actually written back to memory, clearing the secret out of memory. Without the CLWB, the secret might live in memory until the dirtied cachelines are written back. Could you document this, please? It would also be nice to include some of this motivation in the patch that exports clean_cache_range() in the first place. I also think clean_cache_range() an odd choice. If it were me, I probably would have just used the already-exported clflush_cache_range(). The practical difference between writing back and flushing the cachelines is basically zero. The lines will never be reused. *If* we export anything from x86 code, I think it should be something which is specific to the task at hand, like arch_invalidate_pmem() is. Also, when you are modifying x86 code, including exports, it would be nice to include (all of) the x86 maintainers. The relevant ones for this series would probably be: X86 ARCHITECTURE (32-BIT AND 64-BIT) M: Thomas Gleixner M: Ingo Molnar M: Borislav Petkov M: x86@kernel.org X86 MM M: Dave Hansen M: Andy Lutomirski M: Peter Zijlstra There's also the handy dandy scripts/get_maintainer.pl to help.