Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 09:23:58 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     "Robin H. Johnson" <robbat2@gentoo.org>,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        rjohnson@digitalocean.com,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 1/2] tracing: show size of requested buffer
Message-ID: <20211007092358.65152792@gandalf.local.home>
In-Reply-To: <20211007071151.GL174703@worktop.programming.kicks-ass.net>
References: <20210831043723.13481-1-robbat2@gentoo.org>
        <20210907212426.73ed81d1@rorschach.local.home>
        <20211007071151.GL174703@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 7 Oct 2021 09:11:51 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> > > +++ b/kernel/trace/trace_event_perf.c
> > > @@ -400,7 +400,8 @@ void *perf_trace_buf_alloc(int size, struct pt_regs **regs, int *rctxp)
> > >  	BUILD_BUG_ON(PERF_MAX_TRACE_SIZE % sizeof(unsigned long));
> > >  
> > >  	if (WARN_ONCE(size > PERF_MAX_TRACE_SIZE,
> > > -		      "perf buffer not large enough"))
> > > +		      "perf buffer not large enough, wanted %d, have %d",
> > > +		      size, PERF_MAX_TRACE_SIZE))  
> 
> Priting a constant seems daft.. why is any of this important in any way?

I see your point, but it can be useful if you changed it, and want to know
if you are running the kernel with the change or not.

I've done daft things were I changed a const and was running a kernel
without the change and couldn't understand why it wasn't working ;-)

-- Steve