Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 16:35:41 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Namjae Jeon <linkinjeon@kernel.org>
Cc:     Colin King <colin.king@canonical.com>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Steve French <sfrench@samba.org>,
        Hyunchul Lee <hyc.lee@gmail.com>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] cifsd: Fix a less than zero comparison with the
 unsigned int nbytes
Message-ID: <20211007133541.GC2048@kadam>
References: <20211007114716.13123-1-colin.king@canonical.com>
 <CAKYAXd_aOawm4MkBtkTxnLfeEk+F5VgrJHjyH8GSaeHjQbLtGQ@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKYAXd_aOawm4MkBtkTxnLfeEk+F5VgrJHjyH8GSaeHjQbLtGQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Rn6ENOzSqO6MLUshQDcj29iXzuRmHjt8Fs+DUWG/IreqWz5x+ypWg2ZtuCI?=
 =?us-ascii?Q?pufCCx9BUGRFjg+io+Pin9UZ8pBMWd8D7hIZzeNqYn7bD0cOieKHVyTcRXeC?=
 =?us-ascii?Q?I6YjRfby+s942zzPC3NgKY0gBFwdITwAXLcYr5e5gEJUyPcOcsvVc7z2eb+6?=
 =?us-ascii?Q?Ven1uFoCpee3EYxlTgLMeZc3wnz9VThaJIvO1qSpx8hwoHJuw5CcNXSNG2AD?=
 =?us-ascii?Q?HV1MZIPI7opbOKVBMSP6QSwkp26GmE5B4FWm6GkLtSsOlPLJBueFHqEotTLJ?=
 =?us-ascii?Q?MlDyqF9xXreE5mnGscnBxvImnTJb2kkfqz8ZKZPqwlwhSQXADWXFHK37pxIJ?=
 =?us-ascii?Q?yFyIv2zXgvBUwcEuz7IfNRN/wS87wmmNHJMKH+Nl9+D9O6mABoR0GI3CJ+2K?=
 =?us-ascii?Q?WEBXgpXYaI5ldtmUCJ6iDI7FTT8fSx4ujnl4YM7LKKNTqxN9hptnP5I06HzU?=
 =?us-ascii?Q?SwABK7qmsuW7TqPaI20/umbIQ7sx6GE3FCt1OWwX5i3RNQFCDRxAWnLDsN72?=
 =?us-ascii?Q?Yc/TWHcUkDHG1J9kEZi/mmoczUMfVohw1V0H0OBCZDHv/c21B9PgwgirrQH1?=
 =?us-ascii?Q?z01XIEIMQwBlQrpmFTZJV8lZ0gPfrCAFBZVtUYVefeZg0xXI4gjt4nX4Welp?=
 =?us-ascii?Q?W4bT7CRIi1p/xN9Gjzx7clS8vSu/uLnunsbTQcIlp6wJPRTFw/7H35AYhUOx?=
 =?us-ascii?Q?jg2/saMmZF7eMd3Gt9uRCTM59F7wX7Lsq8cPSKk051ebbL1EE75TjOe6eYDk?=
 =?us-ascii?Q?MMFv+Wo4cnoy1z42ePpS1Qn6q04v9hwujtACcy2uABVKy46PkvobXuD8gXdV?=
 =?us-ascii?Q?65BkNL5zlMQgC0xPcD379v/q1WJvSd4hn8fUPntTV4MmfwQQ6Rl+H3S8aZFh?=
 =?us-ascii?Q?ugI+KUmQM3War85hIm9tSeY50MPZwDNE8ZpJUXOA3CvKxS0FUhCYU2dFYx+K?=
 =?us-ascii?Q?dZCez2a2XkbW20rI3wTgPixfCX4wto0EJHTQ7DTqSS+VwL27LYzmi7PZHNAM?=
 =?us-ascii?Q?EmR5KFf5cbMArm2Ei8q+c8I1vcUW77yl9ZxtDU2KTvXlbioaX29i/yItVmNC?=
 =?us-ascii?Q?Rt6+/AiJ9eGdwvcbXOQO6W6agf+lqBEceqQOyfz3TP6cIXAHMaO0wpnXTsus?=
 =?us-ascii?Q?gxCxm8xAofpANw1Neht4JfFKiISzEtnwQ5xuKo6TxDHOBfvtNfY68+ciC1Ib?=
 =?us-ascii?Q?bAMWIds0hSeTa3sSURcurwrjlNJIrOvPs43m7eer5Y65tOf7z2WslPvQVvcq?=
 =?us-ascii?Q?QNYJNrQGfY7tuuOkNPrJEGVtXtjzpQzCSOWCD/9sXG8g6qc6RbwUo339C192?=
 =?us-ascii?Q?jMQC68N/aT8ljhaWLvpcF/vR?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6bd9ac87-fb07-4e6f-6af5-08d989976642
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 13:36:00.5177
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GJVMzSACVa97nNc5BjFQY0To/PpMxpVcuWx/6P3SDA7+ti/cHHD/d672Q5xNTk9X+V6eHhkx39P3oJh8nVO3d2uNhStDKf0hPhtpHkImPb8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1488
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10129 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=925 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110070092
X-Proofpoint-GUID: hSGvKxeEwL8gzODw2yTm5-GHe-kpgSFK
X-Proofpoint-ORIG-GUID: hSGvKxeEwL8gzODw2yTm5-GHe-kpgSFK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 07, 2021 at 09:37:04PM +0900, Namjae Jeon wrote:
> 2021-10-07 20:47 GMT+09:00, Colin King <colin.king@canonical.com>:
> >
> > Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> I think that this alarm is caused by 	b66732021c64 (ksmbd: add
> validation in smb2_ioctl).
> Fixes tag may be not needed. Because b66732021c64 patch is not applied
> to Linus' tree yet ?

If you are going to modify the commit to include this fix then that's
fine.  Otherise if you are going to apply this commit then the Fixes
tag is still required.

The fixes tag saves time for backporters because they can automatically
rule out that this patch needs to be backported.  Or if they backport
commit b66732021c64 then they know they have to backport the fix as
well.

Also the Fixes tag is used for other purposes besides backporting.
It helps review.  It's also an interesting metric to measure how long
between the bug is introduced and the fix is applied.

regards,
dan carpenter