Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 15:25:18 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Trevor Woerner <twoerner@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        Javier Martinez Canillas <javierm@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>, Chen-Yu Tsai <wens@csie.org>,
        Peter Robinson <pbrobinson@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] rk3399-nanopi4.dtsi: enable sdmmc regulator on boot
Message-ID: <YV8DTqA/6XI9KZmK@sirena.org.uk>
References: <20211006160817.13808-1-twoerner@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/deUtXPj4/UYU6Qr"
Content-Disposition: inline
In-Reply-To: <20211006160817.13808-1-twoerner@gmail.com>
Precedence: bulk


--/deUtXPj4/UYU6Qr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 06, 2021 at 12:08:17PM -0400, Trevor Woerner wrote:
> @@ -71,6 +71,7 @@ vcc3v0_sd: vcc3v0-sd {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&sdmmc0_pwr_h>;
>  		regulator-always-on;
> +		regulator-boot-on;

This shouldn't be required for devices that can read their status, the
fact that it's always on should cause it to be powered up if it wasn't
already when applying constraints.  I'm therefore confused as to what
this change is doing and there's probably something else going on here.

--/deUtXPj4/UYU6Qr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFfA04ACgkQJNaLcl1U
h9CKsgf8DQCEbECuQKPWS9ndwd61Y16UyarKnvFC4c5PxqpvK+JlBp3FNej5teoE
NbuCbz/NwF3yjH89C7T17S4WLOLZHdO4xF2jv0RWqnXwaJcUyxsVI4ObRynR0uSM
kwIE1eLF1DiFS49Qzf3ixMDRf4/zvCay886DBmrPlr2qbG0Wzo0+TwWidtfnFNQq
0Ft+Jw41rLh0WXaAszI1py3/e00QGoDbZbskfXJ5Bhxy6Qi9gaA5vs2l3F/5D9wg
skwZFR04rsBn5DHeRUzn8iPlMheoHivYXPTrOtu9HE13VCqsVemmPbessKehwmv5
si1hms2u9hOiplV/pzRcNX5GIpqWbw==
=nFkn
-----END PGP SIGNATURE-----

--/deUtXPj4/UYU6Qr--