Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kees Cook <keescook@chromium.org>
To:     linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Cc:     Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] lkdtm: avoid printk() in recursive_loop()
Date:   Thu,  7 Oct 2021 09:59:27 -0700
Message-Id: <163362596339.2313433.1892710945535449841.b4-ty@chromium.org>
In-Reply-To: <20211007081235.382697-1-ardb@kernel.org>
References: <20211007081235.382697-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 7 Oct 2021 10:12:35 +0200, Ard Biesheuvel wrote:
> The recursive_loop() function is intended as a diagnostic to ensure that
> exhausting the stack is caught and mitigated. Currently, it uses
> pr_info() to ensure that the function has side effects that the compiler
> cannot simply optimize away, so that the stack footprint does not get
> reduced inadvertently.
> 
> The typical mitigation for stack overflow is to kill the task, and this
> overflow may occur inside the call to pr_info(), which means it could be
> holding the console lock when this happens. This means that the console
> lock is never going to be released again, preventing the diagnostic
> prints related to the stack overflow handling from being visible on the
> console.
> 
> [...]

Applied to for-next/lkdtm, thanks!

[1/1] lkdtm: avoid printk() in recursive_loop()
      https://git.kernel.org/kees/c/700fa7d22233

-- 
Kees Cook