Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 13:41:03 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Yafang Shao <laoar.shao@gmail.com>
Cc:     pmladek@suse.com, keescook@chromium.org, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, peterz@infradead.org,
        valentin.schneider@arm.com, mathieu.desnoyers@efficios.com,
        qiang.zhang@windriver.com, robdclark@chromium.org,
        christian@brauner.io, dietmar.eggemann@arm.com, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] kernel/kthread: show a warning if kthread's comm
 is truncated
Message-ID: <20211007134103.4da8a8ab@gandalf.local.home>
In-Reply-To: <20211007120752.5195-5-laoar.shao@gmail.com>
References: <20211007120752.5195-1-laoar.shao@gmail.com>
        <20211007120752.5195-5-laoar.shao@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  7 Oct 2021 12:07:52 +0000
Yafang Shao <laoar.shao@gmail.com> wrote:

> -		vsnprintf(name, sizeof(name), namefmt, args);
> +		len = vsnprintf(name, sizeof(name), namefmt, args);
> +		if (len >= TASK_COMM_LEN) {
> +			pr_warn("truncated kthread comm:%s, pid:%d by %d characters\n",
> +				name, task->pid, len - TASK_COMM_LEN + 1);

Instead of saying how many characters it is truncated to, what about just
showing what it was truncated to?

			pr_warn("truncated kthread comm from:%s to:%.*s for pid:%d\n",
				name, TASK_COMM_LEN - 1, name, task->pid);

?

-- Steve

> +		}