Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <caa830de-ea66-267d-bafa-369a6175251e@nvidia.com>
Date:   Thu, 7 Oct 2021 12:02:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH v10 3/3] mm: add anonymous vma name refcounting
Content-Language: en-US
To:     Suren Baghdasaryan <surenb@google.com>,
        Kees Cook <keescook@chromium.org>
Cc:     Michal Hocko <mhocko@suse.com>, Pavel Machek <pavel@ucw.cz>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Colin Cross <ccross@google.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Randy Dunlap <rdunlap@infradead.org>,
        Kalesh Singh <kaleshsingh@google.com>,
        Peter Xu <peterx@redhat.com>, rppt@kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        vincenzo.frascino@arm.com,
        =?UTF-8?B?Q2hpbndlbiBDaGFuZyAo5by16Yym5paHKQ==?= 
        <chinwen.chang@mediatek.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Jann Horn <jannh@google.com>, apopple@nvidia.com,
        Yu Zhao <yuzhao@google.com>, Will Deacon <will@kernel.org>,
        fenghua.yu@intel.com, thunder.leizhen@huawei.com,
        Hugh Dickins <hughd@google.com>, feng.tang@intel.com,
        Jason Gunthorpe <jgg@ziepe.ca>, Roman Gushchin <guro@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>, krisman@collabora.com,
        Chris Hyser <chris.hyser@oracle.com>,
        Peter Collingbourne <pcc@google.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Jens Axboe <axboe@kernel.dk>, legion@kernel.org,
        Rolf Eike Beer <eb@emlix.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Thomas Cedeno <thomascedeno@google.com>, sashal@kernel.org,
        cxfcosmos@gmail.com, LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-mm <linux-mm@kvack.org>,
        kernel-team <kernel-team@android.com>
References: <20211006175821.GA1941@duo.ucw.cz>
 <CAJuCfpGuuXOpdYbt3AsNn+WNbavwuEsDfRMYunh+gajp6hOMAg@mail.gmail.com>
 <YV6rksRHr2iSWR3S@dhcp22.suse.cz>
 <92cbfe3b-f3d1-a8e1-7eb9-bab735e782f6@rasmusvillemoes.dk>
 <20211007101527.GA26288@duo.ucw.cz>
 <CAJuCfpGp0D9p3KhOWhcxMO1wEbo-J_b2Anc-oNwdycx4NTRqoA@mail.gmail.com>
 <YV8jB+kwU95hLqTq@dhcp22.suse.cz>
 <CAJuCfpG-Nza3YnpzvHaS_i1mHds3nJ+PV22xTAfgwvj+42WQNA@mail.gmail.com>
 <YV8u4B8Y9AP9xZIJ@dhcp22.suse.cz>
 <CAJuCfpHAG_C5vE-Xkkrm2kynTFF-Jd06tQoCWehHATL0W2mY_g@mail.gmail.com>
 <202110071111.DF87B4EE3@keescook>
 <CAJuCfpFT7qcLM0ygjbzgCj1ScPDkZvv0hcvHkc40s9wgoTov7A@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <CAJuCfpFT7qcLM0ygjbzgCj1ScPDkZvv0hcvHkc40s9wgoTov7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUd4bHU0Z1lDTmRzSVdmT1BEaXZkMlQyaWJKRVU1eDJtY3c3V2VpS2JwS0lP?=
 =?utf-8?B?N3U2cnFEeHBoeUgyOGJoaGNiQkVZdEcyOFE5WDhGL0hHNWRPTGFEQXVQcWFl?=
 =?utf-8?B?MC9DVERiOHY1d1BXMVY3N0VSYkpiQWNreHA1dlRBcGRVU3VKNEpQV3k0TWZG?=
 =?utf-8?B?bnhMNjlweTF4SmVUM1R3ZHd5RU5PeTVmM3pJRWVLRVNRbXliZ0Ntdk9CVHNm?=
 =?utf-8?B?T2F6SkVXaFozNTN0eThra1h2aTY0UDMvdi9QSFBiYUtFVi9PYjdCejh3UThG?=
 =?utf-8?B?Q1pDM2F1TGhRVGJlOGp4UEtpV0FZaGVoL0JTNEhUOXd5S0tuc3E3QjROa0NV?=
 =?utf-8?B?Wm1Qb0R5THlzenFkSGJrUnFYRjNIWDBJTGhYQ2NYRVdUVnZFNkhyLzlRUGlt?=
 =?utf-8?B?NzJlTEk5RllmbmtBSnFsNWpkTFZIMThoNk41NnR5N0NPcFZsM1JRcDJwUWN6?=
 =?utf-8?B?MGhieFBmWFlQUjlHczhNWDZzMFR1SVRmT2N3VWN4OEFBckJJRVhYMlpHdy9U?=
 =?utf-8?B?SGxGK3ZtT2R5d2J5enV5czNlUStXczhxVDZGMjhGaXlpOENFK1drL2tHZ3Fk?=
 =?utf-8?B?NTRBS2xIcUQ2Kzd3RExib3lvbG9jNUEweHkzMVFhNnlYRm92VGZrVlpSU09n?=
 =?utf-8?B?THM2aWt0OTJra0h6ck9aYzVXMG5DMDRIZGNwWC9EdFVCQ3hpZXpydklnb2Ru?=
 =?utf-8?B?aGdua3JreEQ1RkZLbnQycUQ1Q01PZURuSklQNjA2Snp2MzlEL045aXRGR0Yx?=
 =?utf-8?B?VDFURU9iWUtMNHNYeUhSM1dFYWVWd2krQitqYm5xWFFkV0x5VTRZcU5Ocmhw?=
 =?utf-8?B?czdQdVdtNjZLMDBidFZsdE5Wc3U2YjBhRCt1Y1FuNHA0M3hpK0pBVnMzVUZk?=
 =?utf-8?B?Y3pQRTVWbE92NGtFUCtGa3JYWXl3MzY4YnZGNUsySERIY1kwQnNDc2hVcU83?=
 =?utf-8?B?UWc2Mm53NG9KSi9iVjJEbG81SmV3Y1pUcXRObUZaMld2VUJacDBiU0pnTHhs?=
 =?utf-8?B?QUdFQTRBdHJuZ29nTUxpQitGNngwWmpWSjZsTXhVWlE4cXhaTHZkWmpIMVBW?=
 =?utf-8?B?S1QwYmttQWxuOFpjcmtOSk5yRGxPb1pIMTJSbkpLSWhhTVNwT2ZpY1daZ0Na?=
 =?utf-8?B?SWJFWUx6bUxXenM5L3dMUWRYUjlReVEwYVNvU1c3QmIvTnZXN2x5ZzRwbEYw?=
 =?utf-8?B?Q3hqMm03MEtGUEVoMm4vMEdWKy9jMkZOR0hEd1NtbWFwejJMcml0bklaYmVx?=
 =?utf-8?B?UFpSbHpmY3hZYURLSlI2R2ltY2hKUzlZazA0djJOdlBFTnVTWjBJZXphUURG?=
 =?utf-8?B?cXBjQlAwU0RUU091eVh2VmI1cTJvd2R0MzFxRkZRWWVhRUhkQlROYWxHUGdj?=
 =?utf-8?B?TFM4UllYZmxTZ2tCdzJ1SnNwNjVzWkRWbXE5Z3ErbjZybllRR25pNnVCR29J?=
 =?utf-8?B?NHUrMExwZmt2WTkzWlJsdHhMUG5acU9uZnZzeTdOK0s1N0ZkVXFtT1JLOE84?=
 =?utf-8?B?dFFXVEx6SGhIK1V5OGFSeTBCK0MvNC9UVXk4c2lJZXM3RWtIMmtteXN4eFNS?=
 =?utf-8?B?QjV0aFlydkxsaUcyTEkzTjc4eVdQQlNRdGNBbXhrcmIzRWM4UzFkdXpiaXYv?=
 =?utf-8?B?dzViWlFLc2NuV0I1NmhrSjFSOWU5d1U4S2lRbm52TDBLWXY5ZVp1dWJtcXJn?=
 =?utf-8?B?Q01zNDMvSk4reVhFR0VUNEtnQXVITW41eGhoN09IWGxmM1BPMDFOdnkweGJX?=
 =?utf-8?Q?5FbkI6/nW7IzSKLWtNos9wSHblqV8J9bQs/iLD3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77d2aa4a-8d08-46bb-91e0-08d989c514b5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 19:03:00.3032
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eCZlXTJRNJy5myyayzIL3KsF0bdIIAI1YBHRo4OboSbi5iVk69kners7pjEyUbv8S5f/lqOMctEJCSYKTWx9sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2789
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/7/21 11:50, Suren Baghdasaryan wrote:
...
>>>>>>>>>> I believe Pavel meant something as simple as
>>>>>>>>>> $ YOUR_FILE=$YOUR_IDS_DIR/my_string_name
>>>>>>>>>> $ touch $YOUR_FILE
>>>>>>>>>> $ stat -c %i $YOUR_FILE
>>>>>>>
>>>>>>> Ah, ok, now I understand the proposal. Thanks for the clarification!
>>>>>>> So, this would use filesystem as a directory for inode->name mappings.
>>>>>>> One rough edge for me is that the consumer would still need to parse
>>>>>>> /proc/$pid/maps and convert [anon:inode] into [anon:name] instead of
>>>>>>> just dumping the content for the user. Would it be acceptable if we
>>>>>>> require the ID provided by prctl() to always be a valid inode and
>>>>>>> show_map_vma() would do the inode-to-filename conversion when
>>>>>>> generating maps/smaps files? I know that inode->dentry is not
>>>>>>> one-to-one mapping but we can simply output the first dentry name.
>>>>>>> WDYT?
>>>>>>
>>>>>> No. You do not want to dictate any particular way of the mapping. The
>>>>>> above is just one way to do that without developing any actual mapping
>>>>>> yourself. You just use a filesystem for that. Kernel doesn't and
>>>>>> shouldn't understand the meaning of those numbers. It has no business in
>>>>>> that.
>>>>>>
>>>>>> In a way this would be pushing policy into the kernel.
>>>>>
>>>>> I can see your point. Any other ideas on how to prevent tools from
>>>>> doing this id-to-name conversion themselves?
>>>>
>>>> I really fail to understand why you really want to prevent them from that.
>>>> Really, the whole thing is just a cookie that kernel maintains for memory
>>>> mappings so that two parties can understand what the meaning of that
>>>> mapping is from a higher level. They both have to agree on the naming
>>>> but the kernel shouldn't dictate any specific convention because the
>>>> kernel _doesn't_ _care_. These things are not really anything actionable
>>>> for the kernel. It is just a metadata.
>>>
>>> The desire is for one of these two parties to be a human who can get
>>> the data and use it as is without additional conversions.
>>> /proc/$pid/maps could report FD numbers instead of pathnames, which
>>> could be converted to pathnames in userspace. However we do not do
>>> that because pathnames are more convenient for humans to identify a
>>> specific resource. Same logic applies here IMHO.
>>
>> Yes, please. It really seems like the folks that are interested in this
>> feature want strings. (I certainly do.) For those not interested in the
>> feature, it sounds like a CONFIG to keep it away would be sufficient.
>> Can we just move forward with that?
> 
> Would love to if others are ok with this.
> 

If this doesn't get accepted, then another way forward would to continue
the ideas above to their logical conclusion, and create a new file system:
vma-fs.  Like debug-fs and other special file systems, similar policy and
motivation. Also protected by a CONFIG option.

Actually this seems at least as natural as the procfs approach, especially
given the nature of these strings, which feel more like dir+file names, than
simple strings.

thanks,
-- 
John Hubbard
NVIDIA