Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 Oct 2021 09:04:04 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Richard Palethorpe <rpalethorpe@suse.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Stefano Garzarella <sgarzare@redhat.com>,
        Andra Paraschiv <andraprs@amazon.com>,
        Eric Dumazet <edumazet@google.com>,
        Arseny Krasnov <arseny.krasnov@kaspersky.com>,
        Willem de Bruijn <willemb@google.com>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Richard Palethorpe <rpalethorpe@richiejp.com>
Subject: Re: [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout
Message-ID: <20211007090404.20e555d4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211007123147.5780-2-rpalethorpe@suse.com>
References: <20211007123147.5780-1-rpalethorpe@suse.com>
        <20211007123147.5780-2-rpalethorpe@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu,  7 Oct 2021 13:31:47 +0100 Richard Palethorpe wrote:
> Reuse the timeval compat code from core/sock to handle 32-bit and
> 64-bit timeval structures. Also introduce a new socket option define
> to allow using y2038 safe timeval under 32-bit.
> 
> The existing behavior of sock_set_timeout and vsock's timeout setter
> differ when the time value is out of bounds. vsocks current behavior
> is retained at the expense of not being able to share the full
> implementation.
> 
> This allows the LTP test vsock01 to pass under 32-bit compat mode.
> 
> Fixes: fe0c72f3db11 ("socket: move compat timeout handling into sock.c")
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Cc: Richard Palethorpe <rpalethorpe@richiejp.com>

This breaks 32bit x86 build:

ERROR: modpost: "__divdi3" [net/vmw_vsock/vsock.ko] undefined!

If the 64 bit division is intention you need to use an appropriate
helper.