Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1679307pxb; Thu, 7 Oct 2021 12:42:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmaI27NOtIdUSiJO/jH7uTRqUpuCKjuTSeU154b/g750mQozY0Pr4sokz4fmDcfbCURDjI X-Received: by 2002:a63:cf44:: with SMTP id b4mr1194254pgj.215.1633635778451; Thu, 07 Oct 2021 12:42:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633635778; cv=none; d=google.com; s=arc-20160816; b=EAUDnJYfgL3QnRi65BpkPhC2bN7/5UUWDEIOg1bf6+S3dX2ptSdKu/WUYL+KHOpJTh ygIxgIvsNs57VIEFXrxTzpaYV8u37nCe+V7qobDllrWPamp4kxqM8P7PeTi2audaFrOF /MOupcnlwwUxK72CTnPg66pDhy26aO1/w53PHu/DqjPM37Yo0jBh4rUNAbVTvMizC2wH r1mzD8GEynlj3eDWRwudPosZrq5O0Ar48ZzaREgX6VdOaVz9SRJdN/W9NjJnAteKC8HC dyxgpR5wr0SN63SaOHtwv7JWpD93Ypv+gvM+Ld7DGCi1KE6XaAe07DfjJ5fM4v9Qqtz7 n8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=OUCBD97CnwJKQ5Ti6IwsRQrEJquye2mQsFEV2aJ36VU=; b=HLvvODjGT7bcav7/2mTiGkZFbjnI8ymSUOED7KJ0OURUgGnYvpzzNUj62nH+c3pNKM A4N4r4XNtIKwms/QHA9es2LXMJzhr0VdaFlnaxfgXiShC1ApPhI89bDIfwra99tmIp4Q 76Yb2HKLuvyy6/bNc2UQJ2pm6n3asqsExnz82u7s7fsaoXSleMRd1M/6SkD4i39sZw64 ZyPexBi5Rifj2toaXsudkP6ELWDBHQz3FfJ4heiQWjiFM73caYG77D7njFHKjoEDp/h6 yt5E75TsQSBltEdUVD++MIbGe01FvNwPNORX0oBwhEefPJftemuBxR8EgVyTDNCK+TBB DsSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si364576pgj.102.2021.10.07.12.42.45; Thu, 07 Oct 2021 12:42:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242790AbhJGQ5x (ORCPT + 99 others); Thu, 7 Oct 2021 12:57:53 -0400 Received: from mga11.intel.com ([192.55.52.93]:2718 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232229AbhJGQ5w (ORCPT ); Thu, 7 Oct 2021 12:57:52 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="223707542" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="223707542" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 09:55:12 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="560636328" Received: from sunghwan-mobl2.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.255.230.203]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 09:55:11 -0700 Subject: Re: [PATCH v8 05/11] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Josh Poimboeuf , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005025205.1784480-6-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <07d043d9-4ab9-564f-2702-2a2348939d33@linux.intel.com> Date: Thu, 7 Oct 2021 09:55:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/21 2:33 AM, Borislav Petkov wrote: > Why do you need to clear this when, if used, it will get completely > overwritten in __tdx_hypercall()? Yes. we don't need to clear it. I can remove the initialization in next version. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer