Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for
 PMC controller
To:     Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Sachi King <nakato@nakato.io>, hdegoede@redhat.com,
        mgross@linux.intel.com, rafael@kernel.org, lenb@kernel.org,
        Sanket.Goswami@amd.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, stable@vger.kernel.org
References: <20211002041840.2058647-1-nakato@nakato.io>
 <3ecd9046-ad0c-9c9a-9b09-bbab2f94b9f2@amd.com>
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
Message-ID: <909f28e9-245a-df90-52f1-98b0f63a2b3a@amd.com>
Date:   Thu, 7 Oct 2021 15:00:23 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <3ecd9046-ad0c-9c9a-9b09-bbab2f94b9f2@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHBVZFNHaURyY0dTMUxtVzdST01Kdi9Ra1RvY3VYb0J0WTF6emhOMjBtcjdN?=
 =?utf-8?B?QlNIYnJndTRZb0lUenNuc3NJYm9xaDRlMFhDcGxFRlBEbVNMbEREaXhrZnYr?=
 =?utf-8?B?d0d6Z3NDMW4ySjdxWHhXMGV4SHhWaDJnYk9zSTlyQ2xjM2RDNW5RM1RNLzJZ?=
 =?utf-8?B?K0JTSmdBNklHb3FWUSswWEdtTXlUeEp5emg4eHVhL3F4WjJpOVEzNXVnUkdU?=
 =?utf-8?B?SmxPZXpIOXZ2U21hUDdueXhhWlNsNWhQYTUwVGwxT0xCYWkwS0M4dndqUlkv?=
 =?utf-8?B?OW9RbklGZk9pMXMxeGVjQW5qUEJwcm5WQmcwVWlnV2k3eTNMendmOHhqMVZp?=
 =?utf-8?B?NUdWR0g3T0RNdmFoQk8zZy9DL2kxUi9ncWxCcG44WUNQcW5lU3RTdlNWcFZ3?=
 =?utf-8?B?ZXYvVlQ4bE90UWNJT0lqMjZtWGsyR1dLUHJEQU5uUzZac1MxbHBVd0s5VWtV?=
 =?utf-8?B?eWRucUpyaUM2Wnk5VXh2QXVCNjBIWGdmdGRKaFdmNmtweUlOc2ltNE9SUUU5?=
 =?utf-8?B?SXAwTjVOVnR0UC9QQ1VUMXNwVTRsM3Z3WXhKdDRyTjNPempxYVVOaG5DWGJw?=
 =?utf-8?B?U2JJWmlraFlqN2lLQ3ZCRFMxVHp0bkx6dkFpTm15TVNrVTRwWm9SdWUrb3lC?=
 =?utf-8?B?cVlpQmFRQXNxVkVlYlg4RjY5bFAzVEdRMGN0K0lSUDI2V05TSE1tUk1SNDRS?=
 =?utf-8?B?U1BFVGE2VmI2R2NlMjlHSGJUOTFrQ3N4SzAyQUZiaXg3dG01YWlSN2lsZVJw?=
 =?utf-8?B?ZGJPU2MxTmxEZTV5R29pR0xvL1pLQU55MWVKUGIzdjQ1SWhyRGZUSUNCRGh5?=
 =?utf-8?B?b0h5cDFtMVVzTlY3UUd0aTEyZXlXMVVxdHhsTW1zalAwQVViaGxQcFVPRGNK?=
 =?utf-8?B?L1FmYi9FZ3k4WWdpVmMyS0xySHFwVGhrak54S0ZkUnpnbXNEdC85T1M1WGJ1?=
 =?utf-8?B?aEtreTRpcHRYTW4wMVpOWVhTa3R2Y2U5cUUycTFjZmNVYitydlNXOGorbjRS?=
 =?utf-8?B?a1VXSXcyMlNJbFNKT3ppQTZVR2MzdWVXQ3hEYmREdVJEV1EzenFqazlBRlZP?=
 =?utf-8?B?TmNuVE8xTHJkVHo3NGpSMWMrYldGZ0RuMVoydStYRXdFZlpIUG8rYXBJaC91?=
 =?utf-8?B?RjlQVUljTXQybFBIN1hxcW5SN29yK2dRZk1Ta3ltMTFNRDFuL3FSSGRZa2JC?=
 =?utf-8?B?UkZacENVNGNSeEVNUkJ0Ni9EdVZGK0duV2l6WmQ0bkxVa0M2czZsKzdRbzMr?=
 =?utf-8?B?T3hIQm5KL1g3WUUzOTNweFR1cDZRalBkRkd5dHh2Y2pBUEllY2szV1NQTE84?=
 =?utf-8?B?YXBrL0V3dUYzelNxSjRkUTJLOWFScW9MaXNPZTdkWUpGVS9pSEJKblBXVWFl?=
 =?utf-8?B?d01lQjNuLzZDdHFvWFExbFBHVysrbndNQUNRV1RZbkxIVXdXMWpkY24zNkxn?=
 =?utf-8?B?RzlOQkp4QlhvcmNNdmFTNUcxTFRqMkk5L01lZTU5c1FER3lhK05hdlZ6M3RR?=
 =?utf-8?B?R0MrUXdPb1FZRHM4VjhuQWtCWDE5V1poaU84WTRZM0UvVTB1U2lNc3dWRFhm?=
 =?utf-8?B?Y1AyZWNwdGxESjJWemZrVW9kVlZuS0pEcFUxLzZxTHZ0Q3FYVkpTb2JFSTVs?=
 =?utf-8?B?MHhiMmlOWkQ5c2dEaXQ2L2k2RGpmY0lHbDJ1UkMzYnNYRWhDNVZjSnViRjdH?=
 =?utf-8?B?TlNxY3VoWFhGMTlDWG1RVkViekRUU3dFeFI1ZkgrRm5zUFpLL3FZTVZFMmdj?=
 =?utf-8?Q?nChszAaWdqqtrNqcbybGzGCn3tKf19QjLI64qvm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dde907fa-d25d-4bc5-2495-08d989cd19f0
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4510.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 20:00:24.7230
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 45Ie1cTe6Al+v3SMksMy20uGhmADYQHcVfN/bTsl8Cw8QIFr8exS+fQhEfWVWQ7BwbHC3lIn2vv3BunI2QEEuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4670
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+Sanket Goswami

On 10/5/2021 00:16, Shyam Sundar S K wrote:
> 
> 
> On 10/2/2021 9:48 AM, Sachi King wrote:
>> The Surface Laptop 4 AMD has used the AMD0005 to identify this
>> controller instead of using the appropriate ACPI ID AMDI0005.  Include
>> AMD0005 in the acpi id list.
> 
> Can you provide an ACPI dump and output of 'cat /sys/power/mem_sleep'
> 
> Thanks,
> Shyam
> 

I had a look through the acpidump listed there and it seems like the PEP
device is filled with a lot of NO-OP type of code.  This means the LPS0 
patch really isn't "needed", but still may be a good idea to include for 
completeness in case there ends up being a design based upon this that 
does need it.

As for this one (the amd-pmc patch) how are things working with it? 
Have you checked power consumption and verified that the amd_pmc debugfs 
statistics are increasing?  Is the system able to resume from s2idle?

Does pinctrl-amd load on this system?  It seems to me that the power 
button GPIO doesn't get used like normally on "regular" UEFI based AMD 
systems.  I do see MSHW0040 so this is probably supported by 
surfacepro3-button and that will probably service all the important events.