Date: Wed, 20 Dec 2006 22:10:32 -0800
From: Andrew Morton <akpm@osdl.org>
To: David Brownell <david-b@pacbell.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
       Andrew Victor <andrew@sanpeople.com>,
       Bill Gatliff <bgat@billgatliff.com>,
       Haavard Skinnemoen <hskinnemoen@atmel.com>, jamey.hicks@hp.com,
       Kevin Hilman <khilman@mvista.com>, Nicolas Pitre <nico@cam.org>,
       Russell King <rmk@arm.linux.org.uk>, Tony Lindgren <tony@atomide.com>,
       pHilipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers
Message-Id: <20061220221032.2f30dd72.akpm@osdl.org>
In-Reply-To: <200612201311.20517.david-b@pacbell.net>
References: <200611111541.34699.david-b@pacbell.net>
	<200612201304.03912.david-b@pacbell.net>
	<200612201311.20517.david-b@pacbell.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 778
Lines: 27

On Wed, 20 Dec 2006 13:11:19 -0800
David Brownell <david-b@pacbell.net> wrote:

> +static inline int gpio_get_value(unsigned gpio)
> +	{ return at91_get_gpio_value(gpio); }
> +
> +static inline void gpio_set_value(unsigned gpio, int value)
> +	{ (void) at91_set_gpio_value(gpio, value); }

whaa?  Where'd we pull that coding style from?

Please,

static inline int gpio_get_value(unsigned gpio)
{
	return at91_get_gpio_value(gpio);
}

static inline void gpio_set_value(unsigned gpio, int value)
{
	at91_set_gpio_value(gpio, value);
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/