Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V4 3/8] fork: add option to not clone or dup files
Date:   Thu,  7 Oct 2021 16:44:43 -0500
Message-Id: <20211007214448.6282-4-michael.christie@oracle.com>
In-Reply-To: <20211007214448.6282-1-michael.christie@oracle.com>
References: <20211007214448.6282-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zzDVP3yaQYMCzEerk+Ec5ClrUW1KkwrUBALIaTCF89ptV8e1XFbiGOfH3730?=
 =?us-ascii?Q?EzedjMeetRHwh6gtdFN73Oksu1PewVOdPbmwfbJAVWAQB0L5EUOHclGzT2Er?=
 =?us-ascii?Q?rmR5j3RWp4bNDNsofY61DG5jxQP7z3niY7SY2rGzCjNy0ObRslR/f8fK82z8?=
 =?us-ascii?Q?iYw+GgjgHxegf/7saoqq5izkwRcojRtFdNNgGhAxDQavqqlwg/xiAUVZ4PSi?=
 =?us-ascii?Q?Z8V99XDcTmTcQhMV0BYkhOQwtvhIX6gLD14h2YurnZ8fk2canJ/NVkY51Smi?=
 =?us-ascii?Q?w5bvH4bmA8uzlJ5IDOHeoTHsq4NQe3pBYE5s+fopL6oglKAC0okOYo6lNvMH?=
 =?us-ascii?Q?R/on2WNDa73fXZ/BZrdnq3WxLNV0rVW2iMBRHcrR1OzWA0wRrk6XVlKKPetr?=
 =?us-ascii?Q?Hn/S7NUg0AKuCLF2kJkg/x47bcGa6btLTvhC/SGSM69mVcZ1pFMKs77K8gMf?=
 =?us-ascii?Q?XyQFnc0VvqPactmhJGkuB6oQbqnpSnT7ioi52JTfvxPG2StVnKbNSnRWSuuQ?=
 =?us-ascii?Q?Ondfw1cqrGBZbeLxdPqhT7UEsnevkmvG7wDcOVLWZ7+Z3Q7PapFfHDDQ4HSs?=
 =?us-ascii?Q?KOgSTutHKSkUhKK8BBC93mHjzE6iwds9bvG2FhI6bvKchpUor4wbKObdJEfH?=
 =?us-ascii?Q?8OEWvAGj16vB/NI4KQo/UD3TtWPslw4+lFoXK9AdWs0ekl7HmwtE323FfYFl?=
 =?us-ascii?Q?PVrKH2BTfev4M83Kpmf8wYUJ8PtqR/KZWDUUpnrBil17GuOc9WC34jIlq+hb?=
 =?us-ascii?Q?PV1IJEkNzd+uDyG1Hh5vxJRBkRoPD+NqezUR3c1FxKiYM3XQ5hc0moHM0S7d?=
 =?us-ascii?Q?bYszfnVQDaH9cqFU+RWsiM171cOKq3J1xw0eeen8cnXChVlIHBg252+3WPne?=
 =?us-ascii?Q?hvWfM9tJ2QLPFkz0uVZEp0zzA3ZpTWLwmQ8HrY11MswqUnS0an102m0cyc75?=
 =?us-ascii?Q?XYVwqQ42bHHjft5j+ziDRmFDIsGXVV8WR7ZbrLvd0CY69boUuAZx47KQIxMx?=
 =?us-ascii?Q?fNyfkkufAfeP3QPfmGGFY7ktbeJRr4WSiIu1sZAl8Y6FjYvzklhYdwEI7sdD?=
 =?us-ascii?Q?KTViY1qcjAYHJfcJaaQ9AW9AKT3U8v9M8dKtriJ2uafiGml4n1CNvoCfxgK3?=
 =?us-ascii?Q?TEqlSXZVLNfVmIQwUKSb0+GBsHkbi4pYDgXxxUVZEpHp+mM8jJW8nzg483ox?=
 =?us-ascii?Q?tHGm97kCY3fnAIbaT++tZJQ8k16MfLQLx+Cxkt+dCGHZED+msgML7V2dzafH?=
 =?us-ascii?Q?uG3/vrs7JJfJCTUJnM0XmhN4ejPCp8Mbwwc7TjSIq2BSngaxHRYchnVq4LuP?=
 =?us-ascii?Q?VyW2U35dwNRPT1gF1RzeKroZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7adc6f7f-6e20-45e2-e539-08d989dbb4fe
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2021 21:44:57.8402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vXJInPcSgisKB0qFY3EIZMY5piwXiI/AnjtQxUxzxn7ft3+zaUiVMXEY2xFyrPNtYOYlgziCIYZ3CUZiM8/MpOT9C9f2XkogYzTCJVadtp0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1612
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10130 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110070137
X-Proofpoint-ORIG-GUID: PZwFDXX6WNj-4oXd_7JX4gLQ_BFpWRSI
X-Proofpoint-GUID: PZwFDXX6WNj-4oXd_7JX4gLQ_BFpWRSI
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it calls the kernel_worker() function added in
the next patch we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 53599a99d7e0..1153f9e5d10e 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define KERN_WORKER_IO		BIT(0)
 #define KERN_WORKER_USER	BIT(1)
+#define KERN_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 4f780424de46..3161edac1236 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1532,7 +1532,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1544,6 +1545,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2181,7 +2187,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & KERN_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1