Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1853008pxb; Thu, 7 Oct 2021 17:01:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKvfnHu2TwIUCDy5EoIqPa69MQ/3ZDR4m1UY5woLJSVvVqZC2XU2y758njU8KtSEh3My2n X-Received: by 2002:a50:cf4d:: with SMTP id d13mr10381961edk.50.1633651314498; Thu, 07 Oct 2021 17:01:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633651314; cv=none; d=google.com; s=arc-20160816; b=dPW45CMfM2VwaWlal7XIZjAygdNifp1XomZMlDDvkW1n9pc9De9O1VgvewMUTehspH eG93eqjsrkOV+KMWUMT0K2utRAFwkhUCQS5dCRnRoq+Cvt4uVudGeI4PleT7cRJ7t1HV d7kZAYhneZdiKXyxyilc7VLLYvCgXCJhR9tl3MnriC7xian6pWrq2d5P4uJwPGj1KhYR mqs05p1MVq7n5neACj8d7Va4dTSlIBVt+IkWNdcCwlqpTT6deV77t7VEgARgjWS0u7Vp pwqxkLWit7modgCX3wX4YSSoAGzNmmp5r10e7zmLeFn+MIqxBUby8yigZxoypbyuBc7I i5kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=VAQjz1YqhkKZ05uzGLYvHGiMAPj9o0JZRIYakSHMIIk=; b=ReD2YAvx2CBgNXExXBrubVhNIHH8s4TmwT3ZG+mEoyrLBjM7toNDrkmO9TfqzqAnpa LUOgZq3VBqvqIb7R5P4airWnUsvN7urNOz/eOeH9pcmCNhTP2kLEXEWu+kPzMOTlUZfn zGUEFIVOTzW0QGTQuxS10es2A3WgG2/pU91a4mGr/7Ym9Vkn98BsuA6TlbhCoudGD+gV Lix5fPAOlzrXSb9NY3BIEOOzCoUKQ8xe84GfzI+isHbYWC2lCfy6g5W1U7V2qFpeTDxV 8J8oRYa2E0GduVXLKpVtGUVvWIGdXS5hxfZK5MQwtZ7min42jRKLu8DPj77SgVNRmw47 YwOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z26si1262804ejc.230.2021.10.07.17.01.29; Thu, 07 Oct 2021 17:01:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234235AbhJHABl (ORCPT + 99 others); Thu, 7 Oct 2021 20:01:41 -0400 Received: from mga17.intel.com ([192.55.52.151]:56368 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231335AbhJHABl (ORCPT ); Thu, 7 Oct 2021 20:01:41 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="207208490" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="207208490" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 16:59:46 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="440454471" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.209.19.60]) ([10.209.19.60]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 16:59:45 -0700 Message-ID: <4d7756e6-bcc6-2c9e-ef0e-911404aad381@linux.intel.com> Date: Thu, 7 Oct 2021 16:59:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH 00/21] perf metric: Fixes and allow modifiers Content-Language: en-US To: Ian Rogers , Jiri Olsa , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Kees Cook , Sami Tolvanen , Nick Desaulniers , Andrew Morton , Jacob Keller , Zhen Lei , ToastC , Joakim Zhang , Felix Fietkau , Jiapeng Chong , Song Liu , Fabian Hemmer , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , Sumanth Korikkar , Heiko Carstens , Changbin Du , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian References: <20211007165647.3514803-1-irogers@google.com> From: Andi Kleen In-Reply-To: <20211007165647.3514803-1-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/2021 9:56 AM, Ian Rogers wrote: > There are 4 main changes in this patch set: > - perf metric: Modify resolution and recursion check. > - perf parse-events: Add new "metric-id" term. > - perf metrics: Modify setup and deduplication > - perf metric: Allow modifiers on metrics. Patches look all good to me from a quick read Acked-by: Andi Kleen