Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sean Anderson <sean.anderson@seco.com>
Subject: Re: [RFC net-next PATCH 08/16] net: macb: Clean up macb_validate
To:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>
References: <20211004191527.1610759-1-sean.anderson@seco.com>
 <20211004191527.1610759-9-sean.anderson@seco.com>
 <b1401da6-5bab-2e4c-e667-aca0bbf013dc@microchip.com>
Message-ID: <b898bd53-baa8-2a25-74d2-de3b75f447e3@seco.com>
Date:   Thu, 7 Oct 2021 20:20:08 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <b1401da6-5bab-2e4c-e667-aca0bbf013dc@microchip.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?8AxYkmMAsK4S5YjNy/OwxInBAX1Gn9ax3XEcP9R62cCGwtG0survRDdZ?=
 =?Windows-1252?Q?Q1ZaRt3vutRa7+u39kldCRJstQe0xFtOcLs63Yq9VFNP1ssTFchSsLPb?=
 =?Windows-1252?Q?hHRou1lSpVwmIVImtXHQGEtNBqhcp7Flys1NLwXyNF3Wwz48dlVtQwWC?=
 =?Windows-1252?Q?Q/TIMRazxK9htujyg4AZajnQFI1EzGkZUxUn4MMX+KIUbEfcI6S9tafb?=
 =?Windows-1252?Q?OTvDXSEFWiLWdYtuG8zDTedmd47+EhCkzppt16nkzrBw1IRjV/Ib8/Ut?=
 =?Windows-1252?Q?f4FT2eLijMj1uQnKcypTJHyAUaqw47h6LTJlioecSrGgvtbRDFDmQrGA?=
 =?Windows-1252?Q?R6tshSxYdDd4nSQlxoQSt7WJmXG0/Jd1NZXaj7Eitm8JsyXXDTqZydbH?=
 =?Windows-1252?Q?oZQYrZNHurX1u56G0pF60mtNFRipENzNYXokNiKcojclD4Jdzdp45GGg?=
 =?Windows-1252?Q?uW00uWX/sWcvBKprOPDEi0KLP4+kM/YUYKNGgCodrSHXE3ZPZwTQUwrl?=
 =?Windows-1252?Q?xvTrElLlvP/4A32dIXLNxS05cY4+Vbq8TsNxD7VS4xEOyDkN1RHYpkvM?=
 =?Windows-1252?Q?KT7Jos2EerFrCdoKk4QVAWxqwNaKH5B7iJXzlpzEMTj/xp5n63Am7W5g?=
 =?Windows-1252?Q?FCyB95/NYubRwfwirw33r1iN4Ay+OcrZj6z/p8X/C/Rjx6xa1Pqcr0dI?=
 =?Windows-1252?Q?/3O8udXDbWT35gp8iG9i0GhQ8ZPZF9j5THk7M5x+y3zr0bnTzlurariG?=
 =?Windows-1252?Q?NgW0ymZvV/BHA2pFbwyUUtXeXaEkAGDDytRjOnV3TxLIJFwCsB7crlN5?=
 =?Windows-1252?Q?T8hzC/bCV7Oo5b9z6ojCBgseWGLs2s6Kwg9Lq3/07EfjFo5BZzUG5oAB?=
 =?Windows-1252?Q?4ZfqRgQ1jg0yTHClQFRbkFmgBKJxtQ3udZoVa86l55eIXOnbTqP+WR9j?=
 =?Windows-1252?Q?QfaTVULQ9zXoM+LmhHzujYkkSxpU/gcZEpuLR96+JfGTYMVO4IhXDdph?=
 =?Windows-1252?Q?Dd9uVh8yhhgirkd65+AMm/GRnrS1NzMPPkxapHCUNOpdz/ygoJjB7gR1?=
 =?Windows-1252?Q?xE4opTiXKoTmI62mR0FyKdt5ZwWJn6OWluYqHdqW5aq/es/POF+6dLfF?=
 =?Windows-1252?Q?5FrnSxUSgl5oIi2mnp+GwP+MxE8TR2AizwtJGf2xGxtcW45+ISnCekz+?=
 =?Windows-1252?Q?I5mJ+3NFeN/EGKyPj5X/QuzPLRLLGXkRsM5Zx/sI8kwqcgzBjF9DvQPL?=
 =?Windows-1252?Q?SYBGBnTwf8sBtdz3lU+RjQLqI670FP5o4utg8x2dvA8KO5v2rPK/oI3H?=
 =?Windows-1252?Q?YjCLkxKgZpGpJWq8oc5yTbkoiFXhmb4DLeakXOfF91MY9xKbDpqv2XXt?=
 =?Windows-1252?Q?QmqB927n4xGYGEAuWNSNogi3gQHPoRFLVdIW+wXUs1pR8Az/IkJWbvCa?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69f3e8e9-042a-4774-7df4-08d989f16617
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 00:20:14.3574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P2cHFNOSdwAzwL93HJqtIenmJyPmj8RUkTjy4+u6m9OMEep6xgUCFgUMKw0HLKbFNbYRpnjMtdumWfB5MNm16A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB4986
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Nicolas,

On 10/7/21 9:22 AM, Nicolas Ferre wrote:
> On 04/10/2021 at 21:15, Sean Anderson wrote:
>> While we're on the subject, could someone clarify the relationship
>> between the various speed capabilities? What's the difference between
>> MACB_CAPS_GIGABIT_MODE_AVAILABLE, MACB_CAPS_HIGH_SPEED, MACB_CAPS_PCS,
>> and macb_is_gem()? Would there ever be a GEM without GIGABIT_MODE?
>
> Yes. GEM is a new revision of the IP that is capable of doing Gigabit
> mode or not. sama7g5_emac_config is typically one of those doing only
> 10/100.

Thanks for pointing that out. But even that config still has
MACB_CAPS_GIGABIT_MODE_AVAILABLE. So presumably you can use it for
gigabit speed if you don't use MII-on-RGMII. I suppose that
sama7g5_emac_config is not a GEM?

>> HIGH_SPEED without PCS? Why doesn't SGMII care if we're a gem (I think
>> this one is a bug, because it cares later on)?
>
> MACB_CAPS_HIGH_SPEED and MACB_CAPS_PCS were added by
> e4e143e26ce8f5f57c60a994bdc63d0ddce3a823 ("net: macb: add support for
> high speed interface"). In this commit it is said that "This
> controller has separate MAC's and PCS'es for low and high speed
> paths." Maybe it's a hint.

Ah, so perhaps HIGH_SPEED only represents the capability for a
high-speed PCS. Which of course is a bit strange considering that we
check for both it, PCS, and GIGABIT_MODE when determining whether we can
do 10G.

--Sean