Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Suren Baghdasaryan <surenb@google.com>
CC:     John Hubbard <jhubbard@nvidia.com>,
        Kees Cook <keescook@chromium.org>,
        Michal Hocko <mhocko@suse.com>, Pavel Machek <pavel@ucw.cz>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Colin Cross <ccross@google.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Randy Dunlap <rdunlap@infradead.org>,
        Kalesh Singh <kaleshsingh@google.com>,
        Peter Xu <peterx@redhat.com>,
        "rppt@kernel.org" <rppt@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
        =?iso-2022-jp?B?Q2hpbndlbiBDaGFuZyAoGyRCRCU2U0o4GyhCKQ==?= 
        <chinwen.chang@mediatek.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Jann Horn <jannh@google.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>,
        Yu Zhao <yuzhao@google.com>, Will Deacon <will@kernel.org>,
        "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
        Hugh Dickins <hughd@google.com>,
        "feng.tang@intel.com" <feng.tang@intel.com>,
        Jason Gunthorpe <jgg@ziepe.ca>, Roman Gushchin <guro@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "krisman@collabora.com" <krisman@collabora.com>,
        Chris Hyser <chris.hyser@oracle.com>,
        Peter Collingbourne <pcc@google.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Jens Axboe <axboe@kernel.dk>,
        "legion@kernel.org" <legion@kernel.org>,
        Rolf Eike Beer <eb@emlix.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Thomas Cedeno <thomascedeno@google.com>,
        "sashal@kernel.org" <sashal@kernel.org>,
        "cxfcosmos@gmail.com" <cxfcosmos@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        linux-mm <linux-mm@kvack.org>,
        kernel-team <kernel-team@android.com>
Subject: Re: [PATCH v10 3/3] mm: add anonymous vma name refcounting
Thread-Topic: [PATCH v10 3/3] mm: add anonymous vma name refcounting
Thread-Index: AQHXtwbp0N5wJZFV1UW7KtzlcFc+IKvEw1yAgAAJKoCAAA2/gIAACwuAgACrhQCAABk7AIAAELiAgABdXwCAADFKgIAABaOAgADolQCAAAo3gIAAGJGAgABhbYCAAAozgIAABNsAgAAJRACAAAVeAIAABk4AgAAKY4CAAAORgIAAKa8AgAA7UoA=
Date:   Fri, 8 Oct 2021 01:04:32 +0000
Message-ID: <20211008010425.atn6kzho7xmnet4a@revolver>
References: <20211007101527.GA26288@duo.ucw.cz>
 <CAJuCfpGp0D9p3KhOWhcxMO1wEbo-J_b2Anc-oNwdycx4NTRqoA@mail.gmail.com>
 <YV8jB+kwU95hLqTq@dhcp22.suse.cz>
 <CAJuCfpG-Nza3YnpzvHaS_i1mHds3nJ+PV22xTAfgwvj+42WQNA@mail.gmail.com>
 <YV8u4B8Y9AP9xZIJ@dhcp22.suse.cz>
 <CAJuCfpHAG_C5vE-Xkkrm2kynTFF-Jd06tQoCWehHATL0W2mY_g@mail.gmail.com>
 <202110071111.DF87B4EE3@keescook>
 <CAJuCfpFT7qcLM0ygjbzgCj1ScPDkZvv0hcvHkc40s9wgoTov7A@mail.gmail.com>
 <caa830de-ea66-267d-bafa-369a6175251e@nvidia.com>
 <CAJuCfpHJmDeyTXdsO8T5tTLgcNT22b15hj41EBNCDXBAoCdpog@mail.gmail.com>
In-Reply-To: <CAJuCfpHJmDeyTXdsO8T5tTLgcNT22b15hj41EBNCDXBAoCdpog@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?WStQY2hVOHZqdzZKdGRVamZUZVA1aGJRdmsyQXJ4UERRdWhDakowRVR0?=
 =?iso-2022-jp?B?MUNFb0ZRSTczSFprSy81Ym9Cb2lPTTdMRFVDU1o2U3dGY2lDRy83Znhq?=
 =?iso-2022-jp?B?VDZaanowNzR4TlRzeDFTdFJoNmNhZmEyc0syWGhPQmZWbFVVVFFwWTZa?=
 =?iso-2022-jp?B?QWJEeVR0dFBTc1BaZGFObkFWYjVUT0U3dTB3SnF6eTZXdU9vMXMwbXor?=
 =?iso-2022-jp?B?T2JpeUd4VUg5OWlxRjFkdWZMdnA5ZnZ0MW5Wc01OMVcxcERrZ0dqN08w?=
 =?iso-2022-jp?B?czgwb3hPVTFEMmptekwxbWJBRy9PeXJOdEVqS3hZUG5XVGlxZEFFTjlw?=
 =?iso-2022-jp?B?RlU5b1diMUNJcVJkWU9vUWpnVzRCZGdraW5adjFRVWluc1NNSldPUHhj?=
 =?iso-2022-jp?B?U1MvRWNmcm8vWTJWNlJqZC9GeVorZ1JQYnJ6T3Mvb0RLQ0dncy83aUMr?=
 =?iso-2022-jp?B?cWVneHJRZ1RTVHNuem8ybEVvNVBJdHZQVHZLS1pUQTdNRmpybWZJZmpu?=
 =?iso-2022-jp?B?dUdickZCTVNjeEhUS0VEMnZJZUZWblJ3b3ZHUlBJN0hXbGM1N0Q1b2Fh?=
 =?iso-2022-jp?B?ei9PWDhzRnJwTGw0RHRsdHZaTXRqbllzSmVNOURDeEtjbTZ2bk5kdzBI?=
 =?iso-2022-jp?B?OXI5d250RGZqOTZsRUlzc2JrTHh1L1JUREgrOW90N2U2L3RMUTZSWGtB?=
 =?iso-2022-jp?B?OGcwREFZYkNKZWpiV2JjNDkzL3Q1ZjNzbTZIS2dKNlBlM09Da3VTaEpK?=
 =?iso-2022-jp?B?clpyRDh0NDJXWlA5V0tXOEZyZ2xxMlQrZUo2MXArbzROVWg1QmVxVUFh?=
 =?iso-2022-jp?B?S3JCelBFcnFNRVNUVWhRb0RuN2R0bXgwRlRrejNZbklZd29xeXk1M09X?=
 =?iso-2022-jp?B?T0MxRFRvaU91WEorVzRFd0JjMmZJNW1QNzBRajdhWDNYck9KaTJiRVZz?=
 =?iso-2022-jp?B?S0N0Qm03cDJWRFN2OVFaaFhIYmdhZ1BEVFVzU0ttdUQ2WkVVajNKUHBF?=
 =?iso-2022-jp?B?VmpyV3FNSlJuaTFjMGRIOGpxK1RMdkh5R1hqU1pzSjRUblVCbnZnUi9H?=
 =?iso-2022-jp?B?TEJIbHJBQzh0cW80QzU2S2JKOURHcFIwZnNrcGYzMlZDR3dwTTI5Wklm?=
 =?iso-2022-jp?B?MlVUQzhWR2V6cEpjWW1jVVJTT3hIamFmQS93VTdmUHYyU0NtaG5UYmUy?=
 =?iso-2022-jp?B?T1g5bm5tcVhqLzdBcGxOY3pNOGMyalZpR2tycjNGcTNUcFNEZnFPMytE?=
 =?iso-2022-jp?B?L0wwbkVzb1pyWWFJMFBxbU5XMTVUalE1Z2FuWW5TeFkyOHNvOTF1aEo1?=
 =?iso-2022-jp?B?ZHBJYnRnYVFyNXYvZXN3eDhSeTI5UytXSFV4ODRWL0ZBc0ZBbXZtcVJs?=
 =?iso-2022-jp?B?bUY1aXFNWkV6VGdhN24xS09tMjQybG4yWklzS0txbEM5SlBnaCtmR1dX?=
 =?iso-2022-jp?B?N3c3SzNtQlA3WTkzWjhLNHQ2NUphVEFlcjhGYWVFam8rMHRPczVkNEoz?=
 =?iso-2022-jp?B?WTVBaWNQSVQvRlY4cFpPb1FibS9YeGtKSlhxWmRVQURnRjIwaUswTmpp?=
 =?iso-2022-jp?B?S2RKT1VRWlFGYlhmcUtQNnRJd1hVNnQzWkdGVkZMQWRRSkR1VndXRDVC?=
 =?iso-2022-jp?B?NW5xSFZGMkVwZkxkckFVMEY2bmg1WVM1a3RFa3RWeElVN2pPV0RRNkNk?=
 =?iso-2022-jp?B?Uzl1RjhCSWthT0p6eFNobVcrSWUvSEdmblZYVDU3dUxFR2ZKU0ZOMUtZ?=
 =?iso-2022-jp?B?WVlBZk9xdnViVE9wZjk4RU8ydGVJMGlpTHdEWWFHQXRONHJmMVdzVjh3?=
 =?iso-2022-jp?B?M1ROZjdtdkp4K24yUEVtL3puYjdSRC8xQzg5bW5WZUtLdkN5WlY1eExi?=
 =?iso-2022-jp?B?TUp6bGpUNHN0K1dHdG5NYUZwamZOWFhvYVd0OTdVVG0zMHpLNzNiSkNz?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <BF2349D043B26643BEF827D711C635A2@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3018.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e86edbb2-8e9e-4ce5-21ff-08d989f79676
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 01:04:32.2468
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zt160D/rpk0EcvOoFacEpT+3/gCtQqGmpVq44Vw2PN5Dxc9Bee070BNrlFE/XhUEyGWiUSNDe5XowV4jOgw4gA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3980
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10130 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110080003
X-Proofpoint-GUID: noCwKXh9u9bNmqpXFFXvmBwWzmkhlTcF
X-Proofpoint-ORIG-GUID: noCwKXh9u9bNmqpXFFXvmBwWzmkhlTcF
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Suren Baghdasaryan <surenb@google.com> [211007 17:32]:
> On Thu, Oct 7, 2021 at 12:03 PM 'John Hubbard' via kernel-team
> <kernel-team@android.com> wrote:
> >
> > On 10/7/21 11:50, Suren Baghdasaryan wrote:
> > ...
> > >>>>>>>>>> I believe Pavel meant something as simple as
> > >>>>>>>>>> $ YOUR_FILE=3D$YOUR_IDS_DIR/my_string_name
> > >>>>>>>>>> $ touch $YOUR_FILE
> > >>>>>>>>>> $ stat -c %i $YOUR_FILE
> > >>>>>>>
> > >>>>>>> Ah, ok, now I understand the proposal. Thanks for the clarifica=
tion!
> > >>>>>>> So, this would use filesystem as a directory for inode->name ma=
ppings.
> > >>>>>>> One rough edge for me is that the consumer would still need to =
parse
> > >>>>>>> /proc/$pid/maps and convert [anon:inode] into [anon:name] inste=
ad of
> > >>>>>>> just dumping the content for the user. Would it be acceptable i=
f we
> > >>>>>>> require the ID provided by prctl() to always be a valid inode a=
nd
> > >>>>>>> show_map_vma() would do the inode-to-filename conversion when
> > >>>>>>> generating maps/smaps files? I know that inode->dentry is not
> > >>>>>>> one-to-one mapping but we can simply output the first dentry na=
me.
> > >>>>>>> WDYT?
> > >>>>>>
> > >>>>>> No. You do not want to dictate any particular way of the mapping=
. The
> > >>>>>> above is just one way to do that without developing any actual m=
apping
> > >>>>>> yourself. You just use a filesystem for that. Kernel doesn't and
> > >>>>>> shouldn't understand the meaning of those numbers. It has no bus=
iness in
> > >>>>>> that.
> > >>>>>>
> > >>>>>> In a way this would be pushing policy into the kernel.
> > >>>>>
> > >>>>> I can see your point. Any other ideas on how to prevent tools fro=
m
> > >>>>> doing this id-to-name conversion themselves?
> > >>>>
> > >>>> I really fail to understand why you really want to prevent them fr=
om that.
> > >>>> Really, the whole thing is just a cookie that kernel maintains for=
 memory
> > >>>> mappings so that two parties can understand what the meaning of th=
at
> > >>>> mapping is from a higher level. They both have to agree on the nam=
ing
> > >>>> but the kernel shouldn't dictate any specific convention because t=
he
> > >>>> kernel _doesn't_ _care_. These things are not really anything acti=
onable
> > >>>> for the kernel. It is just a metadata.
> > >>>
> > >>> The desire is for one of these two parties to be a human who can ge=
t
> > >>> the data and use it as is without additional conversions.
> > >>> /proc/$pid/maps could report FD numbers instead of pathnames, which
> > >>> could be converted to pathnames in userspace. However we do not do
> > >>> that because pathnames are more convenient for humans to identify a
> > >>> specific resource. Same logic applies here IMHO.
> > >>
> > >> Yes, please. It really seems like the folks that are interested in t=
his
> > >> feature want strings. (I certainly do.) For those not interested in =
the
> > >> feature, it sounds like a CONFIG to keep it away would be sufficient=
.
> > >> Can we just move forward with that?
> > >
> > > Would love to if others are ok with this.
> > >
> >
> > If this doesn't get accepted, then another way forward would to continu=
e
> > the ideas above to their logical conclusion, and create a new file syst=
em:
> > vma-fs.  Like debug-fs and other special file systems, similar policy a=
nd
> > motivation. Also protected by a CONFIG option.
>=20
> TBH, I would prefer to have the current simple solution protected with
> a CONFIG option.
>=20
> >
> > Actually this seems at least as natural as the procfs approach, especia=
lly
> > given the nature of these strings, which feel more like dir+file names,=
 than
> > simple strings.

I think the current locking around VMAs makes this a very tricky, if not
impossible, path.  Watching a proc file which takes the mmap_lock() is
painful enough.  Considering how hard it has been to have this feature
added, I cannot see locking changes being accepted as a more feasible
approach nor can I see increased mmap_lock() contention from any feature
being desired.

I like the CONFIG option.  The patches are in good shape and have a
clever way around the (unlikely?) scalability issue that existed.

Thanks,
Liam=