Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] btrfs: Remove redundant assignment of variable ret
To:     Colin King <colin.king@canonical.com>, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211007232716.30456-1-colin.king@canonical.com>
From:   Anand Jain <anand.jain@oracle.com>
Message-ID: <8f48a898-55e3-b539-9c4c-19714d827b2c@oracle.com>
Date:   Fri, 8 Oct 2021 08:35:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211007232716.30456-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE9XZVhVeFJsYUplV0NtQ0NPWWppa2lYUjhsVzRKUkttZWg2N1l6VFJQOWR3?=
 =?utf-8?B?SEFRVkdFOGFmUE1HTG9kdVhnNldLU25DWDFVN1pKUmhZRklkdVFaemZJWjk1?=
 =?utf-8?B?U3pyZ1I4aW90MTQ0RWxwT0lNMFVTejBPUGZ3TlhmYVJJUnB2ek0rTFZ0dDhi?=
 =?utf-8?B?aVR1ZWhad3FLUHp6ZEZBQ0JTTDhmV3k5eGlEU2RYT3ZFeEZLQkM2NmhlY1lU?=
 =?utf-8?B?b1dGQjlnZ1lyeEdpR2o2eUJFKzZ2dXozb0xGNXRidm8zVVAxblJucnZ0WG5s?=
 =?utf-8?B?aTl5a2tRamRZTVhFQTN3dFU1bkFWbURrMnRLemNpSmU4MkI3aUJDa1R2NnJW?=
 =?utf-8?B?TkVJQ1B1UnJrclMzKzJFaVYxMVg0RWh1Y00xYTVRMXlPaHNLb3kvS2Rhenhr?=
 =?utf-8?B?enJKWmxTLzQ5bTNLNW5sbmQwV2JPNkphVjlicmFJb1NHWXVuUHhlZmZjd0Jt?=
 =?utf-8?B?a3N5TXJpTnh6M08wVyt5T1BaZGdKdTVtbGszLzZKblk2TS9weXliTTQ1K1Nz?=
 =?utf-8?B?VXhKeDZSNitwcTVnMXdtVElrWS9yZTJZMmJaZnZkNzR2b0RTbm5GL1VKQ3Y3?=
 =?utf-8?B?YUYzODFUZ1lUTTNCVHB1UmcvcHBkTjk1bVRsMG9sSkFmTW5abWlnZEdVMFEy?=
 =?utf-8?B?SjI0MW0rVkdQOXAya05rSENCby9ha1pDbEZwbFVYelpDUVRic0NSWnVvd2lJ?=
 =?utf-8?B?OHVhY2FSbUkzM0xMTXJ1d1NNZzZNSGdxRkpyS0U3Q3BKUU5rQVZqRGVFejVy?=
 =?utf-8?B?ZFZ6QlZzYTdwNFhPaFVqbDZHM3U2UDhSemY3d1R0b2I5NitITW1xUVlWNkUy?=
 =?utf-8?B?cW53MEhtR1RIb3VKaE92Y3BpdjJzQlNYYXZMNXFhaWgwcHhMd2d6bFFkSzZD?=
 =?utf-8?B?MENGUlUwb3d0LzlqVGl6WE95L1hJUU1JNnNKdEtsNEZrekhsNThqRkcxaU5p?=
 =?utf-8?B?WGJobkhuVGJreWxFMS9XaGFqNmNRcHExclN4UnNHcWhQbHpaaUM2aWJRVjJC?=
 =?utf-8?B?ODRoUnpyU3VRUFFBWHRyVGlFM3hONi9MY0pmcmFBUzloeWZjZ1hyWlZNSGRM?=
 =?utf-8?B?OTRpSWJsSU10eWUyZ1V4c01Ma04xa2xJUCtrY0pwMGw4S2hiNDNzZjBxYzhh?=
 =?utf-8?B?bkZIZ1JkVUpvbUpVaUIvYmNkYnpKRVlQdHowbi85RmtmNldIZVQ5aFpKL1Nt?=
 =?utf-8?B?US9tamFRNDh2eTdFM1pBNEVzS2JQWnF1Z0Q3cE5HODcxT3hqcWFFSGlKN0lM?=
 =?utf-8?B?WEJLSTIzVHVMRTByK1lqRzJIaEo2dGlwbDJOeThmU0tJalNWSlJtV0J4SklB?=
 =?utf-8?B?V0lhWlVGWGUyOXFnOEM5WGpQa1pYaEtUajR5R05uanc0UExmaXFBQTR4Mm82?=
 =?utf-8?B?UzdneHZzRUgxc3pkN2ExV0lyK2tpSjhtMU5PVlpzWDFTUENvSmkyMTBJT1lD?=
 =?utf-8?B?dXI3ejR6cHRMVlpVeWU1RDIxZTJJb1pkTS9lMm9xVWNETlJWbWoxZS95Mlhr?=
 =?utf-8?B?Yzdzc1dXMXgxSnpwZ0ZTTkYreS9ycEFyTjF3WnI1OWJ4NEJ0U2NRTzN1azVn?=
 =?utf-8?B?NWNzU2t4WEl0blpNQlVVMHI5a2V1Tmxjc3c2c3QzU2FBcDdqa0tacE9senVB?=
 =?utf-8?B?bkVXdkVuSmZnTjdzT0pVVnRIS0RYV0pTSzg3QTNxS1duRko0czduT29qd0pi?=
 =?utf-8?B?TjlvUnRXUmRpTkhIRU02Uzh0Y2lTR1lncEg3Ui9yUVQzVXlFcEVCWFpmdy8z?=
 =?utf-8?Q?7Aopugr7sSB6GMMpjFUyk9roRlLSYvyo4XgPrXb?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c6bab56-73ab-4146-15cb-08d989f37dd9
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 00:35:16.5133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ThJzipNtAj/noTRTKwe8p6sFxchul4qDpoPHLE/nNLKkzDl39Ys8M1vQL423nwuHCwyTm2suhZuYqUOsKOICrQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4096
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10130 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110080000
X-Proofpoint-ORIG-GUID: HUPDHBuU3YDMoHeY8wuN88GOQRnBcB1u
X-Proofpoint-GUID: HUPDHBuU3YDMoHeY8wuN88GOQRnBcB1u
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/10/2021 07:27, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable ret is being assigned a value that is never read, it is
> updated later on with a different value. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fs/btrfs/free-space-cache.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index 8ea04582e34b..2a6d02971357 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -735,8 +735,6 @@ static int __load_free_space_cache(struct btrfs_root *root, struct inode *inode,
>   		return 0;
>   	}
>   
> -	ret = -1;
> -

Essentially we had goto out; when the inode generation check failed few
lines below.  However, the commit a67509c30079 (Btrfs: add an io_ctl
struct and helpers for dealing with the space cache) replaced it with
return 0; and then ret = -1 did not make any sense.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand

>   	leaf = path->nodes[0];
>   	header = btrfs_item_ptr(leaf, path->slots[0],
>   				struct btrfs_free_space_header);
>