Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jiasheng Jiang <jiasheng@iscas.ac.cn>
To:     bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
        hpa@zytor.com
Cc:     linux-kernel@vger.kernel.org, Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: Re: [PATCH] x86/microcode/amd: Add __list_del_entry_valid() in front of __list_del() in free_cache()
Date:   Fri,  8 Oct 2021 07:12:01 +0000
Message-Id: <1633677121-81314-1-git-send-email-jiasheng@iscas.ac.cn>
Precedence: bulk

On Tue, Sep 28, 2021 at 22:29:19PM +0000, Christoph Hellwig wrote:
>On Tue, Sep 28, 2021 at 09:04:44AM +0000, Jiasheng Jiang wrote:
>> Directly use __list_del() to remove 'p->plist' might be unsafe,
>> as we can see from the __list_del_entry_valid() of 'lib/list_debug.c'
>> that p->plist->prev or p->plist->next may be the LIST_POISON,
>> or p->list is not a valid double list.
>> In that case, __list_del() will be corruption.
>> Therefore, we suggest that __list_del_entry_valid()
>> should be added in front of the __list_del() in free_cache.

>No one should be using list_del directly anyway, so please fix that.

What the 'fix that' means?