Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for
 PMC controller
To:     "Limonciello, Mario" <mario.limonciello@amd.com>,
        Sachi King <nakato@nakato.io>, hdegoede@redhat.com,
        mgross@linux.intel.com, rafael@kernel.org, lenb@kernel.org,
        Sanket.Goswami@amd.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-acpi@vger.kernel.org, stable@vger.kernel.org
References: <20211002041840.2058647-1-nakato@nakato.io>
 <3ecd9046-ad0c-9c9a-9b09-bbab2f94b9f2@amd.com>
 <909f28e9-245a-df90-52f1-98b0f63a2b3a@amd.com>
From:   Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Message-ID: <609f5254-4527-38b8-3d1d-5cb06791e103@amd.com>
Date:   Fri, 8 Oct 2021 15:57:15 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <909f28e9-245a-df90-52f1-98b0f63a2b3a@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STBUaGdhNHdXYkdSeWZ4d2pVVDhxL2lWais5SmJPUjJwc0xnc3g5QlUzSFNx?=
 =?utf-8?B?blozK1VMS1Q5RmpETTFwVHRLZk0zODVZcmxaOHY2cS9CcGQzTWV1ZXZGTDJx?=
 =?utf-8?B?NW9QeDJmcmJ2QVNlTXA1ZEpKNnFqT1V1S3ZXS3BTNG1lbTFiSlVHeUFVZDV4?=
 =?utf-8?B?Um10NEpvcUZFSHQraDh5Qmo0Vm1mbFFRSXhtZjNWVm8yYTZNNDBybFk4U2Zs?=
 =?utf-8?B?akJwZGo3MXpONlVaQXFGZml4NDVCWGlnekJFeXA1Q2c4STlIcTdJdkRpT05W?=
 =?utf-8?B?dlFDWkdvaWZwamhzZ25ENE4xTGphVzBuY1ZhelhBVFQvZDdCMWswblB3c3cw?=
 =?utf-8?B?b2NwMzNUVUlvNDNXU3NMWHh6bldxTklyUzM5QXZSamdBWmVYM0djaVN3WDNr?=
 =?utf-8?B?ZmVlR21Qek1CNjNLTGdqenZjRlhMV1pFdEpYbGVIaVRZZjRpcDhQanlxUHJK?=
 =?utf-8?B?bU5xMUJGSllGYmhKdjJ5WTYzaEMzSWtmbVh5WTZuN2czd1Q4Q001Z1haRUU0?=
 =?utf-8?B?L2NHNmsyTENWZGRqN25xdllvcFNLNkllTU1DNTh6eXZwMWZ6ZHhIN2dlWEJv?=
 =?utf-8?B?YzIrSFhvRkNyWlRjYlE1azgvakhyTm4zN2YzejBwZHFqVGdONW1hM0VnVDJ5?=
 =?utf-8?B?Qm1TMEZ4OHQ5bWprQkdYZ3NQNVVRc1Rob3NNWWZIMjdxT3BHT3hEZHF3NVNE?=
 =?utf-8?B?ZFJuOTh2SVhiTzc3SkRGTTJ0Rmxyd0E2cnlmaHJJdG4yN2lJZzkwclNqMkZt?=
 =?utf-8?B?YWkvTnB0Q1l2SjAwWXVQaG1ycWVsZnM3TUZqSk53dHVnVkx4dFFIU3hBbXpL?=
 =?utf-8?B?RVd6NTJ3TlFqVU95Y2ptMTZhMEdJN09hc2lVMTlicVVjQjhTQUZRTmQ3Lytq?=
 =?utf-8?B?QUozRGk4TjQ3STlPM09ITjdGKzJrWTk1aEVmaHdEQldySXV2OTNhRldrL1Jm?=
 =?utf-8?B?Z3o5MTkzbzQ1bnYza3JSbDVkM2Nmek8yTms0UEhTZENEL1owbHJ1ZnVRZGtl?=
 =?utf-8?B?REZlZW1vT3h6Nms0R0xWWlpzcXdjMGlITWttNUdHUW1XajNWUTRldHhkRGI1?=
 =?utf-8?B?elpMT0J1K0ZTTjFFSG5lOExVVUJXbkQxejYwV1o3MS95Y3pXR3lRTi9ub2t5?=
 =?utf-8?B?RFY3VGdLV21jTkM3MUdPQTZlRGUyRmpXWU40WWVPMDdGeE51cnJzdW9BbXFT?=
 =?utf-8?B?M00wcEtCaUIvc2lycGFaUzd4bjArZUsxZDdrRURsMjFWek8wSGxkT2wyVnVu?=
 =?utf-8?B?dTNYZ1k3UlpCLzhBU2VVQldyS01LcWFuVDJualROR3RQUExwamFDS0N6alVO?=
 =?utf-8?B?bDdQbFF3R09kVkRsSlJRV1RaamhhRHhLTEhJR29QUHJFWmlwUExlYjdjVjNu?=
 =?utf-8?B?Vk5qQnFmMEdUcm9EcjVncFBJYm44K0xDTi94N0VtRklvaTFuWGl3VmFhenJv?=
 =?utf-8?B?Z2M5YitZYzBLelFvNWQxTnZ4ZHl2SmsyVHcwZ1JvMnBQcURuZGU1azAyRnZ1?=
 =?utf-8?B?NFR5eklHMEFHbWhydEl4UzR4MWtFNzlGMDBmUWl0SVphRUZZSEJGbjIweXND?=
 =?utf-8?B?M0xqeEpJRTc4RDhHMDlSNVk1WG51NTdnVTVKd2RLeFNmZ0hRSGc0Y2dHb21O?=
 =?utf-8?B?UDdhb2YwWjlCaWw5NzRUbjcrVk96WjlVRERsRzlFSDllV3FDMm80TjFhandH?=
 =?utf-8?B?eHd6OHNwSC8zamdidTJnT2RmU1pibi9FU2VlaVhvbWZPZVNQZXlMNSsyS3A0?=
 =?utf-8?Q?869SPjzBWRcwWpPH8Gp3aAjuKXmnbBDL4dRBIR9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1025beba-57ee-4ca7-3713-08d98a463aed
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 10:27:29.2306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NwQ9RcKaCr/K2ISOzf1ZOGlE95dvri8xVMqmeE7sppP8AT13d1TAvJKGp0Uc762m/MlUE6HFqkkT9IwXoedhHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5109
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/8/2021 1:30 AM, Limonciello, Mario wrote:
> +Sanket Goswami
> 
> On 10/5/2021 00:16, Shyam Sundar S K wrote:
>>
>>
>> On 10/2/2021 9:48 AM, Sachi King wrote:
>>> The Surface Laptop 4 AMD has used the AMD0005 to identify this
>>> controller instead of using the appropriate ACPI ID AMDI0005.  Include
>>> AMD0005 in the acpi id list.
>>
>> Can you provide an ACPI dump and output of 'cat /sys/power/mem_sleep'
>>
>> Thanks,
>> Shyam
>>
> 
> I had a look through the acpidump listed there and it seems like the PEP
> device is filled with a lot of NO-OP type of code.  This means the LPS0
> patch really isn't "needed", but still may be a good idea to include for
> completeness in case there ends up being a design based upon this that
> does need it.
> 
> As for this one (the amd-pmc patch) how are things working with it? Have
> you checked power consumption and verified that the amd_pmc debugfs
> statistics are increasing?  Is the system able to resume from s2idle?

Echo-ing to what Mario said, I am also equally interested in knowing the
the surface devices are able to reach S2Idle.

Spefically can you check if your tree has this commit?
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=for-next&id=9cfe02023cf67a36c2dfb05d1ea3eb79811a8720

this would tell the last s0i3 status, whether it was successful or not.

cat /sys/kernel/debug/amd_pmc/smu_fw_info

> 
> Does pinctrl-amd load on this system?  It seems to me that the power
> button GPIO doesn't get used like normally on "regular" UEFI based AMD
> systems.  I do see MSHW0040 so this is probably supported by
> surfacepro3-button and that will probably service all the important events.