Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2267197pxb; Fri, 8 Oct 2021 04:33:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKC4jGhDypu2K2TL3RAMXjhpjDnFRSzTdrTyXrvfFdKK5bHlwpDV7J+yjZAQSSBzlPhvWs X-Received: by 2002:a63:ef01:: with SMTP id u1mr4218150pgh.336.1633692831789; Fri, 08 Oct 2021 04:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633692831; cv=none; d=google.com; s=arc-20160816; b=qHp+xfjtU8gciyhVk8p0XZNuKe9okmIm89/U+V0ggj2k2v7bJiSzmQpTpmVkUEEsqH 0dmDZy/MNsDH7Evd0YW4lNI2eWuzlBBXlxBBjoHiT+rW1KL2eOjtvBZEZVB7cJ/Yx2VS upNlU+TPzGgzE+GYyAoOn1UC82rIh8koQgRv3Te07km4kn/AbYmTEZMhSIbHQIvnCpF5 LVpkqQoq7tR9Z1oy6y3LL3oQhh0oz38uKv/wYeRIITwXAGi7/pnzb+5PABCwYS/ANHXQ Z4YA8iJ/giBkLsNeknWtCqsDphcWoiCYZ7yV/pVUW7ZxbJECCkRYuDqR10YSZvo5rGID l4bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Yx0qUxiDPo8d9nC3026nPLnIpEu3aA3w2Y1XN6YczP8=; b=gweK1u7/0lLA6gttQrHmFVbF9j8hYOo0shTj9uuy6ZJvoct8F0M2sMY9IZ/AKOWy0e jfvVjCjK9oCj5M3M6QAtwgRj1hWS0D3gIjA7vAR5TyNXeQS7Fd1IIqqGnguPVt/S1Xgd gJZN4QDsDypF35nQXWECbNwa3DQRK91TYGNq6SR9JyX1YSRUch1JIuQJpK1ldYxBSEvs URT+FQYeYhFZ8tT2gmXXEZbxZZTN8DXPV7aeIXjkVvy1YwDtshmF1PjJVRAWYBPLmoh5 yOL3y+Gan+2rt/7udha3mXbSffELJYJ6vTBgrzfqW+qoQJFu8PVtfbpHewGnoZzw0kkU YTMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=piUU1trN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 189si2615150pgc.391.2021.10.08.04.33.37; Fri, 08 Oct 2021 04:33:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=piUU1trN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241662AbhJHLd4 (ORCPT + 99 others); Fri, 8 Oct 2021 07:33:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:59392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240795AbhJHLcJ (ORCPT ); Fri, 8 Oct 2021 07:32:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 583A061039; Fri, 8 Oct 2021 11:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692586; bh=iVoLt0e6/EnuelBsXgh2FhH+54Op2ZK8P4ECKCVv4ZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=piUU1trN1nYh2kA1yLsvTREXhUGiYA5X5Myq6k2abilAZBxu/EtbKoM//FKsrBf2O FAirRczAvFuxS87tJLmRzM02eQhvCuns7jv3bSXHuKLQCXfSOxYg9AyrFeG/1Xr8N8 b0w9FDHquFNQXU7rY7Mm2nc0Y+tQgDWtb1Prp27c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Beulich , Paul Durrant , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 02/12] xen-netback: correct success/error reporting for the SKB-with-fraglist case Date: Fri, 8 Oct 2021 13:27:50 +0200 Message-Id: <20211008112714.684087230@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112714.601107695@linuxfoundation.org> References: <20211008112714.601107695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jan Beulich [ Upstream commit 3ede7f84c7c21f93c5eac611d60eba3f2c765e0f ] When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this shouldn't matter much as the overall transmit will need to be considered failed anyway. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 41bdfb684d46..4d0d5501ca56 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -492,7 +492,7 @@ check_frags: * the header's copy failed, and they are * sharing a slot, send an error */ - if (i == 0 && sharedslot) + if (i == 0 && !first_shinfo && sharedslot) xenvif_idx_release(queue, pending_idx, XEN_NETIF_RSP_ERROR); else -- 2.33.0