Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2267382pxb; Fri, 8 Oct 2021 04:34:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4xf6AtFusjIKXHUSgpUlGrW572a8SfJ3S0rmqC0XN9RhnRu+36vpTcjgCpX42aRWO2d3C X-Received: by 2002:a63:8c42:: with SMTP id q2mr4274481pgn.325.1633692842875; Fri, 08 Oct 2021 04:34:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633692842; cv=none; d=google.com; s=arc-20160816; b=D/u2HbnMico6V4lG/MMqDAXxR+2VHJrVZTsg5QHNauQHIcROPyBl1bID1pwRdENUQG xyTGcn2EaUJKib1mD9UQBU1YiNTXxCRMBzv4Kzzjw9rv8lJ0vbQaA8XTaI0HlsSo3YTd GL+B7FmMeewWemUU5OALKn105u8hBojIbRsA/r2zUp7bHFHWszIRsr1vwaQF9+/sKf42 xN5XSlplRdpw3oLTYW2BSguVtLUq5m2oujWsHFGqqe1Fkw5hk/MpLw74Q/rkkMgQ4NZK rMf/CHE4aF8TMYO7ApMgYF6Ecg+V0LEuE6cyE5aNQmlL9a1yMok8zXzLSZa+gmnmU9C/ tBKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mu3S2v7LcQ6txtTVUiIIg/QH4LG4wiICGVtq8pWJTDo=; b=bib4NCl/Yom2LapFHKwDMQ7QnTuS6CUJCk4RakqaGxrIsO4/410w3zgqo4ktooLSqk 4LUsx2Z+CgkKjO7U7aabFubR0levAiJ3gZofQ9IOBQa0duSgm8nikbtsoJSIYHBKSxjQ 9aWSztnqN0kTIDxn/d9vu33VnHbTaE78pP8dOO3ptD9XOlfjenuaaAC+qrnItV9yeKt2 UR9FzOoT7mDTLlJXARAwm8tJyf5YUaxViTmPv8w5Q0kGUq04a6WEkn0bGy2zhLrwrxfS 5BnSuJvNaKVPvXpspbue8oY2aQbvtdQBKh/AdeW6Rf48ZtRyMyHIwPHGqH/PyOaxFo2H akSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r13ReYLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si2711644plk.454.2021.10.08.04.33.49; Fri, 08 Oct 2021 04:34:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r13ReYLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241590AbhJHLdx (ORCPT + 99 others); Fri, 8 Oct 2021 07:33:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:60688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241129AbhJHLcK (ORCPT ); Fri, 8 Oct 2021 07:32:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3670C61283; Fri, 8 Oct 2021 11:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692597; bh=hvvol/WnNDR9Ex7DOkdK4SNSSmPXLQicgu6bxiu1ou8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r13ReYLPrJ/G9r102zlMtLJCg3NbaFsIA6P7d6v3RzX0n6+4Do5kOvRhNfkjQeRzW T2RmIAVLLNSjIRD3Tc7eK8fVBxs4ERXnPox09CvuZ7IDi3V0CTaLxhMCOM1oqf+i9g E/1ofXNhWmQFMwp27K57pkd/O0stU4SQ1djECJ9I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Sasha Levin Subject: [PATCH 4.19 07/12] usb: dwc2: check return value after calling platform_get_resource() Date: Fri, 8 Oct 2021 13:27:55 +0200 Message-Id: <20211008112714.835793384@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112714.601107695@linuxfoundation.org> References: <20211008112714.601107695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit 856e6e8e0f9300befa87dde09edb578555c99a82 ] It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20210831084236.1359677-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/dwc2/hcd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 58e53e3d905b..22c4d554865e 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -5234,6 +5234,10 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg) hcd->has_tt = 1; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + retval = -EINVAL; + goto error1; + } hcd->rsrc_start = res->start; hcd->rsrc_len = resource_size(res); -- 2.33.0