Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dma-buf: Update obsoluted comments on
 dma_buf_vmap/vunmap()
To:     Shunsuke Mie <mie@igel.co.jp>,
        Sumit Semwal <sumit.semwal@linaro.org>
Cc:     linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20211008112009.118996-1-mie@igel.co.jp>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <5ae41c5a-0ff4-5a82-2100-56bc415b5638@amd.com>
Date:   Fri, 8 Oct 2021 14:09:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211008112009.118996-1-mie@igel.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUZ2YThLOVNBVjIyanE5MFk3SndKRTVRdWo0SC9WWE5yZmY5OG5LZXlmUWhy?=
 =?utf-8?B?US92WDd2Z0U4Z3p6eHdrbU1zQkZCZXoxcmFLTUlDS1FJVVVORE9LZXplejhi?=
 =?utf-8?B?bHMzK3lMSnJkc1ZKNFUzRy9STXVyeXNoays1MnlEUzVxSy95YnJPV2pBcXc3?=
 =?utf-8?B?NU1oTEhmNDU5dHFRdjJpWWtaYVcwRHpLSCtxdzBlMU9rSnUxWmtaNUhGSnQv?=
 =?utf-8?B?T0dSZVhVL3FidW1iZnNkMU9ENlRqeGN0WmdnbUlqYlhRUmUvVytPam4wQlYw?=
 =?utf-8?B?V2pMN0JiNi93cWFRNGN0dStpSzRsbW83cG94elhRQ2RKY1BkV2xleFk1dUZD?=
 =?utf-8?B?L1N3Vm1ZbzlzdmEwbXM1eHFDVXFpanBBekY3N0w1WVFhWDhDU2pSNmZZVkk4?=
 =?utf-8?B?a1paekkxU3pzQjhPTWF2V0FNWEpIRDkrcEZPSGs0Q2NaVFhUeWJMMGhleG9i?=
 =?utf-8?B?UEt5Mk15OURUb2xTekFqaGhyZGZVWktoR0F0dFE2YUZvWmRxdjdCUll1SitC?=
 =?utf-8?B?YmMvN1VoUUxjTWp4ZllsZHUxMTM2b2M2cHBDUEM2d2tFdW9PUWhoYzRyTVVh?=
 =?utf-8?B?V21yVjNXVWVBN1FMZW1ickRPbFRKTkhvSzBud25GZVQxRitGVEcrbHBJNDhn?=
 =?utf-8?B?WmNUWXZmejZ4TGY3N0NmV0MzSS9iNVZvdmhpRGlpbndPZUZnVS83M2k1WEV3?=
 =?utf-8?B?Ty9tb1FseXFkTzhCcmxUK1gvWm5ZVGxCSmpIbkZNd2E4dGM1bE9mREZTSFMw?=
 =?utf-8?B?MVV3Wmd4c29lajZWcWRUL0FhVTcyMHpTRlBsalBEK1N1Y1RwZ3p0Q2NrRjBD?=
 =?utf-8?B?NmtleU1WMnkrRGdLcTZzaUl5RzJjckV3MmRjZlg3OEtmc0NTYUxzL1ZFRkRJ?=
 =?utf-8?B?L3VCNkZXNlRPWHh3OFU4Q2RHaHhubkx5R1Z5VndxbmtmR2x2Tm1EcjlqSWhy?=
 =?utf-8?B?Zk1uM0RLWW15aUs4WU5IdWE2ampFZytIb0ZrU3VKOEo3cHNyL0JjV0hVZU4x?=
 =?utf-8?B?WUpVZWtPVk9IVDVrY0FadXVBOHd1amF6eUVhV1BmcEs4ZVg4K3NucVNJTEhC?=
 =?utf-8?B?WDNEQTR2Q3J0dEw4eG5xaVFzeDE3NFB0aFpwclFMMkloaDhaZFBXSU1CaUxt?=
 =?utf-8?B?d1NxeXZlTE5rK09NVFJTQ0xFdExIUlVzM3ZWb2FFaVlBRVJRc20vUVpRRjFQ?=
 =?utf-8?B?K2dYZkZaLzB1aktmNWVaZXE0Wk5Ebm5md3B1NURKelBVVUJ2YnVjOVFtL1FJ?=
 =?utf-8?B?MGtpOS9nRnd5amRvZU9aQm84dkg3TW5sVFpPRzAyNCsvdC83VWhTampXR3hq?=
 =?utf-8?B?VktuQ3NxSWVDMCt6Mm1QT3RSd1NjQ1RtUkptWFQydzVzVnJBRFlGaVp4Vno2?=
 =?utf-8?B?S0xpb0JqeHdiY1IrTkVXazF5NkEyK0k0d09XQ2pEVi9jSnZVZHVNcnN2Vnda?=
 =?utf-8?B?WTduQ2l2VnRIRExzM0NYaXVTWmdybGU3SHdOQksrRlBEbzdaUkcxd1gvNUtk?=
 =?utf-8?B?WHBmUVZseGsrOFZIelB2MVB4Y0VUcFBleDZXY1Fndi9YSVBXT3dMd0tpSEVl?=
 =?utf-8?B?TWlldXJraDdwL0RoeWVKOVRPQVZtbEdRY1l3Yzc4R0VSalhEUXUwL2VVV292?=
 =?utf-8?B?T2JVb3lWTUpJSGtnanpja1FIRXJwM1pPazhWSnhEdG92LzA1MzZyNU10Skdo?=
 =?utf-8?B?NTVuZUdPd3lia1lzaWlGL09ZN1R4WStaM3E1WWQ0TWV5OWhrY0VQWVRtU0Vv?=
 =?utf-8?B?amdqdXdKSTZwekFRWmtYR01hS0RNVTlTa1UxVGFZUFBoWGNLYmwvcHEweXhQ?=
 =?utf-8?B?ZUhDVzdzbFliS3JXTVVUam0rWU1JdW5SWHlTYklwQWRKOG92UmxXUWNMSVV5?=
 =?utf-8?Q?gwit8Wz1uuuA4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11843768-652c-4cae-003b-08d98a548634
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 12:09:48.8914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /7mgNAUYQqxKCRCziuguPzz2SDv7heVJw6NkhmtpdhELhx0Y+03DFlS0ZkyXruyP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1213
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 08.10.21 um 13:20 schrieb Shunsuke Mie:
> A comment for the dma_buf_vmap/vunmap() is not catching up a
> corresponding implementation.
>
> Signed-off-by: Shunsuke Mie <mie@igel.co.jp>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/dma-buf/dma-buf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index beb504a92d60..7b619998f03a 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -1052,8 +1052,8 @@ EXPORT_SYMBOL_GPL(dma_buf_move_notify);
>    *
>    *   Interfaces::
>    *
> - *      void \*dma_buf_vmap(struct dma_buf \*dmabuf)
> - *      void dma_buf_vunmap(struct dma_buf \*dmabuf, void \*vaddr)
> + *      void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
> + *      void dma_buf_vunmap(struct dma_buf \*dmabuf, struct dma_buf_map \*map)
>    *
>    *   The vmap call can fail if there is no vmap support in the exporter, or if
>    *   it runs out of vmalloc space. Note that the dma-buf layer keeps a reference