Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp2399221pxb; Fri, 8 Oct 2021 07:05:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHBLbxuIiy1jJLpv892Pn4MgZ+Ee/02pJm2dO80y31CXExoHo0qE+MtFNdPaQKu3XWX6iA X-Received: by 2002:a50:e14a:: with SMTP id i10mr15430400edl.73.1633701933515; Fri, 08 Oct 2021 07:05:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633701933; cv=none; d=google.com; s=arc-20160816; b=Kff520db24tkErSE9lp6y+N8g8eec6p1jm8fnnoRRTe3ssl8ynVKOIDSx18vx2WdVp NZKfdu12Xqsa0543qqNStbJTyzXfH7xNySCU+ZCaTA1AxIJ7tCp/b2Jpz+ECTAS4ZT+Q mL7K2m2h1S8kKAH9/3k9Y4F69LQ41ZnM/eJTUGYQGMoiJtCXpcdeqJN+sr4Hr+JULP5E 04E9ezBXV7iPx1VCGjObUWs0z83CP0Sx5+w7B5cE6b+06B1O4Zax8j2pNtlYf0LmG6J5 zW4/y0wbpIFeAaVBegiKShCLNE0wKtX86/Nig2RyxG7+SVBHVSn0kVECxySFUsFXqWNW 2iVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=lq3gMneyueM39uyGnljUAL01Idms2jKi7IYP6rh3iNo=; b=r67C8nrdyEhqe6Pu3YfMU9HZ7GvsH+L99Gqo21U2DXjkB+3SVzUx295pBZQdFQFGAE sM4sOBA8+q16WC2pvzufvoWQK41pZeBwU9CknK92ujKDt/No9kJXYbsoLokninQeLlGV IMX/kiayQWOIpp2ysfKrzJcCFCmZ6Q3Dt/bENWeJWmHRoHzQDzq4gFAYpWTq/weWkLTn wl8DmnvfladkqP5K2Op3v3KY5DzKTGVvyCuI6GCXZa05CI89iuxS9h5HhT1GROLZpaz/ DVU41n+FfrcijkW3vx+9C9Ohpfq7xGqoBX9agwOHqkiYxqhmbOLt01RxIeB9eEskqhBu Fb9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v25si3697911eja.535.2021.10.08.07.05.08; Fri, 08 Oct 2021 07:05:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232200AbhJHOFI (ORCPT + 99 others); Fri, 8 Oct 2021 10:05:08 -0400 Received: from foss.arm.com ([217.140.110.172]:54092 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234083AbhJHOFI (ORCPT ); Fri, 8 Oct 2021 10:05:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93B316D; Fri, 8 Oct 2021 07:03:12 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1E253F66F; Fri, 8 Oct 2021 07:03:10 -0700 (PDT) From: Valentin Schneider To: Frederic Weisbecker , "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , Sebastian Andrzej Siewior , Peter Zijlstra , Uladzislau Rezki , Thomas Gleixner , Boqun Feng , Neeraj Upadhyay , Josh Triplett , Joel Fernandes , rcu@vger.kernel.org Subject: Re: [PATCH 00/11] rcu: Make rcu_core() safe in PREEMPT_RT with NOCB + a few other fixes In-Reply-To: <87fstkmybc.mognet@arm.com> References: <20210929221012.228270-1-frederic@kernel.org> <87fstkmybc.mognet@arm.com> Date: Fri, 08 Oct 2021 15:03:02 +0100 Message-ID: <87ee8vlill.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/21 18:47, Valentin Schneider wrote: > On 30/09/21 00:10, Frederic Weisbecker wrote: >> PREEMPT_RT has made rcu_core() preemptible, making it unsafe against >> concurrent NOCB (de-)offloading. >> >> Thomas suggested to drop the local_lock() based solution and simply >> check the offloaded state while context looks safe but that's not >> enough. Here is a bit of rework. >> >> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git >> rcu/rt >> >> HEAD: aac1c58961446c731f2e989bd822ca1fd2659bad >> >> Thanks, >> Frederic > > FWIW I've had RCU torture with NOCB toggling running for half a day on my > Arm Juno and nothing to report. I still need to rebase this on an -rt tree > and give it a spin with CONFIG_PREEMPT_RT. Rebased on top of v5.15-rc4-rt7-rebase with Thomas' patch reverted and ran the same thing under CONFIG_PREEMPT_RT, nothing seems to catch on fire, so: Tested-by: Valentin Schneider